| Message ID | 20240818072729.33511-1-vishnuocv@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | Adding Support for Thinkpad X12 Gen 2 Kbd Portfolio with 0x61AE as PID | expand |
All, Do we have any comments or feedback on this patch? On Sun, Aug 18, 2024 at 4:28 PM Vishnu Sankar <vishnuocv@gmail.com> wrote: > > This applies similar quirks used by previous generation device, so that > Trackpoint and buttons on the touchpad works. > New USB KBD PID 0x61AE for Thinkpad X12 Tab is added. > > Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com> > Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca> > --- > drivers/hid/hid-ids.h | 1 + > drivers/hid/hid-multitouch.c | 6 ++++++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > index 72d56ee7c..981813f50 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -807,6 +807,7 @@ > #define USB_DEVICE_ID_LENOVO_X1_TAB 0x60a3 > #define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5 > #define USB_DEVICE_ID_LENOVO_X12_TAB 0x60fe > +#define USB_DEVICE_ID_LENOVO_X12_TAB2 0x61ae > #define USB_DEVICE_ID_LENOVO_OPTICAL_USB_MOUSE_600E 0x600e > #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D 0x608d > #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_6019 0x6019 > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 56fc78841..1b0844ffa 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -2081,6 +2081,12 @@ static const struct hid_device_id mt_devices[] = { > USB_VENDOR_ID_LENOVO, > USB_DEVICE_ID_LENOVO_X12_TAB) }, > > + /* Lenovo X12 TAB Gen 2 */ > + { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU, > + HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8, > + USB_VENDOR_ID_LENOVO, > + USB_DEVICE_ID_LENOVO_X12_TAB2) }, > + > /* Logitech devices */ > { .driver_data = MT_CLS_NSMU, > HID_DEVICE(BUS_BLUETOOTH, HID_GROUP_MULTITOUCH_WIN_8, > -- > 2.43.0 >
On Tue, 10 Sep 2024, Vishnu Sankar wrote:
> Do we have any feedback or comments about this patch?
Sorry, this slipped in between cracks.
Now applied, thanks.
Thank you for the acceptance. On Wed, Sep 11, 2024 at 9:18 PM Jiri Kosina <jikos@kernel.org> wrote: > > On Tue, 10 Sep 2024, Vishnu Sankar wrote: > > > Do we have any feedback or comments about this patch? > > Sorry, this slipped in between cracks. > > Now applied, thanks. > > -- > Jiri Kosina > SUSE Labs >
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 72d56ee7c..981813f50 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -807,6 +807,7 @@ #define USB_DEVICE_ID_LENOVO_X1_TAB 0x60a3 #define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5 #define USB_DEVICE_ID_LENOVO_X12_TAB 0x60fe +#define USB_DEVICE_ID_LENOVO_X12_TAB2 0x61ae #define USB_DEVICE_ID_LENOVO_OPTICAL_USB_MOUSE_600E 0x600e #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D 0x608d #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_6019 0x6019 diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 56fc78841..1b0844ffa 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -2081,6 +2081,12 @@ static const struct hid_device_id mt_devices[] = { USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_X12_TAB) }, + /* Lenovo X12 TAB Gen 2 */ + { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU, + HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8, + USB_VENDOR_ID_LENOVO, + USB_DEVICE_ID_LENOVO_X12_TAB2) }, + /* Logitech devices */ { .driver_data = MT_CLS_NSMU, HID_DEVICE(BUS_BLUETOOTH, HID_GROUP_MULTITOUCH_WIN_8,