diff mbox series

HID: corsair-void: Add missing initializer

Message ID 20241020195717.CD7CC17525E@bout3.ijzerbout.nl (mailing list archive)
State New
Delegated to: Jiri Kosina
Headers show
Series HID: corsair-void: Add missing initializer | expand

Commit Message

Kees Bakker Oct. 20, 2024, 7:47 p.m. UTC
This was detected by Coverity, CID 1600743

Signed-off-by: Kees Bakker <kees@ijzerbout.nl>
---
 drivers/hid/hid-corsair-void.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stuart Oct. 24, 2024, 1:51 a.m. UTC | #1
Good catch, thanks

Are you aware of 'scripts/get_maintainer.pl'? It might tell you to CC
Jiri Kosina and Benjamin Tissoires, as they can actually apply this.

Stuart

On Sun, 20 Oct 2024 at 20:57, Kees Bakker <kees@ijzerbout.nl> wrote:
>
> This was detected by Coverity, CID 1600743
>
> Signed-off-by: Kees Bakker <kees@ijzerbout.nl>
> ---
>  drivers/hid/hid-corsair-void.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c
> index 6ece56b850fc..d1fd04264656 100644
> --- a/drivers/hid/hid-corsair-void.c
> +++ b/drivers/hid/hid-corsair-void.c
> @@ -553,7 +553,7 @@ static void corsair_void_battery_remove_work_handler(struct work_struct *work)
>  static void corsair_void_battery_add_work_handler(struct work_struct *work)
>  {
>         struct corsair_void_drvdata *drvdata;
> -       struct power_supply_config psy_cfg;
> +       struct power_supply_config psy_cfg = {};
>         struct power_supply *new_supply;
>
>         drvdata = container_of(work, struct corsair_void_drvdata,
> --
> 2.47.0
>
diff mbox series

Patch

diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c
index 6ece56b850fc..d1fd04264656 100644
--- a/drivers/hid/hid-corsair-void.c
+++ b/drivers/hid/hid-corsair-void.c
@@ -553,7 +553,7 @@  static void corsair_void_battery_remove_work_handler(struct work_struct *work)
 static void corsair_void_battery_add_work_handler(struct work_struct *work)
 {
 	struct corsair_void_drvdata *drvdata;
-	struct power_supply_config psy_cfg;
+	struct power_supply_config psy_cfg = {};
 	struct power_supply *new_supply;
 
 	drvdata = container_of(work, struct corsair_void_drvdata,