diff mbox series

[4/6] dt-bindings: input: matrix_keypad - add settle time after enable all columns

Message ID 20241031063004.69956-5-markus.burri@mt.com (mailing list archive)
State New
Headers show
Series Input: matrix-keypad: Various performance improvements | expand

Commit Message

Markus Burri Oct. 31, 2024, 6:30 a.m. UTC
Matrix_keypad with high capacity need a longer settle time after enable
all columns.
Add optional property to specify the settle time

Signed-off-by: Markus Burri <markus.burri@mt.com>
Reviewed-by: Manuel Traut <manuel.traut@mt.com>
Tested-by: HeDong Zhao <hedong.zhao@mt.com>
---
 Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski Oct. 31, 2024, 8:32 a.m. UTC | #1
On Thu, Oct 31, 2024 at 07:30:02AM +0100, Markus Burri wrote:
> Matrix_keypad with high capacity need a longer settle time after enable
> all columns.
> Add optional property to specify the settle time
> 
> Signed-off-by: Markus Burri <markus.burri@mt.com>
> Reviewed-by: Manuel Traut <manuel.traut@mt.com>
> Tested-by: HeDong Zhao <hedong.zhao@mt.com>

How was a TXT binding tested?

Both tags look fake, where were they given?

> ---
>  Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
> index 570dc10..cf43fa0 100644
> --- a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
> +++ b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
> @@ -24,6 +24,8 @@ Optional Properties:
>  - debounce-delay-ms:	debounce interval in milliseconds
>  - col-scan-delay-us:	delay, measured in microseconds, that is needed
>  			before we can scan keypad after activating column gpio
> +- all-cols-on-delay-us:	delay, measured in microseconds, that is needed
> +			after activating all column gpios, default is no delay.

Binding should be converted to DT schema first.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
index 570dc10..cf43fa0 100644
--- a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
+++ b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
@@ -24,6 +24,8 @@  Optional Properties:
 - debounce-delay-ms:	debounce interval in milliseconds
 - col-scan-delay-us:	delay, measured in microseconds, that is needed
 			before we can scan keypad after activating column gpio
+- all-cols-on-delay-us:	delay, measured in microseconds, that is needed
+			after activating all column gpios, default is no delay.
 - drive-inactive-cols:	drive inactive columns during scan,
 			default is to turn inactive columns into inputs.