| Message ID | 20250107135659.185293-5-markus.burri@mt.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Input: matrix-keypad: Various performance improvements | expand |
On Tue, Jan 07, 2025 at 02:56:56PM +0100, Markus Burri wrote: > The property is implemented in the driver but not described in dt-bindings. > Add missing property 'gpio-activelow' to DT schema. > > Signed-off-by: Markus Burri <markus.burri@mt.com> > > --- > .../devicetree/bindings/input/gpio-matrix-keypad.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml > index 75975a1..b10da65 100644 > --- a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml > +++ b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml > @@ -38,6 +38,9 @@ properties: > type: boolean > description: Do not enable autorepeat feature. > > + gpio-activelow: > + type: boolean > + description: The GPIOs are low active. Ideally this should be defined correctly in the gpio properties. The problem is that does a 0 flag value mean active high or I forgot to define it. There's a similar issue in spi-controller.yaml. I *think* the problem is better here since this is an active low boolean rather than an active high boolean. Of the users in the kernel tree, only arch/arm/boot/dts/ti/omap/am335x-guardian.dts got this right. So I think we should mark this deprecated and put a note to use GPIO flags instead. Rob
On Tue, Jan 07, 2025 at 02:56:56PM +0100, Markus Burri wrote: > The property is implemented in the driver but not described in dt-bindings. > Add missing property 'gpio-activelow' to DT schema. Wasn't this added for ACPI or some platform-data users? It is not really a correct reason to document something post-factum just because review was skipped... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml index 75975a1..b10da65 100644 --- a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml +++ b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml @@ -38,6 +38,9 @@ properties: type: boolean description: Do not enable autorepeat feature. + gpio-activelow: + type: boolean + description: The GPIOs are low active. debounce-delay-ms: description: Debounce interval in milliseconds.
The property is implemented in the driver but not described in dt-bindings. Add missing property 'gpio-activelow' to DT schema. Signed-off-by: Markus Burri <markus.burri@mt.com> --- .../devicetree/bindings/input/gpio-matrix-keypad.yaml | 3 +++ 1 file changed, 3 insertions(+)