From patchwork Thu Jun 2 16:35:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: simon@mungewell.org X-Patchwork-Id: 844172 X-Patchwork-Delegate: jikos@jikos.cz Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p52GZZ3X009658 for ; Thu, 2 Jun 2011 16:35:36 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788Ab1FBQfe (ORCPT ); Thu, 2 Jun 2011 12:35:34 -0400 Received: from host171.canaca.com ([67.55.55.225]:36258 "EHLO host171.canaca.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704Ab1FBQfd (ORCPT ); Thu, 2 Jun 2011 12:35:33 -0400 Received: from localhost ([127.0.0.1] helo=host171.canaca.com) by host171.canaca.com with esmtpa (Exim 4.69) (envelope-from ) id 1QSArr-0007zQ-GN; Thu, 02 Jun 2011 12:35:31 -0400 Received: from 127.0.0.1 ([127.0.0.1]) (SquirrelMail authenticated user simon@mungewell.org) by host171.canaca.com with HTTP; Thu, 2 Jun 2011 12:35:31 -0400 Message-ID: <2b85316d7925dad6c55672d7d9738e18.squirrel@host171.canaca.com> Date: Thu, 2 Jun 2011 12:35:31 -0400 Subject: Re: [PATCH v2] hid: Fix Logitech Driving Force Pro wheel From: simon@mungewell.org To: "Michael Bauer" Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Kosina" User-Agent: SquirrelMail/1.4.21 MIME-Version: 1.0 X-Priority: 3 (Normal) Importance: Normal X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host171.canaca.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - mungewell.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 02 Jun 2011 16:35:46 +0000 (UTC) > Changes from initial patch: > - shorten comment (removed original descriptor) > - optimized new descriptor (simpler and shorter) Concept looks go to me, but I'm getting --- simon@ubuntu:~/linux-2.6$ patch -p 1 < ../Downloads/v2-hid-Fix-Logitech-Driving-Force-Pro-wheel.patch patching file drivers/hid/hid-lg.c patch: **** malformed patch at line 91: USB_DEVICE_ID_LOGITECH_G25_WHEEL), -- Looks like word wrap has been applied to the patch. It also fails to patch chunk 3 against 3.0rc1 as the G27 wheel has been added. -- -- { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL), .driver_data = LG_FF }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G27_WHEEL), .driver_data = LG_FF }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFP_WHEEL), .driver_data = LG_FF }, -- All that said it appears to build (don't have this wheel to test) and have it in a git archive if you'd like be to spin a fixed patch for you. Simon -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- drivers/hid/hid-lg.c 2011-05-19 06:06:34.000000000 +0200 +++ drivers/hid/hid-lg.c 2011-05-30 21:49:51.535184784 +0200 @@ -450,7 +522,7 @@ { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL), .driver_data = LG_FF }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFP_WHEEL), - .driver_data = LG_FF }, + .driver_data = LG_NOGET | LG_FF }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,