From patchwork Fri Jan 13 21:06:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9516411 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7E2D160762 for ; Fri, 13 Jan 2017 21:08:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6F89E206E2 for ; Fri, 13 Jan 2017 21:08:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 644DB283B9; Fri, 13 Jan 2017 21:08:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EECEB206E2 for ; Fri, 13 Jan 2017 21:08:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751153AbdAMVHe (ORCPT ); Fri, 13 Jan 2017 16:07:34 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:65485 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751141AbdAMVGU (ORCPT ); Fri, 13 Jan 2017 16:06:20 -0500 Received: from wuerfel.localnet ([78.43.21.235]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.129]) with ESMTPSA (Nemesis) id 0MHKKd-1cFH1i3Izz-00E40R; Fri, 13 Jan 2017 22:06:13 +0100 From: Arnd Bergmann To: Dmitry Torokhov Cc: Andrew Duggan , Christopher Heiny , Nick Dyer , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol Date: Fri, 13 Jan 2017 22:06:12 +0100 Message-ID: <3051252.9A92ba0o10@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20170113062203.GD22630@dtor-ws> References: <20170110121718.2992211-1-arnd@arndb.de> <20170113062203.GD22630@dtor-ws> MIME-Version: 1.0 X-Provags-ID: V03:K0:o6RmyYzpixvdbqa6yjg/gKkj0LKHvfvZMHthrmlG90vtp+L8stB vmet/2pL8uTmQ9HN/TE1JubDahvvE3hx3NoJ2eO6SP4gxy7+7u9HyPXAYbMsN/EOEYy72DR prUehxIbBRyw25diGgPba+LbUxMHF04ixdyY2kssIV4cZ7kPDWPETCJkvBpzE/a8LmE2Lv9 Onf4JRR+22JzIvrLBKSQw== X-UI-Out-Filterresults: notjunk:1; V01:K0:34qYrn2uE3g=:7HUvo2Z7Q/jvitPyZJ+c75 ZOu/Tsny4gyhrXNG1GK6Jm5tXShhR+IkNe8Qb+n7Bodv9rPZUoC6aWvNrY0ToXlRgLJwAPKJW XOwEV6CtQEfMq9PbosK5rzynxBFxYAYW0FD52uFDt7nwH4Z3bJ8x8SR9jIm8fW21csnqZGcsg OHLvo8N0AxHXeggoo2rB/S5yHZfzdPLxaesSccbe06rfqkuXEu9aQcBL98qhBJOA2qLHq7YXw jJG1//IQimKExVXt6WwN09zNfUvA9b6BulaDwHZINdRkGqxzHzNjKYBtQJ+s+Gva7E/mUJIOn zY1NoP6gy4AyJGBDMHaKei+j4IWBRMvWuY4H/Z5+3H8t9FbX3IWwE3fzB7lcWXfAN8fKqFVV1 Oblf3CWzbmP7SR/c82RSwhigN+yJ3qBFMus5LHNzKdn04vJSXdhYo18+jcVPRwh7d06+UI5ad +NoyJ1+Lj9KH9lF3+uewd02aNQs3OvDOaqlwjRISZ7pcaERBzWAZVaQTORstbg9p3Xb/T/0uS 0MQtcJn2ebz4+W3DPlp1Ysyjbf/RzH2TiYuMhyliQyFNdzDSsvU+pQ0x80psfWKbUp6oW2i4L tyRC/7fwIo1KMHOUGRJDwMekpjHCEIkdzqwewnOBQzWZf2Y9NJvjskn1kc+1Dnf4OdTUdil3y wxHGkJMr5bj+RQorgx00bqGgY/qOmmgR+bnQP86kUpGqT37zBIEyDRV1VR5Ew8xzQaZLuoKsQ BpSQi2KWl9GlhrEm Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thursday, January 12, 2017 10:22:03 PM CET Dmitry Torokhov wrote: > As it was explained townthread we can't [currently] make functions > modules, in the meantime I have d7ddad0acc4add42567f7879b116a0b9eea31860 > that should fix this issue (and I just sent pull request for it). On today's linux-next (which includes d7ddad0acc4ad), I was still getting this warning : warning: (HID_RMI) selects RMI4_F03 which has unmet direct dependencies (!UML && INPUT && RMI4_CORE && (SERIO=y || RMI4_CORE=SERIO)) This is my fixup, though I'm not too happy with that version. Signed-off-by: Arnd Bergmann --- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 1aeb80e52424..3927259a5d5d 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -785,7 +785,8 @@ config HID_SUNPLUS config HID_RMI tristate "Synaptics RMI4 device support" depends on HID - select RMI4_CORE + depends on SERIO && RMI4_CORE + depends on SERIO=y || RMI4_CORE=SERIO select RMI4_F03 select RMI4_F11 select RMI4_F12