From patchwork Mon Jul 23 15:03:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanno Zulla X-Patchwork-Id: 10540483 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9D18B14BC for ; Mon, 23 Jul 2018 15:03:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8BF6D20243 for ; Mon, 23 Jul 2018 15:03:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8010B26490; Mon, 23 Jul 2018 15:03:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 02FBB20243 for ; Mon, 23 Jul 2018 15:03:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388099AbeGWQF3 (ORCPT ); Mon, 23 Jul 2018 12:05:29 -0400 Received: from zoot.epublica.de ([78.46.103.157]:49678 "EHLO zoot.epublica.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388070AbeGWQF3 (ORCPT ); Mon, 23 Jul 2018 12:05:29 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by zoot.epublica.de (Postfix) with ESMTP id 825681841771; Mon, 23 Jul 2018 17:03:49 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at zoot.epublica.de Received: from zoot.epublica.de ([127.0.0.1]) by localhost (zoot.epublica.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xgEvLmG4ghRG; Mon, 23 Jul 2018 17:03:48 +0200 (CEST) Received: from [10.1.0.41] (ip1f103e43.dynamic.kabel-deutschland.de [31.16.62.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by zoot.epublica.de (Postfix) with ESMTPSA id 7B8691841770; Mon, 23 Jul 2018 17:03:48 +0200 (CEST) Subject: [PATCH v2 1/5] HID: hid-betopff.c: Refactor code to fix error handling (1/3) From: Hanno Zulla To: huangbobupt@163.com Cc: Jiri Kosina , Benjamin Tissoires , linux-input References: <84e73143-a5da-9e8d-4ec8-ce425e1b4699@hanno.de> Message-ID: <3865de51-b659-c24f-6394-6934f004dccd@hanno.de> Date: Mon, 23 Jul 2018 17:03:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <84e73143-a5da-9e8d-4ec8-ce425e1b4699@hanno.de> Content-Language: de-LU Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP HID: hid-betopff.c: Refactor code to fix error handling (1/3) The driver's betopff_probe() calls betopff_init(), but then doesn't handle the returned errors. This is a minor refactoring to fold both functions into one and bring back error handling. Signed-off-by: Hanno Zulla --- drivers/hid/hid-betopff.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-betopff.c b/drivers/hid/hid-betopff.c index 69cfc8dc6af1..5b4c9e9d26ae 100644 --- a/drivers/hid/hid-betopff.c +++ b/drivers/hid/hid-betopff.c @@ -59,15 +59,13 @@ static int betopff_init(struct hid_device *hid) { struct betopff_device *betopff; struct hid_report *report; - struct hid_input *hidinput = - list_first_entry(&hid->inputs, struct hid_input, list); - struct list_head *report_list = - &hid->report_enum[HID_OUTPUT_REPORT].report_list; - struct input_dev *dev = hidinput->input; + struct hid_input *hidinput; + struct list_head *report_list; int field_count = 0; int error; int i, j; + report_list = &hid->report_enum[HID_OUTPUT_REPORT].report_list; if (list_empty(report_list)) { hid_err(hid, "no output reports found\n"); return -ENODEV; @@ -99,9 +97,11 @@ static int betopff_init(struct hid_device *hid) if (!betopff) return -ENOMEM; - set_bit(FF_RUMBLE, dev->ffbit); + hidinput = list_first_entry(&hid->inputs, struct hid_input, list); + set_bit(FF_RUMBLE, hidinput->input->ffbit); - error = input_ff_create_memless(dev, betopff, hid_betopff_play); + error = input_ff_create_memless(hidinput->input, + betopff, hid_betopff_play); if (error) { kfree(betopff); return error;