From patchwork Fri May 19 18:46:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pascal Wichmann X-Patchwork-Id: 9737955 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 32394601A1 for ; Fri, 19 May 2017 18:52:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3621E28434 for ; Fri, 19 May 2017 18:52:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2AC3C28576; Fri, 19 May 2017 18:52:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 87DC728434 for ; Fri, 19 May 2017 18:52:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755342AbdESSw1 (ORCPT ); Fri, 19 May 2017 14:52:27 -0400 Received: from web02.pwsrv.de ([188.68.38.65]:49812 "EHLO web02.pwsrv.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753312AbdESSw0 (ORCPT ); Fri, 19 May 2017 14:52:26 -0400 X-Greylist: delayed 367 seconds by postgrey-1.27 at vger.kernel.org; Fri, 19 May 2017 14:52:25 EDT From: Pascal Wichmann DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pa-w.de; s=201701; t=1495219577; bh=YgSEVoxA9POK0p1XRsjTWxdliqJK2ylss33IYc+aNsM=; h=From:Subject:To:Cc:Date; b=J2d6OVGqGnF8xH/okw4NJhCOt1ySDZBxqdfJgtf4GBknpRC6xGXPX3kA+h/gGbvUW 5duY5cJsQj3BFJbg6J5efbVw/97sVrj99Vj4/dyKxMpn5GxdjaEAT1rF/oBZ8trbL9 jYwr3w7eWf4U/ShmatYQNkmNGY5Sv1s+aH9i9rgm06JpkWbl7AGNni9+eDuSl3sz22 UPjPx5vBM/tohO5KCzJapEAIvRzVML8UnRBUXz+VJzdCdPM+cpL+70qyR2Am0igG5R xWi38nPKnkCeuFfMlP4eNrO/L7Hp3kTr8CwHxxOKn8uCDScAX3mEREwLYCWuP95dsa mL7JjP5OMM+ww== Subject: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not recognized anymore; commit e839ffa: "Input: synaptics - add support for Intertouch devices" To: Dmitry Torokhov , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <41de7f92-8d98-3266-5d28-28ba48c5da38@pa-w.de> Date: Fri, 19 May 2017 20:46:16 +0200 User-Agent: null MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, using the latest 4.12-rc1 kernel, the trackpoint and touchpad of my Thinkpad X250 are not recognized. This is caused by commit e839ffa Input: synaptics - add support for Intertouch devices The specific problem seems to be the detection of whether to use synaptics_intertouch for the psmouse module or not. That parameter is set to -1 by default, in which case synaptics_intertouch is enabled on my device. When I explicitly set that parameter to 0, the trackpoint and touchpad are recognized and work as expected. Removing my device from smbus_pnp_ids in 4.12 rc1 fixes the issue without need to manually disable synaptics_intertouch in the psmouse module: Is the ThinkPad X250 not supporting intertouch or is there another problem causing the input devices not to work with it enabled? Regards, Pascal diff -ruN a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c --- a/drivers/input/mouse/synaptics.c 2017-05-19 19:31:48.930734395 +0200 +++ b/drivers/input/mouse/synaptics.c 2017-05-19 19:32:00.490782484 +0200 @@ -170,7 +170,6 @@ static const char * const smbus_pnp_ids[] = { /* all of the topbuttonpad_pnp_ids are valid, we just add some extras */ "LEN0048", /* X1 Carbon 3 */ - "LEN0046", /* X250 */ "LEN004a", /* W541 */ "LEN200f", /* T450s */ NULL