From patchwork Mon Oct 31 16:02:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Twiss X-Patchwork-Id: 9405831 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D42EB60588 for ; Mon, 31 Oct 2016 16:16:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BFF0D291E3 for ; Mon, 31 Oct 2016 16:16:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B4E532933A; Mon, 31 Oct 2016 16:16:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 46515291E3 for ; Mon, 31 Oct 2016 16:16:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759488AbcJaQPr (ORCPT ); Mon, 31 Oct 2016 12:15:47 -0400 Received: from mail1.bemta5.messagelabs.com ([195.245.231.142]:58226 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757260AbcJaQPl (ORCPT ); Mon, 31 Oct 2016 12:15:41 -0400 Received: from [85.158.139.35] by server-6.bemta-5.messagelabs.com id 21/55-14841-82E67185; Mon, 31 Oct 2016 16:15:36 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAKsWRWlGSWpSXmKPExsUSt3Opsa56nni EQfNbTYupD5+wWcw/co7V4vCiF4wW869cY7W4//Uoo8W3Kx1MFjc/fWO1uLxrDpvF594jjBY3 1u1jt3iy8AyTxdLrF5ksWvceAXIf9rFZXJ7YyW5xa8YLVgcBjzXz1jB67Jx1l93j2mYxj8V7X jJ5bFrVyeZx59oeNo+d3xvYPT5vkgvgiGLNzEvKr0hgzfg8ZxFrwROViq6O64wNjC/kuhi5OI QE1jNKLLx8h62LkRPIqZC4NamVuYuRg4NXIFli8SExEJNTwFHiS5cLRIWDxM6LV8Cq2QQMJea 9ec8IYrMIqErcn9LGDmILC8RIdDTPZgMZLyLwi1Hi5LK1TCAOs0Ans8TaA1vBunkFBCVOznzC AmIzC0hIHHzxAmyvkICWxPJjkSBhCQF7ienvr4KFJQT0JRqPxUKEDSW+z/rGAmGbSzQs6mScw Cg4C8nQWUiGLmBkWsWoUZxaVJZapGtkpJdUlJmeUZKbmJmja2hgqpebWlycmJ6ak5hUrJecn7 uJERhz9QwMjDsY97T7HWKU5GBSEuX9GiYeIcSXlJ9SmZFYnBFfVJqTWnyIUYaDQ0mCd3cOUE6 wKDU9tSItMwcY/TBpCQ4eJRHeqlygNG9xQWJucWY6ROoUo6KUOO9hkD4BkERGaR5cGyzhXGKU lRLmZWRgYBDiKUgtys0sQZV/xSjOwagkzNsHMoUnM68EbvoroMVMQIvTCkVAFpckIqSkGhiTN 3sKHmsJOOFzrOgq/wUfQ31z+/hfOsofOG61s3afbXrwztDlubrD9BBThijdSSsVi26+DPRJ12 J441scwi14JkLn1EUOl8sHd20JfyC/eNH+O3/mXz7x8Ou3pxxLLScw2ppPfZGcKPR574rbGXF +9l8qRaZYmU9b8qgn691kkaZf/hGzZVKUWIozEg21mIuKEwG+A5W6MwMAAA== X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-6.tower-179.messagelabs.com!1477930534!63574082!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 9.0.13; banners=-,-,- X-VirusChecked: Checked Received: (qmail 22461 invoked from network); 31 Oct 2016 16:15:35 -0000 Received: from mailrelay2.diasemi.com (HELO sw-ex-cashub01.diasemi.com) (94.185.165.51) by server-6.tower-179.messagelabs.com with AES128-SHA encrypted SMTP; 31 Oct 2016 16:15:35 -0000 Received: from swsrvapps-01.diasemi.com (10.20.28.141) by SW-EX-CASHUB01.diasemi.com (10.20.16.140) with Microsoft SMTP Server id 14.3.248.2; Mon, 31 Oct 2016 16:15:33 +0000 Received: by swsrvapps-01.diasemi.com (Postfix, from userid 22547) id 3D05A3FB5C; Mon, 31 Oct 2016 16:15:33 +0000 (GMT) Message-ID: <48abf6ce51f8ef02421ea2dd4f4e309b440efc85.1477929725.git.stwiss.opensource@diasemi.com> In-Reply-To: References: From: Steve Twiss Date: Mon, 31 Oct 2016 16:02:02 +0000 Subject: [PATCH V3 1/9] Documentation: devicetree: input: additions for da9061 onkey driver To: DEVICETREE , Dmitry Torokhov , LINUX-INPUT , LINUX-KERNEL , Mark Rutland , Rob Herring CC: Eduardo Valentin , Guenter Roeck , LINUX-PM , LINUX-WATCHDOG , Lee Jones , Liam Girdwood , Mark Brown , Support Opensource , Wim Van Sebroeck , Zhang Rui MIME-Version: 1.0 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-ServerInfo: sw-ex-cashub01.diasemi.com, 9 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 31/10/2016 13:14:00 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Steve Twiss Add binding information for DA9061 onkey. This patch updates the compatible string "dlg,da9061-onkey" to support DA9061, removes the reference to KEY_SLEEP (which the driver no longer supports) and fixes a typo in the example for DA9063. Supporting KEY_SLEEP was not the general convention and the typical solution should have been for KEY_POWER to support both cases of suspend and S/W power off. This change was sent to the DA9063 ONKEY device driver in a separate patch, but the documentation was not updated at that time. - f889bea Report KEY_POWER instead of KEY_SLEEP during power key-press This patch also adds two new examples, one for DA9062 and one for DA9061. The DA9061 examples uses a fall-back compatible string for the DA9062 onkey driver. Signed-off-by: Steve Twiss Acked-by: Rob Herring --- This patch applies against linux-next and v4.8 v2 -> v3 - Patch renamed from [PATCH V2 01/10] to [PATCH V3 1/9] - Each compatible line should be a valid combination of compatible strings, alter DA9061 line to include the fall back compatible string - Update the commit message to include KEY_SLEEP removal explanation and a link back to the original device driver commit. This will allow full traceability back to the original patch change - Link in information about associated patches from this set without describing them as being explicitly dependent on this binding v1 -> v2 - Patch renamed from [PATCH V1 06/10] to [PATCH V2 01/10] -- these changes were made to fix checkpatch warnings caused by the patch set dependency order - Typo s/ther/the/ in commit message - Explanation about why KEY_SLEEP was removed (see below) - Addition of DA9062 example - Addition of a DA9061 example to follow the driver fall-back compatible convention being applied for this device driver Hi, There is also new binding examples for DA9062 and DA9061. Importantly, the Linux device driver changes for DA9061 were rejected because the DA9062 device driver can be reused. For this reason, the DA9061 example uses a fall-back compatible string. Other information: The device driver from this patch set (associated with this binding) was applied by Dmitry Torokhov on 26-Oct-2016. See: - [PATCH V2 07/10] Input: da9061: onkey driver. - https://lkml.org/lkml/2016/10/26/1169 Regards, Steve Twiss, Dialog Semiconductor Ltd. .../devicetree/bindings/input/da9062-onkey.txt | 45 ++++++++++++++-------- 1 file changed, 30 insertions(+), 15 deletions(-) diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt b/Documentation/devicetree/bindings/input/da9062-onkey.txt index ab0e048..5f9fbc6 100644 --- a/Documentation/devicetree/bindings/input/da9062-onkey.txt +++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt @@ -1,32 +1,47 @@ -* Dialog DA9062/63 OnKey Module +* Dialog DA9061/62/63 OnKey Module -This module is part of the DA9062/DA9063. For more details about entire -chips see Documentation/devicetree/bindings/mfd/da9062.txt and -Documentation/devicetree/bindings/mfd/da9063.txt +This module is part of the DA9061/DA9062/DA9063. For more details about entire +DA9062 and DA9061 chips see Documentation/devicetree/bindings/mfd/da9062.txt +For DA9063 see Documentation/devicetree/bindings/mfd/da9063.txt -This module provides KEY_POWER, KEY_SLEEP and events. +This module provides the KEY_POWER event. Required properties: -- compatible: should be one of: - dlg,da9062-onkey - dlg,da9063-onkey +- compatible: should be one of the following valid compatible string lines: + "dlg,da9061-onkey", "dlg,da9062-onkey" + "dlg,da9062-onkey" + "dlg,da9063-onkey" Optional properties: - - dlg,disable-key-power : Disable power-down using a long key-press. If this +- dlg,disable-key-power : Disable power-down using a long key-press. If this entry exists the OnKey driver will remove support for the KEY_POWER key - press. If this entry does not exist then by default the key-press - triggered power down is enabled and the OnKey will support both KEY_POWER - and KEY_SLEEP. + press when triggered using a long press of the OnKey. -Example: - - pmic0: da9062@58 { +Example: DA9063 + pmic0: da9063@58 { onkey { compatible = "dlg,da9063-onkey"; dlg,disable-key-power; }; + }; + +Example: DA9062 + + pmic0: da9062@58 { + onkey { + compatible = "dlg,da9062-onkey"; + dlg,disable-key-power; + }; + }; + +Example: DA9061 using a fall-back compatible for the DA9062 onkey driver + pmic0: da9061@58 { + onkey { + compatible = "dlg,da9061-onkey", "dlg,da9062-onkey"; + dlg,disable-key-power; + }; };