From patchwork Wed Aug 25 18:10:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Auty X-Patchwork-Id: 132641 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o7PIARYW018650 for ; Wed, 25 Aug 2010 18:10:27 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751812Ab0HYSKJ (ORCPT ); Wed, 25 Aug 2010 14:10:09 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:35544 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751776Ab0HYSKJ (ORCPT ); Wed, 25 Aug 2010 14:10:09 -0400 Received: from [192.168.188.1] (82-71-33-97.dsl.in-addr.zen.co.uk [82.71.33.97]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPSA id C2AFC1B4073 for ; Wed, 25 Aug 2010 18:10:05 +0000 (UTC) Message-ID: <4C755C78.4000801@gentoo.org> Date: Wed, 25 Aug 2010 19:10:00 +0100 From: Mike Auty User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.8) Gecko/20100811 Lightning/1.0b2pre Thunderbird/3.1.2 MIME-Version: 1.0 To: linux-input@vger.kernel.org Subject: [PATCH 2.6.35.3] wacom: Fix mousewheel up/down regression for old wacom tablets X-Enigmail-Version: 1.1.2 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Wed, 25 Aug 2010 18:10:28 +0000 (UTC) diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c index 415f630..d1a883d 100644 --- a/drivers/input/tablet/wacom_wac.c +++ b/drivers/input/tablet/wacom_wac.c @@ -210,10 +210,10 @@ static int wacom_graphire_irq(struct wacom_wac *wacom) if (features->type == WACOM_G4 || features->type == WACOM_MO) { input_report_abs(input, ABS_DISTANCE, data[6] & 0x3f); - rw = (signed)(data[7] & 0x04) - (data[7] & 0x03); + rw = (data[7] & 0x04) - (data[7] & 0x03); } else { input_report_abs(input, ABS_DISTANCE, data[7] & 0x3f); - rw = -(signed)data[6]; + rw = -(signed char)data[6]; } input_report_rel(input, REL_WHEEL, rw); }