From patchwork Thu Aug 18 06:34:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wanlong Gao X-Patchwork-Id: 1075682 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p7I6adJX006819 for ; Thu, 18 Aug 2011 06:36:39 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366Ab1HRGgh (ORCPT ); Thu, 18 Aug 2011 02:36:37 -0400 Received: from hera.kernel.org ([140.211.167.34]:56490 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762Ab1HRGgg (ORCPT ); Thu, 18 Aug 2011 02:36:36 -0400 Received: from song.cn.fujitsu.com (cn.fujitsu.com [222.73.24.84] (may be forged)) by hera.kernel.org (8.14.4/8.14.3) with ESMTP id p7I6aXAO032246; Thu, 18 Aug 2011 06:36:34 GMT X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.97.2 at hera.kernel.org Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id 3967E170126; Thu, 18 Aug 2011 14:35:56 +0800 (CST) Received: from mailserver.fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id p7I6Zrmx005253; Thu, 18 Aug 2011 14:35:54 +0800 Received: from [10.167.225.68] ([10.167.225.68]) by mailserver.fnst.cn.fujitsu.com (Lotus Domino Release 8.5.1FP4) with ESMTP id 2011081814344475-43740 ; Thu, 18 Aug 2011 14:34:44 +0800 Message-ID: <4E4CB291.5010102@cn.fujitsu.com> Date: Thu, 18 Aug 2011 14:34:57 +0800 From: Wanlong Gao Reply-To: gaowanlong@cn.fujitsu.com Organization: FNST User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110322 Red Hat/3.1.9-3.el6_0 Thunderbird/3.1.9 MIME-Version: 1.0 To: JJ Ding CC: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Seth Forshee , Dmitry Torokhov , Aaron Huang , Tom Lin , Eric Piel , Daniel Kurtz , Chase Douglas , Henrik Rydberg , Alessandro Rubini Subject: Re: [PATCH 5/6] Input: elantech - clean up elantech_init References: <1313632629-23603-1-git-send-email-jj_ding@emc.com.tw> <1313632629-23603-6-git-send-email-jj_ding@emc.com.tw> In-Reply-To: <1313632629-23603-6-git-send-email-jj_ding@emc.com.tw> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-08-18 14:34:44, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-08-18 14:34:46, Serialize complete at 2011-08-18 14:34:46 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on hera.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 18 Aug 2011 06:36:39 +0000 (UTC) X-Greylist: Delayed for 45:47:14 by milter-greylist-4.2.6 (hera.kernel.org [140.211.167.34]); Thu, 18 Aug 2011 06:36:35 +0000 (UTC) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 08/18/2011 09:57 AM, JJ Ding wrote: > if (elantech_set_absolute_mode(psmouse)) { > pr_err("failed to put touchpad into absolute mode.\n"); > goto init_fail; Hi JJ, --- -- also has space before *init_fail*, you may do this in your next version. Thanks -Wanlong Gao -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index e13a719..675c236 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c @@ -1069,7 +1069,7 @@ int elantech_init(struct psmouse *psmouse) return 0; - init_fail: +init_fail: kfree(etd); return -1; }