From patchwork Wed Sep 18 12:35:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Moiseev X-Patchwork-Id: 2906351 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4AE779F1E3 for ; Wed, 18 Sep 2013 12:36:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 96AFB2017A for ; Wed, 18 Sep 2013 12:36:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D621A200ED for ; Wed, 18 Sep 2013 12:36:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752136Ab3IRMgD (ORCPT ); Wed, 18 Sep 2013 08:36:03 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:51934 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027Ab3IRMgB (ORCPT ); Wed, 18 Sep 2013 08:36:01 -0400 Received: by mail-lb0-f180.google.com with SMTP id q8so6489987lbi.39 for ; Wed, 18 Sep 2013 05:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; bh=jNIgZOm3Bkwb2MfwN/bjEyrKeWw1mH/IYzv6SwtR3Sw=; b=J/cBj7z2SSoNMHG1d2gvo3OLPztqXjGfspAkYF2gzEM0qUg+Hq7dgwLkZj9qVp8vui /t8ai9VhCxgGIGrpMCg8EixJ5hbXA7esHOb2TOwzhUelbG8Rbb6UTnHYu7TYQ+3X/NYQ PKz0vxBKhJn6+D1L0Igt/Fq5puBXCR+Wq3unp6LhDTnFhIbuf6vDHk35xrAP5dfEL4kK scfkO7HzEhgX0xTcTNKCWtEe6iHzSAxSslGzsrbVgX415VZmn6f5i14Yx1Yq99kfESah mh3hUIPUpe/s2WodLO+/GhDWVn6oCojoPniLsNPYsEW6Y8Aes1XX5orEZ5+WUiG9spnd 5a/A== X-Received: by 10.152.120.37 with SMTP id kz5mr16294554lab.21.1379507758987; Wed, 18 Sep 2013 05:35:58 -0700 (PDT) Received: from [192.168.1.50] (95-28-39-132.broadband.corbina.ru. [95.28.39.132]) by mx.google.com with ESMTPSA id oc1sm1416625lbb.3.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 18 Sep 2013 05:35:58 -0700 (PDT) Message-ID: <52399E2C.7000805@gmail.com> Date: Wed, 18 Sep 2013 16:35:56 +0400 From: Andrey Moiseev User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130806 Thunderbird/17.0.8 MIME-Version: 1.0 To: dmitry.torokhov@gmail.com CC: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andrey Moiseev Subject: [PATCH] Input: i8042 - i8042_flush fix for a full 8042 buffer Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When 8042 internal data buffer is full, the driver erroneously decides that the controller is not present. I've already sent this 2 weeks ago, but that message received no comments. i8042_flush returns the number of flushed bytes, which is in 0 - I8042_BUFFER_SIZE range inclusive. Therefore, i8042_flush has no way to indicate an error. Moreover i8042_controller_check takes initially full buffer (i8042_flush returned I8042_BUFFER_SIZE) as a sign of absence of the controller. The fix: i8042_flush should perform one more status check after I8042_BUFFER_SIZE bytes have been read, and, if it succeeds, indicate the error by returning -1. i8042_controller_check should be changed appropriately. Signed-off-by: Andrey Moiseev diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index 78e4de4..cdda786 100644 --- a/drivers/input/serio/i8042.c +++ b/drivers/input/serio/i8042.c @@ -222,29 +222,32 @@ static int i8042_wait_write(void) static int i8042_flush(void) { unsigned long flags; unsigned char data, str; int i = 0; spin_lock_irqsave(&i8042_lock, flags); - while (((str = i8042_read_status()) & I8042_STR_OBF) && (i < I8042_BUFFER_SIZE)) { + while (((str = i8042_read_status()) & I8042_STR_OBF) && (i <= I8042_BUFFER_SIZE)) { udelay(50); data = i8042_read_data(); i++; dbg("%02x <- i8042 (flush, %s)\n", data, str & I8042_STR_AUXDATA ? "aux" : "kbd"); } spin_unlock_irqrestore(&i8042_lock, flags); + if (i == I8042_BUFFER_SIZE + 1) + return -1; + return i; } /* * i8042_command() executes a command on the i8042. It also sends the input * parameter(s) of the commands to it, and receives the output value(s). The * parameters are to be stored in the param array, and the output is placed * into the same array. The number of the parameters and output values is * encoded in bits 8-11 of the command number. */ @@ -849,11 +852,11 @@ static int __init i8042_check_aux(void) static int i8042_controller_check(void) { - if (i8042_flush() == I8042_BUFFER_SIZE) { + if (i8042_flush() == -1) { pr_err("No controller found\n"); return -ENODEV; } return 0; }