From patchwork Thu Oct 15 19:19:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Rojtberg X-Patchwork-Id: 7408961 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D50599F302 for ; Thu, 15 Oct 2015 19:19:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6CB3120727 for ; Thu, 15 Oct 2015 19:19:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD35220734 for ; Thu, 15 Oct 2015 19:19:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751674AbbJOTTj (ORCPT ); Thu, 15 Oct 2015 15:19:39 -0400 Received: from mail-lf0-f53.google.com ([209.85.215.53]:34114 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478AbbJOTTi (ORCPT ); Thu, 15 Oct 2015 15:19:38 -0400 Received: by lfaz124 with SMTP id z124so43610700lfa.1 for ; Thu, 15 Oct 2015 12:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=7uMCKOBOTNiZKP07XJp0qhmpcvTPf52D8rcqoAk1GOU=; b=Szq4ciGCl5R/DYnYQJ6JITuQgl3B/yD/SC7fBklLSgAlHPr5UGDAJZ83qHT1sfwMEx NIDj2IQ6jPg+LOk4pT9+VSbaQzff5reAMoTz0jdOoHv+MD4TlFhjSp9PJ0xSP8s1S4cK 9om6gY1o1wO5H3c48/ZuZ1CG2zyqTJKl9c9MvtApymg1fk4F4GsdbtE4a0yuXFOj9xsR tj+aLlR+GsZRPxaNDayeYishuPho5XKYbOhJ7gLqzdhfMSfa1wApkguyKclJn0yY/4Fp d19gXIBsGk0eBcrSxNnn2wrV51ypHaRF31cFwjHg3L6i3ZWvxWhnWsqgGyWo4oO9cnut H/cA== X-Received: by 10.180.79.34 with SMTP id g2mr486361wix.28.1444936776244; Thu, 15 Oct 2015 12:19:36 -0700 (PDT) Received: from [192.168.178.29] (p5DDCE94A.dip0.t-ipconnect.de. [93.220.233.74]) by smtp.googlemail.com with ESMTPSA id e6sm313647wiy.3.2015.10.15.12.19.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Oct 2015 12:19:35 -0700 (PDT) Subject: Re: [PATCH 07/15] Input: xpad: move the input device creation to a new function To: Dmitry Torokhov References: <1443733046-29610-1-git-send-email-rojtberg@gmail.com> <1443733046-29610-8-git-send-email-rojtberg@gmail.com> <20151010180015.GI39573@dtor-ws> Cc: linux-input@vger.kernel.org, pgriffais@valvesoftware.com, gregkh@linuxfoundation.org From: Pavel Rojtberg Message-ID: <561FFC47.3060802@gmail.com> Date: Thu, 15 Oct 2015 21:19:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151010180015.GI39573@dtor-ws> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hey Dimitry, I have seen you have also applied "[PATCH 08/15] Input: xpad: query Wireless controller state at init". However this change is unfortunately incomplete without "[PATCH 09/15] Input: xpad: handle "present" and "gone" correctly". As is both the presence as well as the LED packets are sent immediately at init which triggers the the "URB xxxx submitted while active" Warning and causes any initialization to fail. Attached is a fixup against current input/ next of the chunk that is in [PATCH 09/15], but should have been in [PATCH 08/15]. Sorry for the inconvenience. do not call xpad_identify_controller at init: it conflicts with the already sent presence packet and will be called by xpad360w_process_packet as needed anyway. Signed-off-by: Pavel Rojtberg --- drivers/input/joystick/xpad.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index d382d48..acb8859 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -1001,8 +1001,6 @@ static int xpad_led_probe(struct usb_xpad *xpad) if (error) goto err_free_id; - /* Light up the segment corresponding to controller number */ - xpad_identify_controller(xpad); return 0; err_free_id: