From patchwork Fri Jan 6 18:06:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cameron Gutman X-Patchwork-Id: 9501555 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 54B076021C for ; Fri, 6 Jan 2017 18:07:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4783B28496 for ; Fri, 6 Jan 2017 18:07:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3A84628518; Fri, 6 Jan 2017 18:07:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,T_DKIM_INVALID autolearn=no version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5AB9728517 for ; Fri, 6 Jan 2017 18:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755107AbdAFSGo (ORCPT ); Fri, 6 Jan 2017 13:06:44 -0500 Received: from mail-oi0-f66.google.com ([209.85.218.66]:34147 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753609AbdAFSGn (ORCPT ); Fri, 6 Jan 2017 13:06:43 -0500 Received: by mail-oi0-f66.google.com with SMTP id 3so55559640oih.1 for ; Fri, 06 Jan 2017 10:06:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :cc:to; bh=/FzQ7l57DCNaczBxzq/uwYkFQvczpkTPCPxwN8ogISM=; b=HTSezuqdrvEyBuMqdHQfjdfQI8YU5/m8HFEKbwVpZnWDsqvWFmSRI00fvdt1Yhi3BR HtTWaVN184JKBKaEC64X0zgjzikTQODwvFie+rOQI8Qo16UrJeRyRF4AtvKxhS7VApUN ZM1dnpQMGnyZm3s7YbhQQpwAAWpzVhBvjZUIQJW/F6QxBbJ0JywdxhHCBGrhYRUJeN6A ogFadvmSTsspWZ4rnuvEYzVyotmFOTE7deSY7MUFq9dP8Ep/Cb35DiVAgd0tbZOQNHGZ G22em2fs+CWT6HoFeKb2VVEvfD0/833S4rMw/B3FAFqHjkwHutbchRH3nl9TlIYpJ8G2 vj/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:cc:to; bh=/FzQ7l57DCNaczBxzq/uwYkFQvczpkTPCPxwN8ogISM=; b=Mg7zYTYWFOPY9gB3Ogza3nFi+PXOLjRbi3Nr3pUpNlf42pPkTEnoTJQrLJFfV8jXfv JB4yzsTui5eMwLNLgUro7fiALlGzvaruNqcX1oDEwoUuie5+yWgLcnhanE9ii0yyC320 c1kVVL3xzD7CaMa3muzphVfUrVW3+uzIBuxxaXRuV5S8j+Zc1KmIRxwNt2f5R46+j4dH 1N6Wt0x8nI4eQK3WwoQalSAm3g6eIG1KmNHrQidGux3my76iToYh321KxvlZpi10Q0mk OkApI93oNEYlkUksaFbVHhSumDOx9X1jXFS9H/nFpO0V19VhXwwccMhHj0tQh67Q7zoN 8pvg== X-Gm-Message-State: AIkVDXKx3oOCUUYRfvIgAxLh8rVDHx9hSATiKpkeZ4VWscGe6cKVsh/a6Tl+I2oZnJHFEA== X-Received: by 10.202.88.138 with SMTP id m132mr40858939oib.12.1483726002625; Fri, 06 Jan 2017 10:06:42 -0800 (PST) Received: from ?IPv6:2601:2c6:c100:a167:f4df:eba7:ed01:d258? ([2601:2c6:c100:a167:f4df:eba7:ed01:d258]) by smtp.gmail.com with ESMTPSA id b64sm2550443oih.3.2017.01.06.10.06.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jan 2017 10:06:42 -0800 (PST) From: Cameron Gutman Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Bug in recent pad patch (96eb371b816c) Message-Id: <69517E60-A1A3-4B2E-ABE3-B268CB5371E5@gmail.com> Date: Fri, 6 Jan 2017 12:06:39 -0600 Cc: linux-input , Pavel Rojtberg To: Dmitry Torokhov , dan.g.tob@gmail.com X-Mailer: Apple Mail (2.3259) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It looks like the recent commit in master 96eb371b816c ("Input: xpad - correctly sort vendor id's") adds a duplicate entry for XPAD_XBOXONE_VENDOR(0x24c6). You may want to amend that with the following: --- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index ceb6a58..c06b717 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -325,7 +325,6 @@ static struct usb_device_id xpad_table[] = { XPAD_XBOX360_VENDOR(0x12ab), /* X-Box 360 dance pads */ XPAD_XBOX360_VENDOR(0x1430), /* RedOctane X-Box 360 controllers */ XPAD_XBOX360_VENDOR(0x146b), /* BigBen Interactive Controllers */ - XPAD_XBOXONE_VENDOR(0x24c6), /* PowerA Controllers */ XPAD_XBOX360_VENDOR(0x1532), /* Razer Sabertooth */ XPAD_XBOX360_VENDOR(0x15e4), /* Numark X-Box 360 controllers */ XPAD_XBOX360_VENDOR(0x162e), /* Joytech X-Box 360 controllers */