| Message ID | 83fc8cbf4f5ef7b5e814353468b9ee9d5dd6d7d2.1471151622.git.bhaktipriya96@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Sun, Aug 14, 2016 at 10:53:07AM +0530, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue replaces the deprecated > create_singlethread_workqueue. > > There are multiple work items on the work queue viz > &priv->dev3_register_work, &priv->recalib_wq, &psmouse->resync_work, > which require execution ordering. Hence, an ordered workqueue has been > used. > > The workqueue is not being used on a memory reclaim path. > Hence, WQ_MEM_RECLAIM has not been set. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Acked-by: Tejun Heo <tj@kernel.org> Thanks.
On Mon, Aug 15, 2016 at 06:53:45PM -0400, Tejun Heo wrote: > On Sun, Aug 14, 2016 at 10:53:07AM +0530, Bhaktipriya Shridhar wrote: > > alloc_ordered_workqueue replaces the deprecated > > create_singlethread_workqueue. > > > > There are multiple work items on the work queue viz > > &priv->dev3_register_work, &priv->recalib_wq, &psmouse->resync_work, > > which require execution ordering. Hence, an ordered workqueue has been > > used. > > > > The workqueue is not being used on a memory reclaim path. > > Hence, WQ_MEM_RECLAIM has not been set. > > > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> > > Acked-by: Tejun Heo <tj@kernel.org> Applied, thank you.
diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c index 5784e20..fb4b185 100644 --- a/drivers/input/mouse/psmouse-base.c +++ b/drivers/input/mouse/psmouse-base.c @@ -1916,7 +1916,7 @@ static int __init psmouse_init(void) synaptics_module_init(); hgpk_module_init(); - kpsmoused_wq = create_singlethread_workqueue("kpsmoused"); + kpsmoused_wq = alloc_ordered_workqueue("kpsmoused", 0); if (!kpsmoused_wq) { pr_err("failed to create kpsmoused workqueue\n"); return -ENOMEM;
alloc_ordered_workqueue replaces the deprecated create_singlethread_workqueue. There are multiple work items on the work queue viz &priv->dev3_register_work, &priv->recalib_wq, &psmouse->resync_work, which require execution ordering. Hence, an ordered workqueue has been used. The workqueue is not being used on a memory reclaim path. Hence, WQ_MEM_RECLAIM has not been set. Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> --- drivers/input/mouse/psmouse-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html