diff mbox

[2/3] Input: bcm5974: Return directly after a failed kmalloc() in bcm5974_wellspring_mode()

Message ID 8befb181-9f0e-84f4-9080-4bde3d666a3b@users.sourceforge.net (mailing list archive)
State New, archived
Headers show

Commit Message

SF Markus Elfring Jan. 24, 2018, 8:31 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 24 Jan 2018 21:14:51 +0100

Return directly after a call of the function "kmalloc" failed
at the beginning.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/input/mouse/bcm5974.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox

Patch

diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
index 994805513df9..685f56c08931 100644
--- a/drivers/input/mouse/bcm5974.c
+++ b/drivers/input/mouse/bcm5974.c
@@ -669,10 +669,8 @@  static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on)
 		return 0;
 
 	data = kmalloc(c->um_size, GFP_KERNEL);
-	if (!data) {
-		retval = -ENOMEM;
-		goto out;
-	}
+	if (!data)
+		return -ENOMEM;
 
 	/* read configuration */
 	size = usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0),