From patchwork Thu Jun 9 11:26:58 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chih-Wei Huang X-Patchwork-Id: 864232 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p59BR0uG002279 for ; Thu, 9 Jun 2011 11:27:00 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756105Ab1FIL1A (ORCPT ); Thu, 9 Jun 2011 07:27:00 -0400 Received: from mail-gx0-f174.google.com ([209.85.161.174]:61267 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754674Ab1FIL07 (ORCPT ); Thu, 9 Jun 2011 07:26:59 -0400 Received: by gxk21 with SMTP id 21so704881gxk.19 for ; Thu, 09 Jun 2011 04:26:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.138.134 with SMTP id a6mr776872yhj.472.1307618818146; Thu, 09 Jun 2011 04:26:58 -0700 (PDT) Received: by 10.146.84.11 with HTTP; Thu, 9 Jun 2011 04:26:58 -0700 (PDT) X-Originating-IP: [111.67.52.146] In-Reply-To: <20110608153146.GG2465@nautilus.holoscopio.com> References: <20110602144146.GB3508@nautilus.holoscopio.com> <20110603124428.GA2379@nautilus.holoscopio.com> <20110608125758.GA2465@nautilus.holoscopio.com> <20110608153146.GG2465@nautilus.holoscopio.com> Date: Thu, 9 Jun 2011 19:26:58 +0800 Message-ID: Subject: Re: ET1602 Touchscreen doesn't work From: Chih-Wei Huang To: Thadeu Lima de Souza Cascardo Cc: Benjamin Tissoires , Jiri Kosina , linux-input@vger.kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 09 Jun 2011 11:27:01 +0000 (UTC) 2011/6/8 Thadeu Lima de Souza Cascardo : > I was referring to Benjamin's multi-touch solution, perhaps, reverting > the multi-device patch already. By the way, did you test it without the > multi-device patch and did it work, or did you test it only with 2.6.32? I'm not sure if I understood you correctly. I did these: * remove the quirk for touchpack in hid-quirks.c * change hid-multitouch.c as suggested by Benjamin. Test results: * The touchscreen is detected by hid-core. (only one device is detected) * Manually modprobe hid-multitouch, it didn't detect the touch device. * The android framework correctly recognized the touchscreen and it works well. The whole patch shows as below: - { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT }, +// { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT }, { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_UC100KM, HID_QUIRK_NOGET }, { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_CS124U, HID_QUIRK_NOGET }, diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 0c5e9c3..fab373a 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -713,6 +713,11 @@ static const struct hid_device_id mt_devices[] = { HID_USB_DEVICE(USB_VENDOR_ID_TOUCH_INTL, USB_DEVICE_ID_TOUCH_INTL_MULTI_TOUCH) }, + /* TouchPack touchscreen */ + { .driver_data = MT_CLS_DEFAULT, + HID_USB_DEVICE(USB_VENDOR_ID_TOUCHPACK, + USB_DEVICE_ID_TOUCHPACK_RTS) }, + /* Unitec panels */ { .driver_data = MT_CLS_DEFAULT, HID_USB_DEVICE(USB_VENDOR_ID_UNITEC, diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c index 9a94b64..727f363 100644 --- a/drivers/hid/usbhid/hid-quirks.c +++ b/drivers/hid/usbhid/hid-quirks.c @@ -49,7 +49,7 @@ static const struct hid_blacklist { { USB_VENDOR_ID_ETURBOTOUCH, USB_DEVICE_ID_ETURBOTOUCH, HID_QUIRK_MULTI_INPUT }, { USB_VENDOR_ID_PANTHERLORD, USB_DEVICE_ID_PANTHERLORD_TWIN_USB_JOYSTICK, HID_QUIRK_MULTI_INPUT | HID_QUIRK_SKIP_OUTPUT_REPORTS }, { USB_VENDOR_ID_PLAYDOTCOM, USB_DEVICE_ID_PLAYDOTCOM_EMS_USBII, HID_QUIRK_MULTI_INPUT },