From patchwork Mon Jun 23 19:08:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Nicoletti X-Patchwork-Id: 4404281 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7F239BEEAA for ; Mon, 23 Jun 2014 19:08:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E241D202C8 for ; Mon, 23 Jun 2014 19:08:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C7C7201DD for ; Mon, 23 Jun 2014 19:08:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754310AbaFWTI1 (ORCPT ); Mon, 23 Jun 2014 15:08:27 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:51804 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753952AbaFWTI0 (ORCPT ); Mon, 23 Jun 2014 15:08:26 -0400 Received: by mail-wg0-f52.google.com with SMTP id b13so6783736wgh.11 for ; Mon, 23 Jun 2014 12:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=cacqT0QtocTo5DccIF1JqbJ8m3qUW5QHdbCK5PR9y+M=; b=WSpFh44eZ/HzV9mNbVAlkuGy4QR3BoI9Z6wPhRgJ/tzl/DkMp6hpLY8qV78RqA+pSr v/qKEDHlO/0lR5WaDJ9lPY8WmD52MkMoGmBBQflBEnko/uQwMOfWW60JOAXNqAxHNDqf gC4EqecpMF7KD/9fTUAwherHBqopUIRuVEHOsQtXNtHz17hjzpaKxu53cHVhu3bgNYqB 7YE4YpbWKB3ueMcSQYZBfyVkH+wbJB1ID2NXdfSBSK191h02LjM8HmiKwG+bV+rlqWtC m7U9xhxmhl3fkd7efCVkmLpDoA+duA8INghvjvrmi9JXhDQ3EnfseZpBBJmLuugrnJkK Eo8w== MIME-Version: 1.0 X-Received: by 10.180.90.141 with SMTP id bw13mr28199384wib.23.1403550503760; Mon, 23 Jun 2014 12:08:23 -0700 (PDT) Received: by 10.216.108.202 with HTTP; Mon, 23 Jun 2014 12:08:23 -0700 (PDT) In-Reply-To: References: Date: Mon, 23 Jun 2014 16:08:23 -0300 Message-ID: Subject: Re: PATCH change for HID_BATTERY_STRENGTH kconfig From: Daniel Nicoletti To: Jiri Kosina Cc: linux-input@vger.kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 2013-05-23 19:16 GMT-03:00 Jiri Kosina : > On Mon, 13 May 2013, Daniel Nicoletti wrote: > >> Hi, >> I'd like to propose this patch while removes the need for >> hid to be compiled build-in, as this is the same behavior >> that WiiMote and Wacom have. >> Is this ok? > > Makes sense to me. Could you please resend with proper changelog and > Signed-off-by: line? > > Thanks. Sorry it took more than a year for me to do this, so I called git send-email, and so far the CC and linux-input didn't get it, tho it said result OK. git send-email --to "Jiri Kosina " --cc "linux-input@vger.kernel.org" 0001-HID-Allows-for-HID_BATTERY_STRENGTH-config-be-enable.patch I'm pasting it here hoping gmail doesn't screw it, if you prefer that I send it using the above command mind you telling what I did wrong? Thanks. From df740fd81dffbb74e13c622392fe9a945006fd3c Mon Sep 17 00:00:00 2001 From: Daniel Nicoletti Date: Mon, 23 Jun 2014 10:31:47 -0300 Subject: [PATCH] HID: Allows for HID_BATTERY_STRENGTH config be enabled without the need for HID module to be built-in. Signed-off-by: Daniel Nicoletti --- drivers/hid/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index fb52f3f..d6d85ad 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -27,7 +27,8 @@ if HID config HID_BATTERY_STRENGTH bool "Battery level reporting for HID devices" - depends on HID && POWER_SUPPLY && HID = POWER_SUPPLY + depends on HID + select POWER_SUPPLY default n ---help--- This option adds support of reporting battery strength (for HID devices