From patchwork Fri Feb 10 18:38:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Stein X-Patchwork-Id: 9567287 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5F320601EA for ; Fri, 10 Feb 2017 18:48:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4EA9B285B2 for ; Fri, 10 Feb 2017 18:48:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 42C3A285B6; Fri, 10 Feb 2017 18:48:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 563AC285B2 for ; Fri, 10 Feb 2017 18:48:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751847AbdBJSsd (ORCPT ); Fri, 10 Feb 2017 13:48:33 -0500 Received: from mail-io0-f195.google.com ([209.85.223.195]:36577 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbdBJSsc (ORCPT ); Fri, 10 Feb 2017 13:48:32 -0500 Received: by mail-io0-f195.google.com with SMTP id q20so6573440ioi.3 for ; Fri, 10 Feb 2017 10:47:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:reply-to:sender:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iaFWwhVPTRYwRSG9ABcit+pCJy2XuKUOgbzSjXGIzOA=; b=dnhBlcnZ+Ckb/e4tokwMMISSmFblaev9cew7a05Ai+8DSX8X56NnIsBr4J933qKIDu h/opnMrQKFihWg707sVFg4gEwu+6paMUhjGpDiSXGYzwwk3BQ355xiUN0yLUYnQUEUx1 7VrXYsscBV0WrOk5C4lbb+Ij+/uSyLKuYjDi1ygduaGgKKN57vVtabDZOjKOSa/qUjzb /Uzbilq0nyaIJKG7dEHQBMK5WkgsBOFTHg2UFXLkupkCHY4ljk3xki794/ZlPL6SKbll rfR4RIeAAa3ts/fbJVIFGrZh3RuVJcsiTF7Ta4ISIz5yIqxa3GMCpuVwFxo2BWO1JdM9 ISHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:sender:in-reply-to :references:from:date:message-id:subject:to:cc; bh=iaFWwhVPTRYwRSG9ABcit+pCJy2XuKUOgbzSjXGIzOA=; b=VXkWTot8KdOV81fCFkpFRwyaeCx0uOZBXx+r/u20mMEx4zEUWERlVtmbywBPVifMWH QWu378k2gLTUx7h2E2w8DRxaNtKqMdfQnu/it2dUr4/WczhLGMbLxMZwgchw4gztLtdY bVhqrxVSDnMnVRR5QPbgudjJP6OnU00vGpeBPWyK5xDtsHvJA0ZB2gYNOMIrqZuWhZZI UUnTjckqAFon1UjmfSnaDMm9ikZMicmWdH1Kvd/krzAoNRbwiGLUzcLY8LqyJE+70Kxk 5jnCDr1htItG9l6oa+YoFQt4eFc6L03EwAyWydGtvxzin0hFKQ+oXZv16JbfEeicoYtb ypMw== X-Gm-Message-State: AMke39k33xPnEwBa+TDkM5mIysgcweEXaI0SSPjXkkBkPQdMC/YtD87LVkWLiMwbIsEDcJQwEH5/rbl0jW2Jew== X-Received: by 10.107.169.202 with SMTP id f71mr9808025ioj.199.1486751939748; Fri, 10 Feb 2017 10:38:59 -0800 (PST) MIME-Version: 1.0 Reply-To: peter@stuntstein.dk Received: by 10.79.157.65 with HTTP; Fri, 10 Feb 2017 10:38:59 -0800 (PST) In-Reply-To: References: From: Peter Stein Date: Fri, 10 Feb 2017 10:38:59 -0800 X-Google-Sender-Auth: Nd9wxnJ_Qf4L_2m1gVYdBvH4vzQ Message-ID: Subject: Re: [PATCH] Fix for out of range for THT 2p arcade controller To: Jiri Kosina Cc: linux-input@vger.kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Jiri, I am so sorry that I screw it up. I forgot to activate plain text in gmail. I hope this time it is received in proper format. BTW, some of the files that I have changes in, the indent is tabs instead of spaces. Just so you know. There is a new clone of the XIN MO arcade controller which has the same issue with out of range like the original. This fix will solve the issue where 2 directions on the joystick are not recognized by the new THT 2P arcade controller with device ID 0x75e1. In details the new device ID is added the hid-id list and the hid-xinmo source code. Signed-off-by: Peter Stein commit c16f015221d72f4ab11515a9b8bf0d3d14fbfd76 Author: Peter Stein Date: Thu Feb 9 10:56:32 2017 -0800 Fix for out of range for THT 2P arcade controller. --- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 936960202cf4..24586876d43e 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2052,6 +2052,7 @@ static const struct hid_device_id hid_have_special_driver[] = { { HID_USB_DEVICE(USB_VENDOR_ID_WALTOP, USB_DEVICE_ID_WALTOP_SIRIUS_BATTERY_FREE_TABLET) }, { HID_USB_DEVICE(USB_VENDOR_ID_X_TENSIONS, USB_DEVICE_ID_SPEEDLINK_VAD_CEZANNE) }, { HID_USB_DEVICE(USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE) }, + { HID_USB_DEVICE(USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_THT_2P_ARCADE) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON, USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) }, diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index e37030624165..5e985046b255 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -1014,6 +1014,7 @@ #define USB_VENDOR_ID_XIN_MO 0x16c0 #define USB_DEVICE_ID_XIN_MO_DUAL_ARCADE 0x05e1 +#define USB_DEVICE_ID_THT_2P_ARCADE 0x75e1 #define USB_VENDOR_ID_XIROKU 0x1477 #define USB_DEVICE_ID_XIROKU_SPX 0x1006 diff --git a/drivers/hid/hid-xinmo.c b/drivers/hid/hid-xinmo.c index 7df5227a7e61..9ad7731d2e10 100644 --- a/drivers/hid/hid-xinmo.c +++ b/drivers/hid/hid-xinmo.c @@ -46,6 +46,7 @@ static int xinmo_event(struct hid_device *hdev, struct hid_field *field, static const struct hid_device_id xinmo_devices[] = { { HID_USB_DEVICE(USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_XIN_MO_DUAL_ARCADE) }, + { HID_USB_DEVICE(USB_VENDOR_ID_XIN_MO, USB_DEVICE_ID_THT_2P_ARCADE) }, { } };