From patchwork Fri Nov 9 17:04:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 1721391 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 583E8DF264 for ; Fri, 9 Nov 2012 17:04:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754783Ab2KIREh (ORCPT ); Fri, 9 Nov 2012 12:04:37 -0500 Received: from mail-oa0-f46.google.com ([209.85.219.46]:47677 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754678Ab2KIREg (ORCPT ); Fri, 9 Nov 2012 12:04:36 -0500 Received: by mail-oa0-f46.google.com with SMTP id h16so4247980oag.19 for ; Fri, 09 Nov 2012 09:04:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=M78qRY4+RF++gcwgcCOgLKf6yIYBkUs55ojDZ9Rc4Rs=; b=eGfPUqNjcLZCMh5JnJLNSJwJATlwZHvBDl7JYXBDimSy5mtLPFaDr7+k5J6P0mCmP3 QsL8HRXIwYuDeSHpHoSDxBYKttYqme92XXX2LnBBh8uZ7Zplc5omiiolMCdz7I8/qfgq MjbdIMUIPnYCS06Wc1D2Qh1tAkDuL+3FrUNbn55IpWmfLX+lLzESBCDbnPrifJnYwS8J uYzx1qiEqS10aUI+VdsYxtXH5va0yXGRX0f9x62IrpMHT/e25qeuaesAWMbPx1Li+7rs o2PY0MGMe8a+RNOUFwJfDZm4FOJDNGGxfe8NO4/z8OAdAchWxyCIm8r6lvWPdx9ky15v XiNA== MIME-Version: 1.0 Received: by 10.60.154.231 with SMTP id vr7mr8222858oeb.119.1352480675667; Fri, 09 Nov 2012 09:04:35 -0800 (PST) Received: by 10.76.98.102 with HTTP; Fri, 9 Nov 2012 09:04:35 -0800 (PST) In-Reply-To: <52b9fe53a8bd8dff7105209c5b1fab9da7a1510d.1352474824.git.viresh.kumar@linaro.org> References: <3d6f34ca5960203a5efb761f4d56b4e10ee24827.1352474824.git.viresh.kumar@linaro.org> <52b9fe53a8bd8dff7105209c5b1fab9da7a1510d.1352474824.git.viresh.kumar@linaro.org> Date: Fri, 9 Nov 2012 22:34:35 +0530 Message-ID: Subject: Re: [PATCH 2/3] input: stmpe-ts: Use devm_*() routines From: Viresh Kumar To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com, Viresh Kumar X-Gm-Message-State: ALoCoQlIG3EUw4WrPpTkvwl833pRw0qi6LUSlB8f5JuCwF+keqaiFQ2ucIqtFyYpRlpglnKAF8a7 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 9 November 2012 20:57, Viresh Kumar wrote: > This patch frees stmpe-ts driver from tension of freeing resources :) > devm_* derivatives of multiple routines are used while allocating resources, > which would be freed automatically by kernel. > > Signed-off-by: Viresh Kumar Fixup: commit dda6d45808d65aaf8b0d4153e7a418b255365818 Author: Viresh Kumar Date: Fri Nov 9 22:28:26 2012 +0530 fixup! input: stmpe-ts: Use devm_*() routines --- drivers/input/touchscreen/stmpe-ts.c | 2 -- 1 file changed, 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c index 9896095..f2cb15d 100644 --- a/drivers/input/touchscreen/stmpe-ts.c +++ b/drivers/input/touchscreen/stmpe-ts.c @@ -344,8 +344,6 @@ static int __devexit stmpe_ts_remove(struct platform_device *pdev) stmpe_disable(ts->stmpe, STMPE_BLOCK_TOUCHSCREEN); - input_unregister_device(ts->idev); - return 0; }