From patchwork Wed Jul 17 05:31:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2828454 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 104AB9F9F9 for ; Wed, 17 Jul 2013 05:31:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7F9DD20190 for ; Wed, 17 Jul 2013 05:31:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D21B2018D for ; Wed, 17 Jul 2013 05:31:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751831Ab3GQFbI (ORCPT ); Wed, 17 Jul 2013 01:31:08 -0400 Received: from mail-bk0-f47.google.com ([209.85.214.47]:57173 "EHLO mail-bk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783Ab3GQFbH (ORCPT ); Wed, 17 Jul 2013 01:31:07 -0400 Received: by mail-bk0-f47.google.com with SMTP id jg1so549797bkc.6 for ; Tue, 16 Jul 2013 22:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=wbFH/+HQDr2GddhkURejQjNq2PmDOz9WEG0c6u7ocaw=; b=nZ1Vd19dxEaNwDsQltBw6+KHfTZs47Z5B4ceefOHFMEYSwSmy/KqBA5eFcktap4PVU Oj2wU8NOtblU2qli+K7MroKgffSkAYrZF+DaLFvGZ4VhGgWBl+DeFm+iQMhqK8akhGs/ uh/pqggAwfhkomf/ngNjciqdgf1y2c60MP6v3JbJwNAVb9czBSpanWCbd1rEa3djDrXw RTuQAiHmnUqEqCzm+aLPxozHtC/bicegJMGNZ/zTuNm2CKAtcjKO/9l8J12Eo/KxrjyV hqTMGinns9juMd/v2nStFqIRp6uZ5/eLo1Ye34z1DfHo3Xa7JLcOViPxqwoPQViL0tqn ZiLg== MIME-Version: 1.0 X-Received: by 10.204.191.72 with SMTP id dl8mr706994bkb.56.1374039065884; Tue, 16 Jul 2013 22:31:05 -0700 (PDT) Received: by 10.205.122.72 with HTTP; Tue, 16 Jul 2013 22:31:05 -0700 (PDT) Date: Wed, 17 Jul 2013 13:31:05 +0800 Message-ID: Subject: [PATCH -next] Input: olpc_apsp - remove redundant dev_err call in olpc_apsp_probe() From: Wei Yongjun To: dmitry.torokhov@gmail.com, grant.likely@linaro.org, rob.herring@calxeda.com, dsd@laptop.org Cc: yongjun_wei@trendmicro.com.cn, linux-input@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Acked-by: Daniel Drake --- drivers/input/serio/olpc_apsp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/serio/olpc_apsp.c b/drivers/input/serio/olpc_apsp.c index 818aa46..c96e3bd 100644 --- a/drivers/input/serio/olpc_apsp.c +++ b/drivers/input/serio/olpc_apsp.c @@ -187,10 +187,8 @@ static int olpc_apsp_probe(struct platform_device *pdev) return -ENOENT; priv->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(priv->base)) { - dev_err(&pdev->dev, "Failed to map WTM registers\n"); + if (IS_ERR(priv->base)) return PTR_ERR(priv->base); - } priv->irq = platform_get_irq(pdev, 0); if (priv->irq < 0)