From patchwork Tue Dec 17 01:16:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 3358091 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6ACFE9F314 for ; Tue, 17 Dec 2013 01:16:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9E1C02022A for ; Tue, 17 Dec 2013 01:16:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDA962017B for ; Tue, 17 Dec 2013 01:16:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111Ab3LQBQM (ORCPT ); Mon, 16 Dec 2013 20:16:12 -0500 Received: from mail-bk0-f42.google.com ([209.85.214.42]:50680 "EHLO mail-bk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751944Ab3LQBQL (ORCPT ); Mon, 16 Dec 2013 20:16:11 -0500 Received: by mail-bk0-f42.google.com with SMTP id w11so2611155bkz.29 for ; Mon, 16 Dec 2013 17:16:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=WTqvyWwYMRZZLAM6AgQirR0JMcXP0fOj+Fgp6A5wwSA=; b=lWFuX44rLff0bemQR2m5DoTgkSR8PtyWEUAogNlMFrF5g+EcWLpxjQ16t0YH+bfZiL YGBi3FXxXTusH8pLeCjONpyYvHASb3VJd/YugLiR1qergit90Io8KLTrg3ZsMb13saMa qtgeSQXif7LsjHIVpXRBCop52NoOMWStT+yMyV6xrcUOwtu3SMAWMwRUSBM5Ti7983PI 2fz3ZpJ4ju//SOu2dt2qYu4I7aDxzLbKNkQyvBQLVlL/bTOjCv+NcTbz49iLTag7QKsz 2N4CzDQvgtWsc+H4A7XtfX4fkUmvCjb8pV/JkoLER/a3SewOfi9XiJdCDDNJVeLjJ1zQ oSMA== MIME-Version: 1.0 X-Received: by 10.204.164.15 with SMTP id c15mr5932263bky.22.1387242970143; Mon, 16 Dec 2013 17:16:10 -0800 (PST) Received: by 10.204.74.130 with HTTP; Mon, 16 Dec 2013 17:16:10 -0800 (PST) Date: Tue, 17 Dec 2013 09:16:10 +0800 Message-ID: Subject: [PATCH -next] Input: pmic8xxx-pwrkey - fix to pass correct device identity to free_irq() From: Wei Yongjun To: dmitry.torokhov@gmail.com, sboyd@codeaurora.org, lars@metafoo.de, sachin.kamat@linaro.org Cc: yongjun_wei@trendmicro.com.cn, linux-input@vger.kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun free_irq() in the error handling case is missing when change pass input device directly to interrupt. Fixes: b27f8fee4965('Input: pmic8xxx-pwrkey - pass input device directly to interrupt') Signed-off-by: Wei Yongjun --- drivers/input/misc/pmic8xxx-pwrkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c index ef93840..3914e5b 100644 --- a/drivers/input/misc/pmic8xxx-pwrkey.c +++ b/drivers/input/misc/pmic8xxx-pwrkey.c @@ -182,7 +182,7 @@ static int pmic8xxx_pwrkey_probe(struct platform_device *pdev) return 0; free_press_irq: - free_irq(key_press_irq, pwrkey); + free_irq(key_press_irq, pwr); unreg_input_dev: input_unregister_device(pwr); pwr = NULL;