From patchwork Fri Aug 23 02:53:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2848519 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B757BBF546 for ; Fri, 23 Aug 2013 02:53:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B190020362 for ; Fri, 23 Aug 2013 02:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FA0420360 for ; Fri, 23 Aug 2013 02:53:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753400Ab3HWCxD (ORCPT ); Thu, 22 Aug 2013 22:53:03 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:61779 "EHLO mail-bk0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752821Ab3HWCxC (ORCPT ); Thu, 22 Aug 2013 22:53:02 -0400 Received: by mail-bk0-f45.google.com with SMTP id mx11so28907bkb.18 for ; Thu, 22 Aug 2013 19:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=kE6OXW+82T59ecCGZ3+fZVToMu9+AdpE16Uf8CbXSMg=; b=oKeijVPMs+H6lgGNhi8XSagko9o3tH5jkDPD2m91MvnjcgG8M9jJ1ng8LkiNdDWjEr ItbRjNbvEKmnMZW9CivObyTeAXoeSsC44uL3cvRjcpXhkS4fvTDnwOUvXN3+pdHLk9iT v9TZdhx6SFkBPsg9PczvgtTRAoMFP5UDl4JzAaM0pwbuzlrk91VJ039Zl4zresZqsZPI mFC+q0RgKpq7G9It/WHdGAVoukEjGWZVLKIGwpDYTFKbf/QiTaL6Q2lv/Ey8iNNsXbnP SH6OceYKc06uTDsyBoqebCeoxweMcJDV4P6JIlRprNGH7qiyvX9rcfZg8JhzTr97Z0NZ bLAg== MIME-Version: 1.0 X-Received: by 10.205.22.71 with SMTP id qv7mr12805741bkb.20.1377226381028; Thu, 22 Aug 2013 19:53:01 -0700 (PDT) Received: by 10.205.13.74 with HTTP; Thu, 22 Aug 2013 19:53:00 -0700 (PDT) Date: Fri, 23 Aug 2013 10:53:00 +0800 Message-ID: Subject: [PATCH] Input: wacom - fix error return code in wacom_probe() From: Wei Yongjun To: dmitry.torokhov@gmail.com, killertofu@gmail.com, pinglinux@gmail.com, chris@cnpbagwell.com, fengguang.wu@intel.com Cc: yongjun_wei@trendmicro.com.cn, linux-input@vger.kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Fix to return a negative error code from the urb submit error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/input/tablet/wacom_sys.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c index aaf23ae..7eeac61 100644 --- a/drivers/input/tablet/wacom_sys.c +++ b/drivers/input/tablet/wacom_sys.c @@ -1366,7 +1366,8 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i usb_set_intfdata(intf, wacom); if (features->quirks & WACOM_QUIRK_MONITOR) { - if (usb_submit_urb(wacom->irq, GFP_KERNEL)) + error = usb_submit_urb(wacom->irq, GFP_KERNEL); + if (error) goto fail5; }