From patchwork Wed Jun 26 01:56:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2782221 Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C5A0BC0AB1 for ; Wed, 26 Jun 2013 01:56:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E923E20284 for ; Wed, 26 Jun 2013 01:56:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 062EB20264 for ; Wed, 26 Jun 2013 01:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461Ab3FZB44 (ORCPT ); Tue, 25 Jun 2013 21:56:56 -0400 Received: from mail-bk0-f54.google.com ([209.85.214.54]:38589 "EHLO mail-bk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195Ab3FZB4z (ORCPT ); Tue, 25 Jun 2013 21:56:55 -0400 Received: by mail-bk0-f54.google.com with SMTP id it16so4567442bkc.41 for ; Tue, 25 Jun 2013 18:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=gI038fSrPH0QvGucylHm48duZukcLWyj3U3iAhK5Mdk=; b=Q3072OIErFS26k36/4J5ljQwcg6IP24O7eao0qGp5xIZv/cxJegKXj6r7XgzrMY8RA QdOZAgXr3iNSbhidvM13TdCiB4v3nNyNBl0YG8vo0hH0J4idwbJHs7R+LdvRCyVcbXkm gUVYJ+5VUJcU4pSZL0ljicHR60eWubcc7Fu+1md4UNFMqdI15fLPsxJFQ/rhWRDhOjsc +kCyH7bymliESeSmdEvm/XFjn9YwYFmqBTwSpuZyGuNwWoDrTAigOe+5xFPTAgAO2de0 1NCbRfmvKV9MYPUj/WEM+jyIzVqxLhclSTWiAcIJkPNyRjD4pUlUk7eeA4zgmppIlNEk wXcw== MIME-Version: 1.0 X-Received: by 10.204.229.7 with SMTP id jg7mr194681bkb.58.1372211814363; Tue, 25 Jun 2013 18:56:54 -0700 (PDT) Received: by 10.205.122.72 with HTTP; Tue, 25 Jun 2013 18:56:54 -0700 (PDT) Date: Wed, 26 Jun 2013 09:56:54 +0800 Message-ID: Subject: [PATCH -next] Input: nspire-keypad - remove redundant dev_err call in nspire_keypad_probe() From: Wei Yongjun To: dmitry.torokhov@gmail.com, grant.likely@linaro.org, rob.herring@calxeda.com, dt.tangr@gmail.com Cc: yongjun_wei@trendmicro.com.cn, linux-input@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/input/keyboard/nspire-keypad.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/input/keyboard/nspire-keypad.c b/drivers/input/keyboard/nspire-keypad.c index 1b0d04c..e0a1339 100644 --- a/drivers/input/keyboard/nspire-keypad.c +++ b/drivers/input/keyboard/nspire-keypad.c @@ -209,10 +209,8 @@ static int nspire_keypad_probe(struct platform_device *pdev) } keypad->reg_base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(keypad->reg_base)) { - dev_err(&pdev->dev, "failed to remap I/O memory\n"); + if (IS_ERR(keypad->reg_base)) return PTR_ERR(keypad->reg_base); - } keypad->input = input = devm_input_allocate_device(&pdev->dev); if (!input) {