Message ID | D582C70B-33D1-4F46-B4B9-4552D16AB548@live.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Jiri Kosina |
Headers | show
Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazolkn19010011.outbound.protection.outlook.com [52.103.67.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECC172904; Sat, 15 Feb 2025 18:39:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.67.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739644793; cv=fail; b=oT66hVvrUuBV4ho5tUfHcbHlKhwTaz4WZegPlD2lLsI1oRmQsl+iY/C7/bVH67sTB/N4U3iELj8u48NRtewjIp7axsi35Xi/F1i1kY3QN0wji8iPOCkPW5ddUbt4SbTavdgzoc8WNP5vwm68Lb+x7Jc05aN49RgpDNFlNUjOLec= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739644793; c=relaxed/simple; bh=PPi15f63hoAy86xQcZ45uU/GC2NgZXi0T9pMc3VgLvo=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=bDhUHQ1Q9cerRIHbU4C0vs3exutK8eIQcrhJPTXumyqvvlpRxp3ONS0e8x8Fprumd8QMmzTNkzxzFMFIvBVHI8vUkvFqqfoGDNry1fb28WiUCxMC+5F6tbtmrIJVPGWvY/4X4bXP0IZNsSjNH1rjuZpIcdRXNr0DPXicQGTDSVk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=MiX8OqdU; arc=fail smtp.client-ip=52.103.67.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="MiX8OqdU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fHjkR1VeSVLctHO+Jq4YH5shQeq/jCmNDkt5vsR6tISmT+OfCq05mzVZZO6Jt64X0jgEzxmv7Tco6zU2da7rpKeB1eX+57ZWiJmxirSHsUitQvFwap5L1UrQD6h4EOJ91czbhM4Xwj26SzzAGXb/bK4Bhc3GccGyx3d6DLlYZux+/ozOxs4eceRj1pkEMhAKcCRRRDZbes+g6I5IwdBhkgUgZ3f1A2+cUqlCSgl+MXc/9bYC/RH4is1VhEIXQQP3DFHPkhta7hFQ9SQZxSJ66IUA0eQXe/SGWq/Hw+iTeOAUvPDmuUai285k/uPgu3F8hCVl/h+iGcvQ7r3rhTLk/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PPi15f63hoAy86xQcZ45uU/GC2NgZXi0T9pMc3VgLvo=; b=pVnEBNbtf83KB7gYgWAiI2efQC1IocN9YwaG0eyvtBYYb1a0Ctu8j9aijKLJhILtuOVYk2yW9FwAxtxCdgRaULI2+U4B+qzotvVE3yvUkeYrjmU6Wm+2GWFEUwqWwqUbc7frEGnzU7YW5p9SkgfQ1weKiyGi7rpzeeme4Umq71TJg3fb38SKOBcZmHJ87mjVIATwAfDLhPqQhExVBT1+Jbin7/LshIKsU837YhsQGE9+DsDyqjjF2dRjcvxlVKF5fdwcgDje1wzbYju2ks3wl9tLHJnvJ3hJg3fydwof7l+5rZcvuQJnVF6QG/bpCSZegKmZP5g4xy6qVYp6g4YGLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PPi15f63hoAy86xQcZ45uU/GC2NgZXi0T9pMc3VgLvo=; b=MiX8OqdUAM20TzJ9yGvPIOh6VmHBgprPzS+FpbDpgqSY2BJNyh9uHbMaQnKzZQd7K+anIpn+9JX8gvvUa4t16uY++XzoxRHkK+UOmN0ahHLC2uSF/coN+0ifGm5ufq8u/GSevCzvl3ks+qG3CY32YVM+747UXkk8p7MAy+Zo7QPIgvAUcD1PAwd7GRw+qm7/taOhqtzv4hov6W4CKeyqLQwefXaBM+bN4xxEsnLxZlqYBoTaT5cdnw1s/VwMCHDwHKNKZ3Z9dt6ycWlvGUuIwBCUuZmuP0A89va+ZT+7Dhu41r6u/7q0N930y8HXANG2TSZzFXWi0jjYAm/lnPKrHw== Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:110::10) by MA0PR01MB7817.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:2b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Sat, 15 Feb 2025 18:39:47 +0000 Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde]) by PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde%6]) with mapi id 15.20.8445.016; Sat, 15 Feb 2025 18:39:47 +0000 From: Aditya Garg <gargaditya08@live.com> To: Jiri Kosina <jikos@kernel.org>, "jkosina@suse.com" <jkosina@suse.com>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, "bentiss@kernel.org" <bentiss@kernel.org> CC: Orlando Chamberlain <orlandoch.dev@gmail.com>, Kerem Karabay <kekrby@gmail.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "linux-input@vger.kernel.org" <linux-input@vger.kernel.org> Subject: [PATCH v3 2/3] HID: hid-appletb-bl: fix incorrect error message for default brightness Thread-Topic: [PATCH v3 2/3] HID: hid-appletb-bl: fix incorrect error message for default brightness Thread-Index: AQHbf9j80yp4KhZEGUC7hk04MHUEpw== Date: Sat, 15 Feb 2025 18:39:47 +0000 Message-ID: <D582C70B-33D1-4F46-B4B9-4552D16AB548@live.com> References: <00768D5D-F9CB-45DA-8F5A-3E21E84A8AA8@live.com> In-Reply-To: <00768D5D-F9CB-45DA-8F5A-3E21E84A8AA8@live.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN0PR01MB9608:EE_|MA0PR01MB7817:EE_ x-ms-office365-filtering-correlation-id: bc94fbed-bd29-4d4d-38c8-08dd4df01f71 x-microsoft-antispam: BCL:0;ARA:14566002|461199028|7092599003|15080799006|19110799003|8060799006|8062599003|102099032|440099028|3412199025; x-microsoft-antispam-message-info: =?utf-8?q?AhMmoLY6nfdu6HoOOAn8q3yZxSILR3f?= =?utf-8?q?XRnRWi43X8SaOpaTsTAWDPfpw0Xwmd9rmrUmF7ncmYpf2o6YCm7pdApphBzxZl5wJ?= =?utf-8?q?osU5BXiGO82oyf1SX/FguuEYRABYUPk7ruxLaQxRnyHZ+gyMsCgq7u/cwiIgUevFv?= =?utf-8?q?k0RAu6M1BEaEHBORKqS8KoZAl728K8Qf94av3nnCU6hNyYRSGkVruFaHZ7qmUKq8P?= =?utf-8?q?N8RXNF+3kwYMV3bUElRnlHuHzQuDs1UHSYJpMeGO+CQ6E0VQp59pflqLBPRfELSkr?= =?utf-8?q?smF4CvcprzwD72v/aeWib3kCVTGDZwkuOsxSK+f2lBR0xROcrpK96I66fpNQHN9G3?= =?utf-8?q?nbqPFAcnDM+Q6ih6ItpFN8HsrqjbjLjfZ/h+0V+ry+XXDQ6+HqnXykci5coWzh5S4?= =?utf-8?q?IciOKkjYH+7/UDn7NtpU24r8DlZbR8X3KLvIYEyhMt7oOayXWjOC2vEnDjaocoTkK?= =?utf-8?q?7yjPOGwPzWVe8scUJYAhvy1QHtgwg2eUW2FXn+/lEohAHc+nAeRw0/QNGy2Wp4KEJ?= =?utf-8?q?l+VAG2tzyZrm/MILV2fRYZyBAKe+fJV8Bx8SMoT5PH95fn+M3+eIAPwD+jY6Aoe29?= =?utf-8?q?FpjEJJazbvTMD370pH6OWNmLcS0N0xNRe6NgcI/qiMZ5KBb92rUGN23OriyNdf1Ef?= =?utf-8?q?7K5dFQ6rIJ5wmFKsNmXW+nz7Ui4q1LVzX8rULlfVunJUKqI+g8T4PLSDm7KAzNrsQ?= =?utf-8?q?CfGINnQU1BFLd4k7VrC+YYdXXBKzTYeR6rIOPFiwHsl0vVhwSyCQ53CjA99I1IWZm?= =?utf-8?q?hY46VNp64Qsyv+FCLCipJ3QYVQihX5RFhQsseQkex4edzqlvkezngScj8cyxukVtE?= =?utf-8?q?3xcd1oD525hq1aaaI2T9jxVC7RS3tzLDe9X/DlKPReGb1kcrT/cMxzmzO9ZideIx8?= =?utf-8?q?YTrLfN98tJezJRmRrPbLoDPYsB/PiK1EumW2MQ6cNzq5AtjAeLX6wICHEDRBP+m/Y?= =?utf-8?q?OQF8sqVvcy/MS6FV7TEdZA+ZN9lFLNfNni+IDpkClRUiFH2W0LI3k7M21iY89bU7g?= =?utf-8?q?082WQr8E+x7ZXWlws?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?sfDu86c+w8AqCay+X0sOznQHHpAH?= =?utf-8?q?NCwg8S2cGwqc/0Xya6JN26hOcjAQjYwM9A495E8aTWfW6M3C1Yv+po5qckQ6j7fzq?= =?utf-8?q?hQwgid28J0uhcy2Kr52sP+zRqjdNahc6WGcpLA8klzCT4HS92esuTfHdugSm5IK9l?= =?utf-8?q?k6VCSSjX/IfIQy/XULYR1Eg9JfdQE0hpgxW5qMXTiN0NxlFsuhRYFb0BGt4PO57nG?= =?utf-8?q?eilcgklN9t/btpZlyRm14/G7rMpeBIlEYOfhxHi0Co062rEp4Ue9gDTkj4GOfDzew?= =?utf-8?q?nQoIcT3rfroARAyWvP+cVU1AkDKp5kL6nQqbx1LPol2kacCvH3zzwhq+8kTnhgY/Z?= =?utf-8?q?F7tgGPvh61wAZm6M73ev+I052mHTOmKUTXuACennJOkpVtDaWsU1TuDHk9zlrwLAk?= =?utf-8?q?6bs16ZeORGYtJEvW4qS2WAAYEdbijhTSSRd34Lsp7+Yf3f8lzvI1JBZe5b1GNsRoX?= =?utf-8?q?7z8gRpOdZbwIBXH3DI0NxzigR4eSeoiQlCd8ly6+MtwsMKcbSvY5VLl5nV6NGq5zV?= =?utf-8?q?TqPJmDlEG0saA922PiMGeXtE5+5hKyxAjkPrbMVIFbx+L835uyHQdYIoVBDfhVO/L?= =?utf-8?q?qf2npFc/5NGwOXhc7mrHKIGFcUD000s6onEsq/2Q7RvvLkP0IbPEhUvFkRdohHWXB?= =?utf-8?q?ww2FBKIwmKA3bw1L82BSRJkDbJ2084LuUiLpuyjK/nSHf4SuGEAvxndJP49GZwnMs?= =?utf-8?q?tKYWJzHsXiosp0XAB3vEE6vItJp0kw+qm0xtPPxsXO8ukG553Rf3Dp6geqOGp0F3D?= =?utf-8?q?SBCVb7C68yLKhPHgMdLODbZf1NzrJ2h5ykOCxssvIrhtpsuLYrBlSUJLxuclsKsaT?= =?utf-8?q?slK8Z8sao09UF1szCdTBKDZCXhTZauUTtQaJr0rUZA+CIGOiPpmpdtOBRNgIMP5UO?= =?utf-8?q?Tf9Y129FGB4UYuk6P6Y6IuwImkLg4UGSfhjvn/eqbhWTh0vHExVgyNizlgtqZ5hdj?= =?utf-8?q?zVpy66f393t/EDiymCfIK/Ug/Z70uarm7xFn1X47ubaLFlFRplaR6bxOTpC9OvtBS?= =?utf-8?q?VpwbxEf7NLy63cEXSTHFoM9RBtcD9hW+SY3u4HD8bTcI3zaugypl0NSI1Ta3XvH6g?= =?utf-8?q?Rz2wru/UwvC+rjJkxCH0evn7yMKJCpl7MX8qWVMxPO+SNS+qLs5rOW0Z7Flczd8wy?= =?utf-8?q?9lMGccUMEDW6RprluDCT0Yoszcib8aOSTzSY0TOYHFupozMVOkBdkhs1jEb+odZ0t?= =?utf-8?q?G3KYIqmLr7SuW3CgwCJdt2NnrbAFteOAF3ZWnUZEOA/yk5kiLrQvdLCt0K+ANh8sN?= =?utf-8?q?ksRSxL2uVDTr2UPZ?= Content-Type: text/plain; charset="utf-8" Content-ID: <2A21832988EDA14F91B178D1B521D0FF@INDPRD01.PROD.OUTLOOK.COM> Content-Transfer-Encoding: base64 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: <linux-input.vger.kernel.org> List-Subscribe: <mailto:linux-input+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-input+unsubscribe@vger.kernel.org> MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: bc94fbed-bd29-4d4d-38c8-08dd4df01f71 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2025 18:39:47.0881 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA0PR01MB7817 |
Series |
[v3,1/3] HID: hid-appletb-kbd: simplify logic used to switch between media and function keys on pressing fn key
|
expand
|
diff --git a/drivers/hid/hid-appletb-bl.c b/drivers/hid/hid-appletb-bl.c index 1a3dcd44b..bad2aead8 100644 --- a/drivers/hid/hid-appletb-bl.c +++ b/drivers/hid/hid-appletb-bl.c @@ -145,7 +145,8 @@ static int appletb_bl_probe(struct hid_device *hdev, const struct hid_device_id appletb_bl_brightness_map[(appletb_bl_def_brightness > 2) ? 2 : appletb_bl_def_brightness]); if (ret) { - dev_err_probe(dev, ret, "Failed to set touch bar brightness to off\n"); + dev_err_probe(dev, ret, "Failed to set default touch bar brightness to %d\n", + appletb_bl_def_brightness); goto close_hw; } @@ -199,5 +200,5 @@ module_hid_driver(appletb_bl_hid_driver); MODULE_AUTHOR("Ronald Tschalär"); MODULE_AUTHOR("Kerem Karabay <kekrby@gmail.com>"); -MODULE_DESCRIPTION("MacBookPro Touch Bar Backlight Driver"); +MODULE_DESCRIPTION("MacBook Pro Touch Bar Backlight driver"); MODULE_LICENSE("GPL");