| Message ID | YPsa1qCBn/SAmE5x@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5af9f79b41b2ac58cc1d7c08945d7dbe26ee694a |
| Headers | show |
| Series | Input: pm8941-pwrkey - fix comma vs semicolon issue | expand |
Quoting Dmitry Torokhov (2021-07-23 12:39:02) > There is absolutely no reason to use comma operator in this code, 2 > separate statements make much more sense. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- Fixes: 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350 PON_HLOS PMIC peripheral") Reviewed-by: Stephen Boyd <swboyd@chromium.org>
On Fri, Jul 23, 2021 at 07:43:52PM +0000, Stephen Boyd wrote: > Quoting Dmitry Torokhov (2021-07-23 12:39:02) > > There is absolutely no reason to use comma operator in this code, 2 > > separate statements make much more sense. > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > --- > > Fixes: 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350 > PON_HLOS PMIC peripheral") It actually predates this patch and also not really a fix as the original code ends up working properly, but looks weird. > Reviewed-by: Stephen Boyd <swboyd@chromium.org> Thanks!
Quoting Dmitry Torokhov (2021-07-23 12:52:15) > On Fri, Jul 23, 2021 at 07:43:52PM +0000, Stephen Boyd wrote: > > Quoting Dmitry Torokhov (2021-07-23 12:39:02) > > > There is absolutely no reason to use comma operator in this code, 2 > > > separate statements make much more sense. > > > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > --- > > > > Fixes: 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350 > > PON_HLOS PMIC peripheral") > > It actually predates this patch and also not really a fix as the > original code ends up working properly, but looks weird. Alright.
diff --git a/drivers/input/misc/pm8941-pwrkey.c b/drivers/input/misc/pm8941-pwrkey.c index 10e3fc0eac6e..33609603245d 100644 --- a/drivers/input/misc/pm8941-pwrkey.c +++ b/drivers/input/misc/pm8941-pwrkey.c @@ -284,7 +284,7 @@ static int pm8941_pwrkey_probe(struct platform_device *pdev) } if (pwrkey->data->supports_ps_hold_poff_config) { - pwrkey->reboot_notifier.notifier_call = pm8941_reboot_notify, + pwrkey->reboot_notifier.notifier_call = pm8941_reboot_notify; error = register_reboot_notifier(&pwrkey->reboot_notifier); if (error) { dev_err(&pdev->dev, "failed to register reboot notifier: %d\n",
There is absolutely no reason to use comma operator in this code, 2 separate statements make much more sense. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/misc/pm8941-pwrkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)