From patchwork Wed Aug 10 12:33:27 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Kosina X-Patchwork-Id: 1053492 X-Patchwork-Delegate: jikos@jikos.cz Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7ACXUfA001697 for ; Wed, 10 Aug 2011 12:33:30 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752110Ab1HJMd3 (ORCPT ); Wed, 10 Aug 2011 08:33:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38281 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737Ab1HJMd3 (ORCPT ); Wed, 10 Aug 2011 08:33:29 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 51487890B6; Wed, 10 Aug 2011 14:33:28 +0200 (CEST) Date: Wed, 10 Aug 2011 14:33:27 +0200 (CEST) From: Jiri Kosina To: simon@mungewell.org Cc: =?ISO-8859-15?Q?Michal_Mal=FD?= , linux-input@vger.kernel.org Subject: Re: PATCH [1/6] HID: lg4ff - Move handling of Logitech wheels to lg4ff driver In-Reply-To: <30d25cbbd1396ee543893c7ce10b359d.squirrel@host171.canaca.com> Message-ID: References: <1436421.MlUiXUhh2P@qosmio-x300> <30d25cbbd1396ee543893c7ce10b359d.squirrel@host171.canaca.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Wed, 10 Aug 2011 12:33:30 +0000 (UTC) On Tue, 9 Aug 2011, simon@mungewell.org wrote: > Hi Jiri, > Saw that this is in the latest git grab, but I also noticed that (the new) > option 'LOGIWHEELS_FF' is not automatically selected if I grab an old > kernel config (say 2.6.38 on my ubuntu box) and do 'make oldconfig' with > the enter key held down. > > Did Michal/myself miss something, or is it preferable to not enable by > default? > > The down side is that the FF on these wheels will stop working (compared > to 3.0) if kernel builder does not enable this.... > > I can spin a patch if you'd like to point me the right direction. We normally don't do 'default y' for newly added HID options (I had quite some argument about this with Linus several times already :) ). This one could be different, as it's a split-off from an option that has existed before. But ... what's now LOGIWHEELS_FF used to be LOGITECH_FF, which isn't 'default y' either. So something along the lines of patch below would be fine for you guys? From: Jiri Kosina Subject: [PATCH] HID: make CONFIG_LOGIWHEELS_FF default to CONFIG_LOGITECH_FF Do this for backwards compatibility reasons (LOGIWHEELS_FF has been split-off from LOGITECH_FF), so that users don't have regressions with 'default' kernel configs. Reported-by: simon@mungewell.org Signed-off-by: Jiri Kosina --- drivers/hid/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 6ae234f..410eaa9 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -282,6 +282,7 @@ config LOGIWHEELS_FF bool "Logitech wheels configuration and force feedback support" depends on HID_LOGITECH select INPUT_FF_MEMLESS + default LOGITECH_FF help Say Y here if you want to enable force feedback and range setting support for following Logitech wheels: