From patchwork Wed Aug 7 01:01:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Kosina X-Patchwork-Id: 2839721 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Original-To: patchwork-linux-input@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D07A49F3B9 for ; Wed, 7 Aug 2013 01:01:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1898820212 for ; Wed, 7 Aug 2013 01:01:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35E41201E9 for ; Wed, 7 Aug 2013 01:01:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756330Ab3HGBBa (ORCPT ); Tue, 6 Aug 2013 21:01:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35650 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756110Ab3HGBB3 (ORCPT ); Tue, 6 Aug 2013 21:01:29 -0400 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6FB39A398F; Wed, 7 Aug 2013 03:01:28 +0200 (CEST) Date: Wed, 7 Aug 2013 03:01:26 +0200 (CEST) From: Jiri Kosina To: Peter Wu Cc: linux-input@vger.kernel.org, Manoj Chourasia , linux-kernel@vger.kernel.org, alnovak@suse.cz Subject: Re: List corruption in hidraw_release in 3.11-rc4 In-Reply-To: <6712128.bn50J4si9x@al> Message-ID: References: <6712128.bn50J4si9x@al> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 6 Aug 2013, Peter Wu wrote: > While debugging upowerd (with Logitech Unifying receiver via hidraw), > I came across this list corruption warning. Peter, does the patch below fix the problem you are seeing? Tested-by: Peter Wu --- drivers/hid/hidraw.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index a745163..6f1feb2 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c @@ -518,7 +518,6 @@ int hidraw_connect(struct hid_device *hid) goto out; } - mutex_unlock(&minors_lock); init_waitqueue_head(&dev->wait); INIT_LIST_HEAD(&dev->list); @@ -528,6 +527,7 @@ int hidraw_connect(struct hid_device *hid) dev->exist = 1; hid->hidraw = dev; + mutex_unlock(&minors_lock); out: return result;