diff mbox

[v2] hid-lg: Fix immediate disconnection of Logitech Rumblepad 2

Message ID bd414b27-d1c8-9395-7552-5dfe9a3ce63a@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ardinartsev Nikita Jan. 26, 2017, 1:54 p.m. UTC
hid-lg: Fix immediate disconnection of Logitech Rumblepad 2

With NOGET quirk Logitech F510 is now fully workable in dinput mode 
including rumble effects (according to fftest).
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117091
Signed-off-by: Ardinartsev Nikita <ardinar23@gmail.com>
---
  drivers/hid/hid-lg.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940),
  		.driver_data = LG_FF3 },
  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_SPACENAVIGATOR),

Comments

Benjamin Tissoires Jan. 26, 2017, 2:17 p.m. UTC | #1
On Jan 26 2017 or thereabouts, Ardinartsev Nikita wrote:
> hid-lg: Fix immediate disconnection of Logitech Rumblepad 2
> 
> With NOGET quirk Logitech F510 is now fully workable in dinput mode
> including rumble effects (according to fftest).
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117091
> Signed-off-by: Ardinartsev Nikita <ardinar23@gmail.com>
> ---

Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

>  drivers/hid/hid-lg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
> index c5c5fbe..52026dc 100644
> --- a/drivers/hid/hid-lg.c
> +++ b/drivers/hid/hid-lg.c
> @@ -872,7 +872,7 @@ static const struct hid_device_id lg_devices[] = {
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> USB_DEVICE_ID_LOGITECH_WINGMAN_FFG),
>  		.driver_data = LG_NOGET | LG_FF4 },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> USB_DEVICE_ID_LOGITECH_RUMBLEPAD2),
> -		.driver_data = LG_FF2 },
> +		.driver_data = LG_NOGET | LG_FF2 },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940),
>  		.driver_data = LG_FF3 },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_SPACENAVIGATOR),
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jiri Kosina Jan. 26, 2017, 8:59 p.m. UTC | #2
On Thu, 26 Jan 2017, Ardinartsev Nikita wrote:

> hid-lg: Fix immediate disconnection of Logitech Rumblepad 2
> 
> With NOGET quirk Logitech F510 is now fully workable in dinput mode including
> rumble effects (according to fftest).
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117091
> Signed-off-by: Ardinartsev Nikita <ardinar23@gmail.com>

The patch has been line-wrapped by your mail clinet. Please fix that up 
for any future submissions.

I've now fixed it up manually on my side and applied, thanks.
diff mbox

Patch

diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
index c5c5fbe..52026dc 100644
--- a/drivers/hid/hid-lg.c
+++ b/drivers/hid/hid-lg.c
@@ -872,7 +872,7 @@  static const struct hid_device_id lg_devices[] = {
  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 
USB_DEVICE_ID_LOGITECH_WINGMAN_FFG),
  		.driver_data = LG_NOGET | LG_FF4 },
  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 
USB_DEVICE_ID_LOGITECH_RUMBLEPAD2),
-		.driver_data = LG_FF2 },
+		.driver_data = LG_NOGET | LG_FF2 },
  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,