| Message ID | deaf38687dd8e9a970bc60bfd838ed62@disroot.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0e6095e964310b4d2f61b35572098fc13736f1e1 |
| Headers | show |
| Series | Input: synaptics: enable SMBUS on T480 thinkpad trackpad | expand |
On Mon, Jul 1, 2019 at 2:28 AM <colerogers@disroot.org> wrote: > > From: Cole Rogers <colerogers@disroot.org> > > Thinkpad t480 laptops had some touchpad features disabled, resulting in the > loss of pinch to activities in GNOME, on wayland, and other touch gestures > being slower. This patch adds the touchpad of the t480 to the smbus_pnp_ids > whitelist to enable the extra features. In my testing this does not break > suspend (on fedora, with wayland, and GNOME, using the rc-6 kernel), while > also fixing the feature on a T480. > > Signed-off-by: Cole Rogers <colerogers@disroot.org> > Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > drivers/input/mouse/synaptics.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > index b8ec30102..c8d0f5795 100644 > --- a/drivers/input/mouse/synaptics.c > +++ b/drivers/input/mouse/synaptics.c > @@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = { > "LEN005b", /* P50 */ > "LEN005e", /* T560 */ > "LEN0071", /* T480 */ > + "LEN0093", /* T480 */ > "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */ > "LEN0073", /* X1 Carbon G5 (Elantech) */ > "LEN0092", /* X1 Carbon 6 */ > -- > 2.21.0
On Mon, Jul 01, 2019 at 09:43:35AM +0200, Benjamin Tissoires wrote: > On Mon, Jul 1, 2019 at 2:28 AM <colerogers@disroot.org> wrote: > > > > From: Cole Rogers <colerogers@disroot.org> > > > > Thinkpad t480 laptops had some touchpad features disabled, resulting in the > > loss of pinch to activities in GNOME, on wayland, and other touch gestures > > being slower. This patch adds the touchpad of the t480 to the smbus_pnp_ids > > whitelist to enable the extra features. In my testing this does not break > > suspend (on fedora, with wayland, and GNOME, using the rc-6 kernel), while > > also fixing the feature on a T480. > > > > Signed-off-by: Cole Rogers <colerogers@disroot.org> > > > > Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Applied, thank you (but moved the entry so that the list is sorted). > > > --- > > drivers/input/mouse/synaptics.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > > index b8ec30102..c8d0f5795 100644 > > --- a/drivers/input/mouse/synaptics.c > > +++ b/drivers/input/mouse/synaptics.c > > @@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = { > > "LEN005b", /* P50 */ > > "LEN005e", /* T560 */ > > "LEN0071", /* T480 */ > > + "LEN0093", /* T480 */ > > "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */ > > "LEN0073", /* X1 Carbon G5 (Elantech) */ > > "LEN0092", /* X1 Carbon 6 */ > > -- > > 2.21.0 Thanks.
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index b8ec30102..c8d0f5795 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = { "LEN005b", /* P50 */ "LEN005e", /* T560 */ "LEN0071", /* T480 */ + "LEN0093", /* T480 */ "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */ "LEN0073", /* X1 Carbon G5 (Elantech) */ "LEN0092", /* X1 Carbon 6 */