From patchwork Wed Oct 26 16:56:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Twiss X-Patchwork-Id: 9397793 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 575C760231 for ; Wed, 26 Oct 2016 17:20:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4BB0729186 for ; Wed, 26 Oct 2016 17:20:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4075F29267; Wed, 26 Oct 2016 17:20:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AD95129186 for ; Wed, 26 Oct 2016 17:20:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934342AbcJZRTk (ORCPT ); Wed, 26 Oct 2016 13:19:40 -0400 Received: from mail1.bemta3.messagelabs.com ([195.245.230.173]:51568 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754914AbcJZRTa (ORCPT ); Wed, 26 Oct 2016 13:19:30 -0400 Received: from [85.158.137.19] by server-13.bemta-3.messagelabs.com id E4/A4-01804-D95E0185; Wed, 26 Oct 2016 17:19:25 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIKsWRWlGSWpSXmKPExsUSt3Opse7cpwI RBvtei1lMffiEzWL+kXOsFocXvWC0mH/lGqvF/a9HGS2+Xelgsrj56RurxeVdc9gsPvceYbS4 sW4fu8WThWeYLJZev8hk0br3CJD7sI/N4vLETnaLWzNesDoIeKyZt4bRY+esu+we1zaLeSze8 5LJY9OqTjaPO9f2sHns/N7A7vF5k1wARxRrZl5SfkUCa8blnQ+YC5bIVTw5spi1gXGtZBcjF4 eQwHpGie+/rrF3MXICORUSSyefB7N5BZIltt8+wwZicwo4Ssx+NocVosZB4sCJ34wgNpuAocS 8N+/BbBYBVYljq84xg9jCAnESS/ctYQdZICLwi1Hi5LK1TCAOs0Ans8TaA1vZIDYISpyc+YQF xGYWkJA4+OIFUDcH0AYtieXHIkHCEgL2EtPfXwULSwjoSzQei4UIG0p8n/WNBSJsLrFoquYER sFZSGbOQjJzASPTKkaN4tSistQiXSMLvaSizPSMktzEzBxdQwNjvdzU4uLE9NScxKRiveT83E 2MwKirZ2Bg3MHYfsLvEKMkB5OSKO+DJwIRQnxJ+SmVGYnFGfFFpTmpxYcYZTg4lCR4p4DkBIt S01Mr0jJzgPEPk5bg4FES4T0EkuYtLkjMLc5Mh0idYlSUEufNAkkIgCQySvPg2mAp5xKjrJQw LyMDA4MQT0FqUW5mCar8K0ZxDkYlYV5OYAIT4snMK4Gb/gpoMRPQ4unpYItLEhFSUg2M6iUbn 4kuLGOV/Xpw4g2mzpCpRhGp/0UuzNslM6WQhWWy/3PdP9baEuFdCrn3zk54HXt3R8+R6wzWGx wnl1T9vJYYGrA93/Y7m/Vlrdvsd7u89ebNLgw0XPPXUczMp8l9TYlehKrYwju6AWdyLniK/Z+ nYcDp84fHykfOZVv4FTmm042Rh58rsRRnJBpqMRcVJwIAg5b0RDQDAAA= X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-9.tower-39.messagelabs.com!1477502364!57764713!2 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 9.0.13; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32408 invoked from network); 26 Oct 2016 17:19:25 -0000 Received: from mailrelay2.diasemi.com (HELO sw-ex-cashub01.diasemi.com) (94.185.165.51) by server-9.tower-39.messagelabs.com with AES128-SHA encrypted SMTP; 26 Oct 2016 17:19:25 -0000 Received: from swsrvapps-01.diasemi.com (10.20.28.141) by SW-EX-CASHUB01.diasemi.com (10.20.16.140) with Microsoft SMTP Server id 14.3.248.2; Wed, 26 Oct 2016 18:19:24 +0100 Received: by swsrvapps-01.diasemi.com (Postfix, from userid 22547) id E25483FA9D; Wed, 26 Oct 2016 18:19:23 +0100 (BST) Message-ID: In-Reply-To: References: From: Steve Twiss Date: Wed, 26 Oct 2016 17:56:37 +0100 Subject: [PATCH V2 01/10] Documentation: devicetree: input: additions for da9061 onkey driver To: DEVICETREE , Dmitry Torokhov , LINUX-INPUT , LINUX-KERNEL , Mark Rutland , Rob Herring CC: Eduardo Valentin , Guenter Roeck , LINUX-PM , LINUX-WATCHDOG , Lee Jones , Liam Girdwood , Mark Brown , Support Opensource , Wim Van Sebroeck , Zhang Rui MIME-Version: 1.0 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-ServerInfo: sw-ex-cashub01.diasemi.com, 9 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 26/10/2016 13:31:00 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Steve Twiss Add binding information for DA9061 onkey. This patch updates the compatible string "dlg,da9061-onkey" to support DA9061, removes the reference to KEY_SLEEP (which the driver no longer supports) and fixes a typo in the example for DA9063. It also adds two new examples, one for DA9062 and one for DA9061. The DA9061 examples uses a fall-back compatible string for the DA9062 onkey driver. Signed-off-by: Steve Twiss --- This patch applies against linux-next and v4.8 v1 -> v2 - Patch renamed from [PATCH V1 06/10] to [PATCH V2 01/10] -- these changes were made to fix checkpatch warnings caused by the patch set dependency order - Typo s/ther/the/ in commit message - Explanation about why KEY_SLEEP was removed (see below) - Addition of DA9062 example - Addition of a DA9061 example to follow the driver fall-back compatible convention being applied for this device driver Hi, This patch depends on the acceptance of the main code for the onkey: [PATCH V2 07/10] Input: da9061: onkey driver. The device driver no longer supports KEY_SLEEP. It only supports KEY_POWER. This change was sent a while ago for the DA9063 ONKEY driver, but the docs were not updated. Supporting KEY_SLEEP was not the general convention and the typical solution should have been for KEY_POWER to support both cases of suspend and S/W power off. There is also new binding examples for DA9062 and DA9061. Importantly, the Linux device driver changes for DA9061 were rejected because the DA9062 device driver can be reused. For this reason, the DA9061 example uses a fall-back compatible string. Regards, Steve Twiss, Dialog Semiconductor Ltd. .../devicetree/bindings/input/da9062-onkey.txt | 39 +++++++++++++++------- 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt b/Documentation/devicetree/bindings/input/da9062-onkey.txt index ab0e048..e5a0469 100644 --- a/Documentation/devicetree/bindings/input/da9062-onkey.txt +++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt @@ -1,32 +1,47 @@ -* Dialog DA9062/63 OnKey Module +* Dialog DA9061/62/63 OnKey Module -This module is part of the DA9062/DA9063. For more details about entire -chips see Documentation/devicetree/bindings/mfd/da9062.txt and -Documentation/devicetree/bindings/mfd/da9063.txt +This module is part of the DA9061/DA9062/DA9063. For more details about entire +DA9062 and DA9061 chips see Documentation/devicetree/bindings/mfd/da9062.txt +For DA9063 see Documentation/devicetree/bindings/mfd/da9063.txt -This module provides KEY_POWER, KEY_SLEEP and events. +This module provides the KEY_POWER event. Required properties: - compatible: should be one of: + dlg,da9061-onkey dlg,da9062-onkey dlg,da9063-onkey Optional properties: - - dlg,disable-key-power : Disable power-down using a long key-press. If this +- dlg,disable-key-power : Disable power-down using a long key-press. If this entry exists the OnKey driver will remove support for the KEY_POWER key - press. If this entry does not exist then by default the key-press - triggered power down is enabled and the OnKey will support both KEY_POWER - and KEY_SLEEP. + press when triggered using a long press of the OnKey. -Example: - - pmic0: da9062@58 { +Example: DA9063 + pmic0: da9063@58 { onkey { compatible = "dlg,da9063-onkey"; dlg,disable-key-power; }; + }; + +Example: DA9062 + + pmic0: da9062@58 { + onkey { + compatible = "dlg,da9062-onkey"; + dlg,disable-key-power; + }; + }; + +Example: DA9061 using a fall-back compatible for the DA9062 onkey driver + pmic0: da9061@58 { + onkey { + compatible = "dlg,da9061-onkey", "dlg,da9062-onkey"; + dlg,disable-key-power; + }; };