From patchwork Sat Feb 3 17:38:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10198623 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3C4F8603ED for ; Sat, 3 Feb 2018 17:39:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45EB128F7B for ; Sat, 3 Feb 2018 17:39:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3AC4A28FE5; Sat, 3 Feb 2018 17:39:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB21628F7B for ; Sat, 3 Feb 2018 17:39:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752799AbeBCRjH (ORCPT ); Sat, 3 Feb 2018 12:39:07 -0500 Received: from mout.web.de ([217.72.192.78]:57230 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752795AbeBCRjG (ORCPT ); Sat, 3 Feb 2018 12:39:06 -0500 Received: from [192.168.1.2] ([77.181.226.140]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MJkt6-1egvqg1LNc-001DUp; Sat, 03 Feb 2018 18:38:58 +0100 Subject: [PATCH 2/6] hid-prodikeys: Delete an unnecessary variable initialisation in pk_probe() From: SF Markus Elfring To: linux-input@vger.kernel.org, Benjamin Tissoires , Jiri Kosina Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Sat, 3 Feb 2018 18:38:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K0:TvRHbrcs6BBPeFnrFr5dLTYXZb3opKgozjvb2EDDYfuzH/qhSJm e1RPqf1Gi/DJyEOpS+7UXa3IOHvCkhdfzb23ZKkxqI+PCyy+aX6W8yWqJcKrIOgXoh4kNhr vM7dQKp3uGSUBxstk3VtZGulvN5nobn6YqSV4J3auywRa/UIMqr4OcV3w5z/+x9K9M+r7Ci yAxNNV9u0hslUuo6o3Cxw== X-UI-Out-Filterresults: notjunk:1; V01:K0:Ln93N9jxdLE=:2UDYwfq8667/edl5mctKYl fjzfn97mQC98//bb1AVJJZUGwN4v9Kbx0WrZKDT4hbgc8k3kiLNVsFYy7DMqXtB/9e8noADEd l3IyhQTy9l1RHvacuqHxbJeXsov0XG3B08ZUC6c0wAhG9z3az78iXV0B+Li77Sd/GHa4Qnvpf MhpDpizAfqpXSwCO1wNisMnErfkzAxyx0giGDvON4rU1DqK0cqBM79ooIgI1fxFLlINux3R0i sZJnHwGTw7kahlGYyFzBd0/GDlmQO3tOwy0ZgsxtQjs6qr6gE71/+08/1RU8PXuac18ejFivh skmVKEyjDywn17eHlTj2FFPUuRgfZG/IobM8bUDQKyqiMfv8vajF2uEFrVaXPumrwqzVD/qFa 2jDlPRva7iCt4XM3vsmS9Hb+unX5Au/BJcCMiehrhNS03qzHZNDM/oEFZyV7UY6bdCzlSj3a5 90QEsEYSCVbRgR1+C+TTQqciGtb5+EzRHu9p5yYBa9kTMWj5h/bLnNaGpDfU3uTx4B+h5kPQB +RVyHe7BbSiN50+WuTUiMYT/cZo0wQ+qg1/T1k5OKvn+RPkUt8cT34XAy03ky1VsnobmCug7K RsP4+hLrzo7dS5jDfB2dDFSXfS3qCwv/7wVtNNcODk5K74kZ5gbgs6D0mm6xFCVZTbX0zOj9w aZJl5KuP4toF35f/sjC0kbt47gQfEAVO7C96E1JEU/YdYnogbYKhCPsedx3lF+m+vES6gAcIV nTbh2aZHbc+gS8LlgVUkwWRah7SP1P7E2oIbrJU6NUa83hh44cpBAQdHsC+YaI7tZCg1N6YiL YQEfakJ2V7NaRXkB4D0Np/4k0HEFhkOdQNBRvlu9o8g6RTA3UQ= Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 3 Feb 2018 14:45:24 +0100 The local variable "pm" will eventually be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/hid/hid-prodikeys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c index 9cad4973a67b..2e79dfc92162 100644 --- a/drivers/hid/hid-prodikeys.c +++ b/drivers/hid/hid-prodikeys.c @@ -798,6 +798,6 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id) unsigned short ifnum = intf->cur_altsetting->desc.bInterfaceNumber; unsigned long quirks = id->driver_data; struct pk_device *pk; - struct pcmidi_snd *pm = NULL; + struct pcmidi_snd *pm; pk = kzalloc(sizeof(*pk), GFP_KERNEL);