From patchwork Mon Nov 28 13:56:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 9449561 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EEBD96071E for ; Mon, 28 Nov 2016 13:56:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D2F9825D9E for ; Mon, 28 Nov 2016 13:56:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C7943277D9; Mon, 28 Nov 2016 13:56:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C5CB25D9E for ; Mon, 28 Nov 2016 13:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932666AbcK1N4j (ORCPT ); Mon, 28 Nov 2016 08:56:39 -0500 Received: from mx2.suse.de ([195.135.220.15]:41153 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932283AbcK1N4i (ORCPT ); Mon, 28 Nov 2016 08:56:38 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 58750ACA3; Mon, 28 Nov 2016 13:56:36 +0000 (UTC) Date: Mon, 28 Nov 2016 14:56:36 +0100 Message-ID: From: Takashi Iwai To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: i8042 error at booting an Intel Cherry Trail-based device User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Dmitry, I've been testing a small machine with Intel Cherry Trail chipset, and noticed that the kernel spews errors always like: i8042: PNP: No PS/2 controller found. Probing ports directly. i8042: Can't read CTR while initializing i8042 i8042: probe of i8042 failed with error -5 Especially the second one ("Can't read CTR...") is annoying since it's in KERN_ERR level and thus appears even booted with quiet boot option. Actually this is the only error message appearing at boot, so I'd love to get rid of it. What is the preferred way to reduce this? For example, is a patch like below OK to simply change the log level and the error code? thanks, Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] i8042: Reduce the log level of i8042 CTR read error The error message "Can't read CTR while initializing i8042" appears on Cherry Trail-based devices at each boot time: i8042: PNP: No PS/2 controller found. Probing ports directly. i8042: Can't read CTR while initializing i8042 i8042: probe of i8042 failed with error -5 This is annoying, since it's the only error message with KERN_ERR level appearing during the boot. This patch changes the kernel log level to KERN_INFO for that message, and replaces the error code to -ENODEV so that this probe failure won't be complained like the above. Signed-off-by: Takashi Iwai --- drivers/input/serio/i8042.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index b4e1ac5c9ea8..2c2683e357e9 100644 --- a/drivers/input/serio/i8042.c +++ b/drivers/input/serio/i8042.c @@ -980,8 +980,8 @@ static int i8042_controller_init(void) udelay(50); if (i8042_command(&ctr[n++ % 2], I8042_CMD_CTL_RCTR)) { - pr_err("Can't read CTR while initializing i8042\n"); - return -EIO; + pr_info("Can't read CTR while initializing i8042\n"); + return -ENODEV; } } while (n < 2 || ctr[0] != ctr[1]);