mbox series

[v4,0/2] tpm2: Make TPM2 logs accessible for non-UEFI firmware

Message ID 20200402225140.922789-1-stefanb@linux.vnet.ibm.com (mailing list archive)
Headers show
Series tpm2: Make TPM2 logs accessible for non-UEFI firmware | expand

Message

Stefan Berger April 2, 2020, 10:51 p.m. UTC
From: Stefan Berger <stefanb@linux.ibm.com>

This series of patches extends the existing TPM2 ACPI table with additional
fields found in the TPM2 TCG ACPI specification (reference is in the patch)
that allow access to the log's address and its size. We then modify the
code that so far only enables access to a TPM 1.2's log for a TPM2 as well.
This then enables access to the TPM2's log on non-UEFI system that for example
run SeaBIOS.

   Stefan

v3->v4:
  - Repost as one series

v2->v3:
  - Split the series into two separate patches
  - Added comments to ACPI table fields
  - Added check for null pointer to log area and zero log size

v1->v2:
  - Repost of the series



Stefan Berger (2):
  acpi: Extend TPM2 ACPI table with missing log fields
  tpm: Add support for event log pointer found in TPM2 ACPI table

 drivers/char/tpm/eventlog/acpi.c | 56 +++++++++++++++++++++++++---------------
 drivers/char/tpm/tpm_crb.c       | 13 +++++++---
 drivers/char/tpm/tpm_tis.c       |  4 ++-
 include/acpi/actbl3.h            |  5 ++--
 4 files changed, 51 insertions(+), 27 deletions(-)

Comments

Jarkko Sakkinen April 3, 2020, 7:01 a.m. UTC | #1
On Thu, Apr 02, 2020 at 06:51:38PM -0400, Stefan Berger wrote:
> From: Stefan Berger <stefanb@linux.ibm.com>
> 
> This series of patches extends the existing TPM2 ACPI table with additional
> fields found in the TPM2 TCG ACPI specification (reference is in the patch)
> that allow access to the log's address and its size. We then modify the
> code that so far only enables access to a TPM 1.2's log for a TPM2 as well.
> This then enables access to the TPM2's log on non-UEFI system that for example
> run SeaBIOS.
> 
>    Stefan
> 
> v3->v4:
>   - Repost as one series
> 
> v2->v3:
>   - Split the series into two separate patches
>   - Added comments to ACPI table fields
>   - Added check for null pointer to log area and zero log size
> 
> v1->v2:
>   - Repost of the series
> 
> 
> 
> Stefan Berger (2):
>   acpi: Extend TPM2 ACPI table with missing log fields
>   tpm: Add support for event log pointer found in TPM2 ACPI table
> 
>  drivers/char/tpm/eventlog/acpi.c | 56 +++++++++++++++++++++++++---------------
>  drivers/char/tpm/tpm_crb.c       | 13 +++++++---
>  drivers/char/tpm/tpm_tis.c       |  4 ++-
>  include/acpi/actbl3.h            |  5 ++--
>  4 files changed, 51 insertions(+), 27 deletions(-)
> 
> -- 
> 2.14.5
> 

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

I'll apply this after I'll get Rafael's answer whether I can add his ack
to the commits.

/Jarkko
Stefan Berger April 3, 2020, 11:55 a.m. UTC | #2
On 4/3/20 3:01 AM, Jarkko Sakkinen wrote:
> Reviewed-by: Jarkko Sakkinen<jarkko.sakkinen@linux.intel.com>
>
> I'll apply this after I'll get Rafael's answer whether I can add his ack
> to the commits.
>
> /Jarkko

Thank you!

    Stefan