From patchwork Mon Oct 17 23:57:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lino Sanfilippo X-Patchwork-Id: 13009721 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92026C4332F for ; Mon, 17 Oct 2022 23:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231218AbiJQX6V (ORCPT ); Mon, 17 Oct 2022 19:58:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230327AbiJQX6S (ORCPT ); Mon, 17 Oct 2022 19:58:18 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CD8782617; Mon, 17 Oct 2022 16:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1666051070; bh=7oD2gJbQp1Cg+oLFOTx+aePoyBmlEYcvMuhJJrprPIc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=khWyHDKN65JI84+f6bjynqpyozr+CU4eO2p75KbTr6szb7PX90WsTAJmAmp1jlPWj H+VSwvxrLW5N4IaV6jrc1d6s7a1P+81SFha1aKQMDpotlCsH8VYIYCBLOyULW8NZuU h+CHMD1keS+3rx2e3+j2ABA2lS5Q4GiQsJKm/x0k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from Venus.speedport.ip ([84.162.5.241]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MSbx3-1oZBxv0Vj7-00Swlr; Tue, 18 Oct 2022 01:57:50 +0200 From: Lino Sanfilippo To: peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca Cc: stefanb@linux.vnet.ibm.com, linux@mniewoehner.de, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, jandryuk@gmail.com, pmenzel@molgen.mpg.de, l.sanfilippo@kunbus.com, LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com Subject: [PATCH v8 00/11] TPM IRQ fixes Date: Tue, 18 Oct 2022 01:57:21 +0200 Message-Id: <20221017235732.10145-1-LinoSanfilippo@gmx.de> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:YSik3saGDZfzYMWiK3Wa4Ktgwk+JxreBdc2ZO9VkCW6FK/I1q2h XAYazegPHH8whNGrzO3/4839Fxu8+sQHMdMgFJvv95ZQzwu1UDIfoxjAaDybaMCUYj43wFb GaBdHR4iLY2lJFhhF+CxJu9rKdjjTR2uuATdQ98L4m1trg3+HN6wyXzpjsTz8msRPHOKSxL vTVHd/DSmdde69u6Dt3IA== X-UI-Out-Filterresults: notjunk:1;V03:K0:6MjsmK+nfaw=:H5r78Cm2pCp9xQu+r4MUtZ skDL1oVZyUik7C6KZOIQc0jKHeAkgEnd0T/1AfUZqKy7IhEF2YvY4ZCwURSDlFy30uYHJYiU4 q9BQkfr0VUkDgATqj5fSos+QJC7bEjEWz566CxRQr9k4sOgLuv8i0etvECLVqN12ixc9XFr88 u3SCqMO883iKZbh5E8MgHwH90JMOHtHgU7XCjDs8pADBEIAum51ygDpsb9iZZ+FKpZ2m5Mk51 /y5LO1A1DtsWnA/ImNUP2gWFstlGGd+g5Sb/b1nYwXFt9ifGR9Xr2OzF8WCncO0ai7TlkkEC+ fkJANK4RRUwiAgDbZTltz/1ZMQC1BzvndtmaR8k0FBKjplv3+O7JaF3kuguEuehcrJwzt5L8k ZbdH5FdI6kQTgvknQrfMyK7U/Qh8LCvlEHWFndca7QevzJykwOeEEr+/aEqsB5WvDVohMZ0He XMHoKtVhC1zrtxgqL91T/+7c33w4EhE8TNZdQjny4cPDn1s5MX7r/GcTRWQ1gq2Nht7lveFi9 SfnETPHwGrhzEBoPcO2C+BE632AZ+UQdRYtRkLPVqA9fLy2dQ7Qipae8uz7CelT1Rw8osMYzX 6/YjRK4ZSLiWn/yfsxerAgB0OdHcqv4cZgWcHH8SMA75CV1tOlCziAzvmwk88hdOfS7InAw4u 7+PLHjqKHGhAjxSGNguyDHg0xlZeMw5aWC8YPRKlk2sCwSXDbRoflBvalCbPlLRYMLQaci5BX Y7bLq89QL59252/l4bquYxDnbYuoNTZdIBUOzG3MGvJfNBb6NS56UT7cgrVaVncMUofAFQkXN v8eUWkRTuQN5RKx0FBFUu01wtTfdZQIYRXYGcjPBG7CRZv01+b8AeCO8SdqgR9YBin4+2HZnn TGLRjgxJzAhO750ApirDHoveSBe4aKzvMhwLOIFhpX3z/ctOoLTNw4s9/OBG9qqN6dZ+6Jt09 p9/RCVvyctfmbeqEtkezya46Is29nauO6pstYKhTycSMwzmRm/QDZe966uQps11fWl12dh1GT tckDadSmaOeizy6kxS83nT9iNvUV5RiOL8gceGPPZ1PmqL6PnQdb5kr2zvQD66lsrgtrh/QU1 6qL/m2kMJxqjpUnINJMc5lVVVFyC3iAg/HM1Pvz/wtQ/kRgil4gQUZSl4uNkTqBVZGthq/u2f UXZko13ELE6ZFKY44LS4EFak7wMN35QgyhxwZcYd4q1PysTqgwiuEp3Xinll1e6jR+geF5JNH FwtZLQWBFnpTqIGOcBz+zFXvbUPsO5ztkJprfAJ5yJkW+pAvCSb01hpfPmSdCiXMoxrxvNw4q ocR5Es8hNsE0Pn+Hn1tcK1/sI+n7UJLkVtcV9jHO6Xey9iseSWQ1kxT1mKF8yKKJ6Y1DC6OKO yN/YwVIIEC01+HDtAb9e4ZkR3CKhLZIaVoMs99IwaiVIlG8qwMcwfR7ssAAAeF+4G8ZbEYbLX uyRdSZTEIYUvbPzvdCPCMI0TMyjQTo5L7X7ZRiBOUsUcJs00zRpXbOPbsgKyfdnVI37S1qGxq bddEaAsRZsre5DofqI75b0F4uB+uj8xr/yRhmAb8lUBtd Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org From: Lino Sanfilippo This series enables IRQ support for the TPM TIS core. For this reason a number of bugfixes around the interrupt handling are required (patches 1 to 4). Patch 5 takes into account that according to the TPM Interface Specification stsValid and commandRead interrupts might not be supported by the hardware. For this reason the supported interrupts are first queried and stored. Then wait_for_tpm_stat() is adjusted to not wait for status changes that are not reported by interrupts. Patch 6 moves the interrupt flag checks into an own function as suggested by Jarkko. Patch 7 Removes the possibility that tpm_tis_data->locality can be changed at driver runtime so this variable can be read without the need to protect it against concurrent modification. Patch 8 addresses the issue with concurrent locality handling: Since the interrupt handler writes the interrupt status registers it needs to hold the locality. However it runs concurrently to the thread which triggered the interrupt (e.g. by reading or writing data to the TPM). So it must take care when claiming and releasing the locality itself, because it may race with the concurrent running thread which also claims and releases the locality. To avoid that both interrupt and concurrent running thread interfere with each other a locality counter is used which guarantees that at any time the locality is held as long as it is required by one of both execution paths. Patch 9 implements the request of a threaded interrupt handler. This is needed since SPI uses a mutex for data transmission and since we access the interrupt status register via SPI in the irq handler we need a sleepable context. Patch 10 makes sure that writes to the interrupt register are effective if done in the interrupt handler. Patch 11 enables the test for interrupts by setting the required flag before the test is executed. Changes in v8: - tpm_tis_data->locality is not changed at runtime any more so that it can be read without any protection against concurrent modification. - add missing brackets as pointed out by Jason Andryuk Changes in v7: - moved interrupt flag checks into an own function as suggested by Jarkko - added "Tested-by" tags for Tests from Michael Niewöhner - fixed one comment Changes in v6: - set TPM_TIS_IRQ_TESTED in flag member of the tpm_tis_data struct instead in an own bitfield - improve commit messages - use int_mask instead of irqs_in_use as variable name - use sts_mask instead of active_irqs as variable name - squash patch 5 and 6 - prefix functions with tpm_tis_ - remove "fixes" tag Changes in v5: - improve commit message of patch 1 as requested by Jarko - drop patch that makes locality handling simpler by only claiming it at driver startup and releasing it at driver shutdown (requested by Jarko) - drop patch that moves the interrupt test from tpm_tis_send() to tmp_tis_probe_irq_single() as requested by Jarko - add patch to make locality handling threadsafe so that it can also be done by the irq handler - separate logical changes into own patches - always request threaded interrupt handler Changes in v4: - only request threaded irq in case of SPI as requested by Jarko. - reimplement patch 2 to limit locality handling changes to the TIS core. - separate fixes from cleanups as requested by Jarko. - rephrase commit messages Changes in v3: - fixed compiler error reported by kernel test robot - rephrased commit message as suggested by Jarko Sakkinen - added Reviewed-by tag Changes in v2: - rebase against 5.12 - free irq on error path Lino Sanfilippo (11): tpm, tpm_tis: Avoid cache incoherency in test for interrupts tpm, tpm_tis: Claim locality before writing TPM_INT_ENABLE register tpm, tpm_tis: Disable interrupts if tpm_tis_probe_irq() failed tpm, tmp_tis: Claim locality before writing interrupt registers tpm, tpm_tis: Only handle supported interrupts tpm, tpm_tis: Move interrupt mask checks into own function tpm, tpm_tis: do not check for the active locality in interrupt handler tpm, tpm: Implement usage counter for locality tpm, tpm_tis: Request threaded interrupt handler tpm, tpm_tis: Claim locality in interrupt handler tpm, tpm_tis: Enable interrupt test drivers/char/tpm/tpm_tis.c | 2 +- drivers/char/tpm/tpm_tis_core.c | 267 +++++++++++++++++++++----------- drivers/char/tpm/tpm_tis_core.h | 5 +- 3 files changed, 181 insertions(+), 93 deletions(-) base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780