mbox series

[ima-evm-utils,v1,0/4] Fix some issues in evmctl

Message ID 20221102184534.1075049-1-stefanb@linux.ibm.com (mailing list archive)
Headers show
Series Fix some issues in evmctl | expand

Message

Stefan Berger Nov. 2, 2022, 6:45 p.m. UTC 
This series of patches fixes memory leaks related to tpm_bank_info
allocations and entry.template as well as gcc compiler warnings
when building with -fanalyzer (gcc 12.2.1).

This series is intended to be applied on top of Mimi's current series
at https://github.com/mimizohar/ima-evm-utils/tree/next-testing .

   Stefan

Stefan Berger (4):
  Fix memory leaks of tpm_bank_info allocations
  Fix memory leak related to entry.template
  Add assert to ensure that algo_name in bank is set
  Change condition to free(pub)

 src/evmctl.c | 47 ++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 40 insertions(+), 7 deletions(-)


base-commit: f6abaed5d0d0a4478cf25a8096a4ff44be4a234e

Comments

Mimi Zohar Nov. 3, 2022, 9:50 p.m. UTC | #1 
Hi Stefan,

On Wed, 2022-11-02 at 14:45 -0400, Stefan Berger wrote:
> This series of patches fixes memory leaks related to tpm_bank_info
> allocations and entry.template as well as gcc compiler warnings
> when building with -fanalyzer (gcc 12.2.1).
> 
> This series is intended to be applied on top of Mimi's current series
> at https://github.com/mimizohar/ima-evm-utils/tree/next-testing .

Thank you for the cleanup.  Aside from the missing patch descriptions
(1/4, 2/4), the patch set looks good.  It applied cleanly on top of the
"misc bug and other fixes" patch set and Tergel's "support for reading
per bank TPM 2.0 PCRs via sysfs" patch, which are now in next-testing.
Mimi Zohar Nov. 16, 2022, 2:04 a.m. UTC | #2 
Hi Stefan,

On Wed, 2022-11-02 at 14:45 -0400, Stefan Berger wrote:
> This series of patches fixes memory leaks related to tpm_bank_info
> allocations and entry.template as well as gcc compiler warnings
> when building with -fanalyzer (gcc 12.2.1).
> 
> This series is intended to be applied on top of Mimi's current series
> at https://github.com/mimizohar/ima-evm-utils/tree/next-testing .
> 
>    Stefan
> 
> Stefan Berger (4):
>   Fix memory leaks of tpm_bank_info allocations
>   Fix memory leak related to entry.template
>   Add assert to ensure that algo_name in bank is set
>   Change condition to free(pub)

Thanks, Stefan.  The patches applied to the next/next-testing branches.
In the future, no matter how trivial the patch is, please include patch
descriptions.

thanks,

Mimi