| Message ID | 20241010091559.30866-1-bernacki@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | char: tpm: Adjust cr50_i2c locking mechanism | expand |
Jarkko, Could you check if there is any additional work needed for these patches? Please let me if you have any more comments, which can block it from being merged. thanks, greg
On Mon Oct 28, 2024 at 11:09 AM EET, Grzegorz Bernacki wrote: > Jarkko, > > Could you check if there is any additional work needed for these patches? > Please let me if you have any more comments, which can block it from being > merged. > > thanks, > greg I got confused because they were in the same email thread, thus I just saw my review comments in lore. I.e. I mixed v1 comments to v3. ERROR: Remove Gerrit Change-Id's before submitting upstream #11: Change-Id: Iee45ab1cbb2f4d898fbac12e9632de27f615bfba I'll remove it and apply. BR, Jarkko
From: Grzegorz Bernacki <bernacki@chromium.org> This patchset contains two patches from original patchset which have not yet be merged. As per original description: This patchset aims to add support for a platforms with cr50(tpm) i2c chip shared across two CPUs. We need to provide a mechanism, which will allow to synchronize accesses on a TPM-transaction boundaries. These two patches are modifying cr50 to use generic callbacks for locality management and then leverage this solution to apply i2c bus locking on a TPM-operation level. Changes from V1: - add dev_err() and return instead of WARN_ONCE() - correct returned value in tpm_cr50_i2c_probe() functions - I did not address Tim's suggestion to return 0 instead of loc in check and request locality, I would like to follow convention from tpm_tis_core.c file Changes from V2: - remove unnecesary locality checking Jan Dabros (2): char: tpm: cr50: Use generic request/relinquish locality ops char: tpm: cr50: Move i2c locking to request/relinquish locality ops drivers/char/tpm/tpm_tis_i2c_cr50.c | 114 ++++++++++++++++------------ 1 file changed, 66 insertions(+), 48 deletions(-)