diff mbox series

[v2,1/3] IMA: Update KBUILD_MODNAME for IMA files to ima

Message ID 20200211024755.5579-1-tusharsu@linux.microsoft.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/3] IMA: Update KBUILD_MODNAME for IMA files to ima | expand

Commit Message

Tushar Sugandhi Feb. 11, 2020, 2:47 a.m. UTC 
Log statements from ima_mok.c, ima_asymmetric_keys.c, and
ima_queue_keys.c are prefixed with the respective file names
and not with the string "ima". 

This change fixes the log statement prefix to be consistent with the rest
of the IMA files.

Signed-off-by: Tushar Sugandhi <tusharsu@linux.microsoft.com>
Reviewed-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
---
 security/integrity/ima/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Joe Perches Feb. 11, 2020, 3:09 a.m. UTC | #1 
On Mon, 2020-02-10 at 18:47 -0800, Tushar Sugandhi wrote:
> Log statements from ima_mok.c, ima_asymmetric_keys.c, and
> ima_queue_keys.c are prefixed with the respective file names
> and not with the string "ima". 

Series seems sensible, thanks Tushar.

Next time you might choose to use

	git format-patch --cover-letter

and write in the 0/n cover letter what the point
of the patch series is.

cheers and welcome... Joe
Lakshmi Ramasubramanian Feb. 11, 2020, 5:36 p.m. UTC | #2 
On 2/10/20 7:09 PM, Joe Perches wrote:

Hi Joe,

> Series seems sensible, thanks Tushar.
> 
> Next time you might choose to use
> 
> 	git format-patch --cover-letter
> 
> and write in the 0/n cover letter what the point
> of the patch series is.
> 

I was the one who suggested that we may not need a cover letter and 
instead provide the details in the patch description. We can include the 
cover letter in the next update.

thanks,
  -lakshmi
Tushar Sugandhi Feb. 11, 2020, 5:55 p.m. UTC | #3 
Hi Joe,

On 2020-02-11 9:36 a.m., Lakshmi Ramasubramanian wrote:
> On 2/10/20 7:09 PM, Joe Perches wrote:
> 
> Hi Joe,
> 
>> Series seems sensible, thanks Tushar.
>>
>> Next time you might choose to use
>>
>>     git format-patch --cover-letter
>>
>> and write in the 0/n cover letter what the point
>> of the patch series is.
>>
> 
> I was the one who suggested that we may not need a cover letter and 
> instead provide the details in the patch description. We can include the 
> cover letter in the next update.
> 
> thanks,
>   -lakshmi
> 
I will include the cover letter in the next update.

Thanks,
Tushar
diff mbox series

Patch

diff --git a/security/integrity/ima/Makefile b/security/integrity/ima/Makefile
index 064a256f8725..67dabca670e2 100644
--- a/security/integrity/ima/Makefile
+++ b/security/integrity/ima/Makefile
@@ -11,6 +11,6 @@  ima-y := ima_fs.o ima_queue.o ima_init.o ima_main.o ima_crypto.o ima_api.o \
 ima-$(CONFIG_IMA_APPRAISE) += ima_appraise.o
 ima-$(CONFIG_IMA_APPRAISE_MODSIG) += ima_modsig.o
 ima-$(CONFIG_HAVE_IMA_KEXEC) += ima_kexec.o
-obj-$(CONFIG_IMA_BLACKLIST_KEYRING) += ima_mok.o
-obj-$(CONFIG_IMA_MEASURE_ASYMMETRIC_KEYS) += ima_asymmetric_keys.o
-obj-$(CONFIG_IMA_QUEUE_EARLY_BOOT_KEYS) += ima_queue_keys.o
+ima-$(CONFIG_IMA_BLACKLIST_KEYRING) += ima_mok.o
+ima-$(CONFIG_IMA_MEASURE_ASYMMETRIC_KEYS) += ima_asymmetric_keys.o
+ima-$(CONFIG_IMA_QUEUE_EARLY_BOOT_KEYS) += ima_queue_keys.o