From patchwork Thu May 14 22:11:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Casey Schaufler X-Patchwork-Id: 11549997 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5563159D for ; Thu, 14 May 2020 22:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3938420709 for ; Thu, 14 May 2020 22:23:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b="YR4l6qCb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728475AbgENWX7 (ORCPT ); Thu, 14 May 2020 18:23:59 -0400 Received: from sonic307-16.consmr.mail.ne1.yahoo.com ([66.163.190.39]:45506 "EHLO sonic307-16.consmr.mail.ne1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728315AbgENWX6 (ORCPT ); Thu, 14 May 2020 18:23:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1589495037; bh=SC4UkTE2oZCdHyHjqC+B3gY4czDR5RheIwvw1ergrrQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject; b=YR4l6qCbo49XaxX+CrdFMJe9kzmq8rxmc3mjlhrv0JXt3Zs+N+KVpxq4ZCmwSUO8CyFTizH2/xhv309iER18Bpb7IqNI7QH54FEelnYWBr8GvjD0fQHyHeoTl9EuGRqYETCC8dYakCuZqX/tl/CYGrQ2KnvgxTgfJ0kdlXt8JapOtgUdwpi0d9sMMwAChf3QqRObSIfH+7BC8KzRWE3CDacEv4akqegUKBV+OEEAdNGPM5CCZn+WEw0FWjNttJ3aSrF0vmUGTk1f4A2OleSMCBDhWQsMs6jZAwloa71mkOfjpZ9pS6eOdgyUrd4ndgDxOJmBz7Zi3fs/r2viwzHM+w== X-YMail-OSG: WBDqlhQVM1mQ8rEkFPGjDLHmIBtFU4vaVJV9SY7p3RN0axg4wK1fOgkAvg7c7d6 liM8ka3mDl2TAUjKnn3FQpSjEG93P7DrmRQAkNxjW87mtgxcmt3Fys.yvRv42SaWtMgkNdIZ5iZQ ds7Yyvs91Flk3C1N8hGU7O4bSVl9Q46_YC01DIlDB6khPnYW6I2c8RjY7GZMETTyqBq4cF3q3ZWu gJQ9aLfMoV9GR3Zpad7op3RmurDem3_oO7CUht7f8pKFHHd5_EDI6AQP.DObF_Ro08o99_AT6Vzt OaHr6Q5ky4SybvHOq1kphc2dLwR7zyAXut9rPUQ37N_jqWVMaMfKovUwiTlFDQmpFsneH59itU2Z Iu9c3WE2oVnIjb8.3_gF0b34Sy6UpOXXny.JZHsYa0dM2gB9Vzb0wx7dWOTY6vGLkUKDFLJuCs8q HDf8N_rLwCD.yay.PwfsxM78fIUZBRLssCDk0Ma6uGrJK5ysxdUFoSQEmNETwn0Vl8Gvf.h3RhMG fk0HgUSqjErUdhEq5TRm_.0BhNd1cOfwcWs_xbNoCEBcehTvmWCQUJEEzm8xdjd5dO7EvuemjNSS wapnp1CvtoNSYSN6W7UiI4mMyhANUZEgiNm2IespXmYgkf8J2E3Ljq_nZAiQeDVN8IliagSSIH9C 177hU_yeOD5ejc0XcPPm.unUPnX.leV8tDbzwIjYVwZXJvhEcm2QB2_OXgxZzdz_z2VFf3oGyepk Imc9EVTHoRapThLjGO37EQOq4Sm5Thmp9_sLaXzDhpM0llqn0_PgPCHTA1McsRm1UXGSo2y2xDKJ mPKHMDrYj0WCpV5M0ndHIw8Noc8gDaf3HCGaPYGUqKIQfgUMfGkrU1Fd64TVugQKwb78TCfMtcoe G444t.qAtGZIv1gWOlJPGTG8Y7rCOhIjLZnmWb8.LaHyJd9qxJkMl2DQG9i0wPJ3xEhjvERnLnmU copH2vggYObexFjmQfcw6.luM4aPGXv4o3gVR_aBXGhWAmEzhOUXv_PNgtZx4F30OoJg6MjJUx2G U6ZGPk_2e6FwVM1bNzZd4UeWwId.mTmhjInptX48lLrRNUpGRRQ1jZ6GeRjXH2yH_qLlhARzZEiM 10kb7MoHOW5casonQF0ghCIcKjBc7s4F3VxQ0dbyFWCDUVQoJJrtHmNBmX9LiApPo05CuDL6A9u4 tngCYn6jUslreWMl53Cph5hIxMJT9HFzM1ZVvHE1s.u2mDZISMXxRnP5EeXnnPLi1V44mOcGbG0L uFltAPn.8qR5IuWjt32PZRfODNZg_E1Kq5kR8cILVi4L6cLJOFpah4J5BGlDiRGZatHnl6b4qvNP k6mCVLbch6kEibG4kW0vkudjQCd0xtPEJzThTXs_peRbrLrPSwA1BDi2WhmPPvqNKQUyfc5s71XW lHqR8siNGKqn5IgBJ99vHeclmoKIOsKBn27YfMhmZsHtR..M.To0tE7nmUIkthw-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Thu, 14 May 2020 22:23:57 +0000 Received: by smtp426.mail.ne1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID c150985a23791c683836a61394b2bda0; Thu, 14 May 2020 22:23:53 +0000 (UTC) From: Casey Schaufler To: casey.schaufler@intel.com, jmorris@namei.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Cc: casey@schaufler-ca.com, keescook@chromium.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, paul@paul-moore.com, sds@tycho.nsa.gov, linux-audit@redhat.com, linux-integrity@vger.kernel.org Subject: [PATCH v17 11/23] LSM: Use lsmblob in security_cred_getsecid Date: Thu, 14 May 2020 15:11:30 -0700 Message-Id: <20200514221142.11857-12-casey@schaufler-ca.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200514221142.11857-1-casey@schaufler-ca.com> References: <20200514221142.11857-1-casey@schaufler-ca.com> MIME-Version: 1.0 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Change the security_cred_getsecid() interface to fill in a lsmblob instead of a u32 secid. The associated data elements in the audit sub-system are changed from a secid to a lsmblob to accommodate multiple possible LSM audit users. Reviewed-by: Kees Cook Reviewed-by: John Johansen Acked-by: Stephen Smalley Acked-by: Paul Moore Signed-off-by: Casey Schaufler cc: linux-integrity@vger.kernel.org --- include/linux/security.h | 2 +- kernel/audit.c | 25 +++++++---------------- kernel/audit.h | 5 +++-- kernel/auditsc.c | 33 +++++++++++-------------------- security/integrity/ima/ima_main.c | 8 ++++---- security/security.c | 12 ++++++++--- 6 files changed, 36 insertions(+), 49 deletions(-) diff --git a/include/linux/security.h b/include/linux/security.h index c46da9c03162..3c690f36ca0d 100644 --- a/include/linux/security.h +++ b/include/linux/security.h @@ -458,7 +458,7 @@ int security_cred_alloc_blank(struct cred *cred, gfp_t gfp); void security_cred_free(struct cred *cred); int security_prepare_creds(struct cred *new, const struct cred *old, gfp_t gfp); void security_transfer_creds(struct cred *new, const struct cred *old); -void security_cred_getsecid(const struct cred *c, u32 *secid); +void security_cred_getsecid(const struct cred *c, struct lsmblob *blob); int security_kernel_act_as(struct cred *new, struct lsmblob *blob); int security_kernel_create_files_as(struct cred *new, struct inode *inode); int security_kernel_module_request(char *kmod_name); diff --git a/kernel/audit.c b/kernel/audit.c index 67bb78aca0cc..1901ed145dd3 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -125,7 +125,7 @@ static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME; /* The identity of the user shutting down the audit system. */ kuid_t audit_sig_uid = INVALID_UID; pid_t audit_sig_pid = -1; -u32 audit_sig_sid = 0; +struct lsmblob audit_sig_lsm; /* Records can be lost in several ways: 0) [suppressed in audit_alloc] @@ -1422,29 +1422,21 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh) } case AUDIT_SIGNAL_INFO: len = 0; - if (audit_sig_sid) { - struct lsmblob blob; - - /* - * lsmblob_init sets all values in the lsmblob - * to audit_sig_sid. This is temporary until - * audit_sig_sid is converted to a lsmblob, which - * happens later in this patch set. - */ - lsmblob_init(&blob, audit_sig_sid); - err = security_secid_to_secctx(&blob, &ctx, &len); + if (lsmblob_is_set(&audit_sig_lsm)) { + err = security_secid_to_secctx(&audit_sig_lsm, &ctx, + &len); if (err) return err; } sig_data = kmalloc(sizeof(*sig_data) + len, GFP_KERNEL); if (!sig_data) { - if (audit_sig_sid) + if (lsmblob_is_set(&audit_sig_lsm)) security_release_secctx(ctx, len); return -ENOMEM; } sig_data->uid = from_kuid(&init_user_ns, audit_sig_uid); sig_data->pid = audit_sig_pid; - if (audit_sig_sid) { + if (lsmblob_is_set(&audit_sig_lsm)) { memcpy(sig_data->ctx, ctx, len); security_release_secctx(ctx, len); } @@ -2288,7 +2280,6 @@ int audit_set_loginuid(kuid_t loginuid) int audit_signal_info(int sig, struct task_struct *t) { kuid_t uid = current_uid(), auid; - struct lsmblob blob; if (auditd_test_task(t) && (sig == SIGTERM || sig == SIGHUP || @@ -2299,9 +2290,7 @@ int audit_signal_info(int sig, struct task_struct *t) audit_sig_uid = auid; else audit_sig_uid = uid; - security_task_getsecid(current, &blob); - /* scaffolding until audit_sig_sid is converted */ - audit_sig_sid = blob.secid[0]; + security_task_getsecid(current, &audit_sig_lsm); } return audit_signal_info_syscall(t); diff --git a/kernel/audit.h b/kernel/audit.h index 2eed4d231624..74be988cda01 100644 --- a/kernel/audit.h +++ b/kernel/audit.h @@ -9,6 +9,7 @@ #include #include #include +#include #include #include @@ -134,7 +135,7 @@ struct audit_context { kuid_t target_auid; kuid_t target_uid; unsigned int target_sessionid; - u32 target_sid; + struct lsmblob target_lsm; char target_comm[TASK_COMM_LEN]; struct audit_tree_refs *trees, *first_trees; @@ -337,7 +338,7 @@ extern char *audit_unpack_string(void **bufp, size_t *remain, size_t len); extern pid_t audit_sig_pid; extern kuid_t audit_sig_uid; -extern u32 audit_sig_sid; +extern struct lsmblob audit_sig_lsm; extern int audit_filter(int msgtype, unsigned int listtype); diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 3201f0997a5d..c1e19ffaef66 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c @@ -112,7 +112,7 @@ struct audit_aux_data_pids { kuid_t target_auid[AUDIT_AUX_PIDS]; kuid_t target_uid[AUDIT_AUX_PIDS]; unsigned int target_sessionid[AUDIT_AUX_PIDS]; - u32 target_sid[AUDIT_AUX_PIDS]; + struct lsmblob target_lsm[AUDIT_AUX_PIDS]; char target_comm[AUDIT_AUX_PIDS][TASK_COMM_LEN]; int pid_count; }; @@ -964,14 +964,14 @@ static inline void audit_free_context(struct audit_context *context) } static int audit_log_pid_context(struct audit_context *context, pid_t pid, - kuid_t auid, kuid_t uid, unsigned int sessionid, - u32 sid, char *comm) + kuid_t auid, kuid_t uid, + unsigned int sessionid, + struct lsmblob *blob, char *comm) { struct audit_buffer *ab; char *ctx = NULL; u32 len; int rc = 0; - struct lsmblob blob; ab = audit_log_start(context, GFP_KERNEL, AUDIT_OBJ_PID); if (!ab) @@ -980,9 +980,8 @@ static int audit_log_pid_context(struct audit_context *context, pid_t pid, audit_log_format(ab, "opid=%d oauid=%d ouid=%d oses=%d", pid, from_kuid(&init_user_ns, auid), from_kuid(&init_user_ns, uid), sessionid); - if (sid) { - lsmblob_init(&blob, sid); - if (security_secid_to_secctx(&blob, &ctx, &len)) { + if (lsmblob_is_set(blob)) { + if (security_secid_to_secctx(blob, &ctx, &len)) { audit_log_format(ab, " obj=(none)"); rc = 1; } else { @@ -1550,7 +1549,7 @@ static void audit_log_exit(void) axs->target_auid[i], axs->target_uid[i], axs->target_sessionid[i], - axs->target_sid[i], + &axs->target_lsm[i], axs->target_comm[i])) call_panic = 1; } @@ -1559,7 +1558,7 @@ static void audit_log_exit(void) audit_log_pid_context(context, context->target_pid, context->target_auid, context->target_uid, context->target_sessionid, - context->target_sid, context->target_comm)) + &context->target_lsm, context->target_comm)) call_panic = 1; if (context->pwd.dentry && context->pwd.mnt) { @@ -1737,7 +1736,7 @@ void __audit_syscall_exit(int success, long return_code) context->aux = NULL; context->aux_pids = NULL; context->target_pid = 0; - context->target_sid = 0; + lsmblob_init(&context->target_lsm, 0); context->sockaddr_len = 0; context->type = 0; context->fds[0] = -1; @@ -2390,15 +2389,12 @@ int __audit_sockaddr(int len, void *a) void __audit_ptrace(struct task_struct *t) { struct audit_context *context = audit_context(); - struct lsmblob blob; context->target_pid = task_tgid_nr(t); context->target_auid = audit_get_loginuid(t); context->target_uid = task_uid(t); context->target_sessionid = audit_get_sessionid(t); - security_task_getsecid(t, &blob); - /* scaffolding - until target_sid is converted */ - context->target_sid = blob.secid[0]; + security_task_getsecid(t, &context->target_lsm); memcpy(context->target_comm, t->comm, TASK_COMM_LEN); } @@ -2414,7 +2410,6 @@ int audit_signal_info_syscall(struct task_struct *t) struct audit_aux_data_pids *axp; struct audit_context *ctx = audit_context(); kuid_t t_uid = task_uid(t); - struct lsmblob blob; if (!audit_signals || audit_dummy_context()) return 0; @@ -2426,9 +2421,7 @@ int audit_signal_info_syscall(struct task_struct *t) ctx->target_auid = audit_get_loginuid(t); ctx->target_uid = t_uid; ctx->target_sessionid = audit_get_sessionid(t); - security_task_getsecid(t, &blob); - /* scaffolding until target_sid is converted */ - ctx->target_sid = blob.secid[0]; + security_task_getsecid(t, &ctx->target_lsm); memcpy(ctx->target_comm, t->comm, TASK_COMM_LEN); return 0; } @@ -2449,9 +2442,7 @@ int audit_signal_info_syscall(struct task_struct *t) axp->target_auid[axp->pid_count] = audit_get_loginuid(t); axp->target_uid[axp->pid_count] = t_uid; axp->target_sessionid[axp->pid_count] = audit_get_sessionid(t); - security_task_getsecid(t, &blob); - /* scaffolding until target_sid is converted */ - axp->target_sid[axp->pid_count] = blob.secid[0]; + security_task_getsecid(t, &axp->target_lsm[axp->pid_count]); memcpy(axp->target_comm[axp->pid_count], t->comm, TASK_COMM_LEN); axp->pid_count++; diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c index 9701f2f99808..2dec956b6852 100644 --- a/security/integrity/ima/ima_main.c +++ b/security/integrity/ima/ima_main.c @@ -410,7 +410,6 @@ int ima_file_mmap(struct file *file, unsigned long prot) int ima_bprm_check(struct linux_binprm *bprm) { int ret; - u32 secid; struct lsmblob blob; security_task_getsecid(current, &blob); @@ -420,9 +419,10 @@ int ima_bprm_check(struct linux_binprm *bprm) if (ret) return ret; - security_cred_getsecid(bprm->cred, &secid); - return process_measurement(bprm->file, bprm->cred, secid, NULL, 0, - MAY_EXEC, CREDS_CHECK); + security_cred_getsecid(bprm->cred, &blob); + /* scaffolding until process_measurement changes */ + return process_measurement(bprm->file, bprm->cred, blob.secid[0], + NULL, 0, MAY_EXEC, CREDS_CHECK); } /** diff --git a/security/security.c b/security/security.c index 1e8456a6fe3c..ed33ee97afe4 100644 --- a/security/security.c +++ b/security/security.c @@ -1666,10 +1666,16 @@ void security_transfer_creds(struct cred *new, const struct cred *old) call_void_hook(cred_transfer, new, old); } -void security_cred_getsecid(const struct cred *c, u32 *secid) +void security_cred_getsecid(const struct cred *c, struct lsmblob *blob) { - *secid = 0; - call_void_hook(cred_getsecid, c, secid); + struct security_hook_list *hp; + + lsmblob_init(blob, 0); + hlist_for_each_entry(hp, &security_hook_heads.cred_getsecid, list) { + if (WARN_ON(hp->lsmid->slot < 0 || hp->lsmid->slot >= lsm_slot)) + continue; + hp->hook.cred_getsecid(c, &blob->secid[hp->lsmid->slot]); + } } EXPORT_SYMBOL(security_cred_getsecid);