From patchwork Fri Nov 10 20:21:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Berger X-Patchwork-Id: 13452759 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B23B3B7A7 for ; Fri, 10 Nov 2023 20:21:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="mkDQG6MF" Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A4BF421C for ; Fri, 10 Nov 2023 12:21:49 -0800 (PST) Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AAKAf2k006022; Fri, 10 Nov 2023 20:21:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=vQfAEgIRoiPqnmXd/Ylv1IuZwVkWtJbozih+pi6ryTM=; b=mkDQG6MFDi/Cw5uZ8yPxOeuVY4sHtXe7ZL0lgkmPuivfnXUuq4paNG68wKucwCBTymlx auxFzbds/qXFKqwVP7A4f0n9GEKKOuEwtvY3PeETYyY8OWrK5jzKCpaf0wHgzc8KkYcU PXyRDaxMNDHppaNzRYKGO62bxmnCvt5MxCLXmwzZJ5g93b/8PfLqvULiSlVaeK7RGa6u nFiMOx0YSTz1SiwT2cMwlRXYLjGyyzLtcuTgFVlEwluOCQrpMHldhIkSn+cS7rkcCnta UAQhxxJzqXz5nax5GvwDN+GSMzZ/VwrUqFNQ27lQIL++7f5ROPrG+I+yaPP6nA7ZLmsz PA== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u9uawrcj0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Nov 2023 20:21:42 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AAJKNHZ003488; Fri, 10 Nov 2023 20:21:42 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3u7w22dcqe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Nov 2023 20:21:42 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AAKLfYK8651296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 Nov 2023 20:21:41 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A31365805D; Fri, 10 Nov 2023 20:21:41 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 51B9F58059; Fri, 10 Nov 2023 20:21:41 +0000 (GMT) Received: from sbct-2.pok.ibm.com?044watson.ibm.com (unknown [9.47.158.152]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 10 Nov 2023 20:21:41 +0000 (GMT) From: Stefan Berger To: linux-integrity@vger.kernel.org Cc: zohar@linux.ibm.com, roberto.sassu@huaweicloud.com, Stefan Berger Subject: [ima-evm-utils PATCH 05/14] tests: Address issues raised by shellcheck SC2317 Date: Fri, 10 Nov 2023 15:21:28 -0500 Message-ID: <20231110202137.3978820-6-stefanb@linux.ibm.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231110202137.3978820-1-stefanb@linux.ibm.com> References: <20231110202137.3978820-1-stefanb@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-integrity@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: rtpTm-BWSMkE-TSouJWK6VS2x62TiJyc X-Proofpoint-ORIG-GUID: rtpTm-BWSMkE-TSouJWK6VS2x62TiJyc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-10_18,2023-11-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311100170 Address issues raised by shellcheck SC2317: "Command appears to be unreachable. Check usage (or ignore if invoked indirectly)." Disable this check in fsverity.test since functions are called indirectly there. Signed-off-by: Stefan Berger --- tests/Makefile.am | 2 +- tests/fsverity.test | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index babfa7a..d6d0068 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -26,7 +26,7 @@ clean-local: distclean: distclean-keys shellcheck: - shellcheck -i SC2086,SC2181,SC2046,SC2320 \ + shellcheck -i SC2086,SC2181,SC2046,SC2320,SC2317 \ functions.sh gen-keys.sh install-fsverity.sh \ install-mount-idmapped.sh install-openssl3.sh \ install-swtpm.sh install-tss.sh softhsm_setup \ diff --git a/tests/fsverity.test b/tests/fsverity.test index 11925cb..e924162 100755 --- a/tests/fsverity.test +++ b/tests/fsverity.test @@ -29,6 +29,8 @@ # since the policy rules are walked sequentially, the system's IMA # custom policy rules might take precedence. +# shellcheck disable=SC2317 + cd "$(dirname "$0")" || exit 1 PATH=../src:../fsverity-utils:$PATH source ./functions.sh