Message ID | 20231128181613.1159958-10-stefanb@linux.ibm.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Enable shellcheck and fix some issues | expand |
diff --git a/tests/Makefile.am b/tests/Makefile.am index df1fbff..9092c43 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -26,7 +26,9 @@ clean-local: distclean: distclean-keys shellcheck: - shellcheck -i SC2086,SC2181,SC2046,SC2320,SC2317,SC2034,SC2164,SC2166 \ + shellcheck \ + -i SC2086,SC2181,SC2046,SC2320,SC2317,SC2034,SC2164,SC2166 \ + -i SC2294 \ functions.sh gen-keys.sh install-fsverity.sh \ install-mount-idmapped.sh install-openssl3.sh \ install-swtpm.sh install-tss.sh softhsm_setup \ diff --git a/tests/gen-keys.sh b/tests/gen-keys.sh index 0b03ba4..c3d5a20 100755 --- a/tests/gen-keys.sh +++ b/tests/gen-keys.sh @@ -21,7 +21,7 @@ type openssl log() { echo >&2 - "$*" - eval "$@" + eval "$*" } if [ "$1" = clean ]; then
Address issues raised by shellcheck SC2294: "eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string)." Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> --- tests/Makefile.am | 4 +++- tests/gen-keys.sh | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-)