mbox series

[0/7] modpost: fix modpost errors for m68k-uclinux-gcc

Message ID 20231101150404.754108-1-masahiroy@kernel.org (mailing list archive)
Headers show
Series modpost: fix modpost errors for m68k-uclinux-gcc | expand

Message

Masahiro Yamada Nov. 1, 2023, 3:03 p.m. UTC 
Greg Ungerer reports building with m68k-uclinux-gcc toolchain is broken:
https://lore.kernel.org/linux-kbuild/CAK7LNASQ_W5Yva5a4Xx8E2EYi-tN7x3OHgMFhK+93W+BiX1=9Q@mail.gmail.com/T/#m6ff0364f9ca8483c9f6d162619e5005833d1e887

Usually, we do not need to search for export symbols in the .symtab
section, but m68k-uclinux-gcc seems to be an exceptional case.
I do not know what makes it different from other toolchains.
Also, I do not know there exist other toolchains that work like that.

This series extends the symsearch feature in case we need to explicitly
search for export symbols.

Then, the last patch fixes the issue.

This series should be applicable for linux-next.

This series is too late for the current merge window, but I'd like
to fix the issue somehow by the next merge window.



Masahiro Yamada (7):
  modpost: move sym_name() to modpost.h
  modpost: add const qualifier to syminfo table
  modpost: add table_size local variable to symsearch_find_nearest()
  modpost: introduce a filtering feature to symsearch
  modpost: prefer global symbols in symsearch_find_nearest()
  modpost: add symsearch_find_with_name() helper function
  modpost: look up the correct symbol in check_export_symbol()

 scripts/mod/modpost.c   |  39 ++++----
 scripts/mod/modpost.h   |  12 +++
 scripts/mod/symsearch.c | 205 ++++++++++++++++++++++++++++------------
 3 files changed, 180 insertions(+), 76 deletions(-)

Comments

Greg Ungerer Nov. 2, 2023, 3 p.m. UTC | #1 
Hi Masahiro,

On 2/11/23 01:03, Masahiro Yamada wrote:
> Greg Ungerer reports building with m68k-uclinux-gcc toolchain is broken:
> https://lore.kernel.org/linux-kbuild/CAK7LNASQ_W5Yva5a4Xx8E2EYi-tN7x3OHgMFhK+93W+BiX1=9Q@mail.gmail.com/T/#m6ff0364f9ca8483c9f6d162619e5005833d1e887
> 
> Usually, we do not need to search for export symbols in the .symtab
> section, but m68k-uclinux-gcc seems to be an exceptional case.
> I do not know what makes it different from other toolchains.
> Also, I do not know there exist other toolchains that work like that.
> 
> This series extends the symsearch feature in case we need to explicitly
> search for export symbols.
> 
> Then, the last patch fixes the issue.
> 
> This series should be applicable for linux-next.
> 
> This series is too late for the current merge window, but I'd like
> to fix the issue somehow by the next merge window.

Thanks for looking into this.
I can confirm this series fixes it for me (using linux-next).


     Tested-by: Greg Ungerer <gerg@kernel.org>

Regards
Greg


> 
> 
> Masahiro Yamada (7):
>    modpost: move sym_name() to modpost.h
>    modpost: add const qualifier to syminfo table
>    modpost: add table_size local variable to symsearch_find_nearest()
>    modpost: introduce a filtering feature to symsearch
>    modpost: prefer global symbols in symsearch_find_nearest()
>    modpost: add symsearch_find_with_name() helper function
>    modpost: look up the correct symbol in check_export_symbol()
> 
>   scripts/mod/modpost.c   |  39 ++++----
>   scripts/mod/modpost.h   |  12 +++
>   scripts/mod/symsearch.c | 205 ++++++++++++++++++++++++++++------------
>   3 files changed, 180 insertions(+), 76 deletions(-)
>