mbox series

[0/4] Enable more warnings by default

Message ID 20240404151713.3493098-1-arnd@kernel.org (mailing list archive)
Headers show
Series Enable more warnings by default | expand

Message

Arnd Bergmann April 4, 2024, 3:16 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de>

I think these can now get merged into linux-next. I reordered
these slightly from my previous submission to skip the
-Wcast-function-type-strict warnings but instead include the
-Wformat-truncation enablement, based on what got merged so
far.

We are still missing the "kallsyms: rework symbol lookup return codes"
and "firmware: dmi-id: add a release callback function" patches, but
I expect them to get merged through the respective trees soon.

There is still an open question about the order of patches in the
coming merge window: if some of the other patches are also queued
for 6.10 rather than 6.9, this series has to come after those to
avoid regressions. Maybe they can go into some kind of 'kbuild/late'
branch that gets merged in the second half of the merge window?

     Arnd

Link: https://lore.kernel.org/lkml/20240326223825.4084412-1-arnd@kernel.org/ 
Link: https://lore.kernel.org/lkml/20240326144741.3094687-1-arnd@kernel.org/

Arnd Bergmann (4):
  kbuild: turn on -Wextra by default
  kbuild: remove redundant extra warning flags
  kbuild: turn on -Wrestrict by default
  kbuild: enable -Wformat-truncation on clang

 scripts/Makefile.extrawarn | 29 +++++++++++------------------
 1 file changed, 11 insertions(+), 18 deletions(-)

Comments

Justin Stitt April 8, 2024, 10 p.m. UTC | #1
Hi,

On Thu, Apr 04, 2024 at 05:16:53PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> I think these can now get merged into linux-next. I reordered
> these slightly from my previous submission to skip the
> -Wcast-function-type-strict warnings but instead include the
> -Wformat-truncation enablement, based on what got merged so
> far.
> 
> We are still missing the "kallsyms: rework symbol lookup return codes"
> and "firmware: dmi-id: add a release callback function" patches, but
> I expect them to get merged through the respective trees soon.
> 
> There is still an open question about the order of patches in the
> coming merge window: if some of the other patches are also queued
> for 6.10 rather than 6.9, this series has to come after those to
> avoid regressions. Maybe they can go into some kind of 'kbuild/late'
> branch that gets merged in the second half of the merge window?
> 
>      Arnd
> 
> Link: https://lore.kernel.org/lkml/20240326223825.4084412-1-arnd@kernel.org/ 
> Link: https://lore.kernel.org/lkml/20240326144741.3094687-1-arnd@kernel.org/
> 
> Arnd Bergmann (4):
>   kbuild: turn on -Wextra by default
>   kbuild: remove redundant extra warning flags
>   kbuild: turn on -Wrestrict by default
>   kbuild: enable -Wformat-truncation on clang
> 
>  scripts/Makefile.extrawarn | 29 +++++++++++------------------
>  1 file changed, 11 insertions(+), 18 deletions(-)
> 
> -- 
> 2.39.2
> 

No warnings for me on Clang-18 with this series applied :)

Is there some kbuild documentation somewhere that should be
updated/created to reflect which warnings the kernel has enabled by
default?

Reviewed-by: Justin Stitt <justinstitt@google.com>

Thanks
Justin