[v3,0/2] Makefile: rust-analyzer better error handling, documentation

Message

John Hubbard June 28, 2024, 12:43 a.m. UTC

Changes since v2:

1) Used wording suggested by Miguel Ojeda (thanks!) for the 
   documentation patch.

2) Added review, testing, ack tags.

Finn Behrens, thanks for your reviews, and please note that out of an
excess of caution, I've only applied your reviewed-by tag to patch 2/2.
For patch 1/2, the wording changed a lot after you reviewed it, so I
couldn't quite convince myself that the review was still fair to claim.


Changes since v1:

1) Thanks to Alice Ryhl for testing and reviewing v1. I had to drop both
   of those tags for this v2, because even though it is small, it's
   different enough to invalidate both, unfortunately.

2) Adopted Miguel Ojeda's suggestion of letting rust_is_available.sh
   report its results directly, thus improving the output, while also
   simplifying the patch.

3) As requested by Miguel, split out some new comment documentation
   for the rust-analyzer target into its own patch.

John Hubbard (2):
  Makefile: rust-analyzer target: better error handling
  Makefile: improve comment documentation for the rust-analyzer target

 Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


base-commit: 6d6444ba82053c716fb5ac83346202659023044e

Comments

Miguel Ojeda July 9, 2024, 8 a.m. UTC | #1

On Fri, Jun 28, 2024 at 2:44 AM John Hubbard <[e-mail]> wrote:
>
> Changes since v2:
>
> 1) Used wording suggested by Miguel Ojeda (thanks!) for the
>    documentation patch.
>
> 2) Added review, testing, ack tags.
>
> Finn Behrens, thanks for your reviews, and please note that out of an
> excess of caution, I've only applied your reviewed-by tag to patch 2/2.
> For patch 1/2, the wording changed a lot after you reviewed it, so I
> couldn't quite convince myself that the review was still fair to claim.

Applied to `rust-next` -- thanks!

[ Reworded title. - Miguel ]

Cheers,
Miguel