From patchwork Sat Nov 2 17:51:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Rong Xu X-Patchwork-Id: 13860209 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B35111A3BC8 for ; Sat, 2 Nov 2024 17:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730569881; cv=none; b=OnpGx+mfIzVos1U9mrICwHRuI9Xajacld1xitfKP8aANzid38xl2GPVA4mOcqE9lQBfvMPGYcuetL29zvXf92TcidIIVa5t9GGt4N8lQAcXdDOAItZr0aneVniZgUUnR2jo+LPE6w0igz+jrlMF8nGv1oCxjv5nwlS4H1eRtHH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730569881; c=relaxed/simple; bh=aUW9JznAoHRP5m+sOL5oiTVjH22QEwDwSgIwkEDpXME=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=CVyYI4KA9oQPWR3V9SBwUsPOYb7nMvX75NZ8NV3ffwGbYIFexBnK9TDBmZvHBEhQajuA4aQbLUUNiN5Km6SYK+LgV2bP0CM5jjsUROWG2D1FPcdvlFtck6T5r8xKG9fdgyDhJNTpkJeEKHT/4lQiX3FxNzh7IkMhRygUBOg9HeE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--xur.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=yxAlm73i; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--xur.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="yxAlm73i" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6e35a643200so59388747b3.0 for ; Sat, 02 Nov 2024 10:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730569879; x=1731174679; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id :mime-version:date:from:to:cc:subject:date:message-id:reply-to; bh=RbJ7KSfMBWz1Y0UhDUvFmeaQQsTHib5/3sACa+IaZFU=; b=yxAlm73i/vTHyrm9iMtUdk1SD2Dnl2mg3G6KdAeuIMpuoIiXA9PjsNidoNkwsd3iEw /DPN/xk0+R2KAR/yOw1/ReWrRkhocECcf1y5DAgXtZ+Dw/MiepSaLYjgRjzcRyYEayEV iE9RPNNpn+m80//k8u02cVK5/MrCQwx2gxHAmi2P/86yfiCoOVP8gyQ1bM1HbBXOKgYf bX061SPIK40Yu8v3gI0zI9wxhdtHq1SxNAK9nL4Flp0XF5JGbOSw21Ic2txwsgWepmRe xE91S9tucg49mxwtL/6d6Ilkd4HlBlZ0KFiEp9Hul2Z20nV4aKjk2vG1tWEBtnEP2VhA DsEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730569879; x=1731174679; h=content-transfer-encoding:cc:to:from:subject:message-id :mime-version:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RbJ7KSfMBWz1Y0UhDUvFmeaQQsTHib5/3sACa+IaZFU=; b=akVqunQ3KADln6EikOLan1lWJD/DiXspHOUoWNEsCjLUK/9EjVOf6K3ThB01XRw5rs jb18OUM87dS+i9wADdZpSbUTDWfqSrSg6tv4Gno8ePL/lKBohSQund3mJ50YWnn0NMeU gyJFe7+dSP9NII9VOR80QnEWcbgAgu1gqID/jTBiUaSkRpHNPqTfudg5HoZGVlj7aPp4 8DiwxYHBGYsboPYkgnqZOa2opGVP7YEHzBau50SvxsT5JV+zb5Hla5lb0wqgHJEHyT8g 7p6Ri/vcLnPaTB42I+8QYvytkQEB2oO3SUmA5rLY0L3dMa7sAFCoypkKyzTgxoQixry6 tJhw== X-Forwarded-Encrypted: i=1; AJvYcCV7wyjuSQKAExcDjui/6lxSJj4bMpbITlpn4zqYreSLUZggZiMSkqloW/mYO1bkkdBfr5MWt699wayR/24=@vger.kernel.org X-Gm-Message-State: AOJu0YxsMlqr1FSabkzFVVOidJ2WT6CBkzPOsp3HPSR26rNGBx6CnsJF iZz6KdECT64Wro8DurMZOP4ADUvHdjecuy94aPuQdzX0qc4miH+J6Ey55n0mKXrN+A== X-Google-Smtp-Source: AGHT+IGIX7Be0sda4aDq1i/eWbGnMfihQS+gBJFHc5SpY4pV5ZsGjNpmDFIx/uhV0MIP2FFyxcNjvx8= X-Received: from xur.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:2330]) (user=xur job=sendgmr) by 2002:a25:8241:0:b0:e29:7cfa:9fbc with SMTP id 3f1490d57ef6-e30e5b678ffmr6277276.11.1730569878563; Sat, 02 Nov 2024 10:51:18 -0700 (PDT) Date: Sat, 2 Nov 2024 10:51:07 -0700 Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog Message-ID: <20241102175115.1769468-1-xur@google.com> Subject: [PATCH v7 0/7] Add AutoFDO and Propeller support for Clang build From: Rong Xu To: Alice Ryhl , Andrew Morton , Arnd Bergmann , Bill Wendling , Borislav Petkov , Breno Leitao , Brian Gerst , Dave Hansen , David Li , Han Shen , Heiko Carstens , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Jonathan Corbet , Josh Poimboeuf , Juergen Gross , Justin Stitt , Kees Cook , Masahiro Yamada , "Mike Rapoport (IBM)" , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , "Paul E. McKenney" , Peter Zijlstra , Rong Xu , Sami Tolvanen , Thomas Gleixner , Wei Yang , workflows@vger.kernel.org, Miguel Ojeda , Maksim Panchenko , "David S. Miller" , Andreas Larsson , Yonghong Song , Yabin Cui , Krzysztof Pszeniczny , Sriraman Tallam , Stephane Eranian Cc: x86@kernel.org, linux-arch@vger.kernel.org, sparclinux@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Hi, This patch series is to integrate AutoFDO and Propeller support into the Linux kernel. AutoFDO is a profile-guided optimization technique that leverages hardware sampling to enhance binary performance. Unlike Instrumentation-based FDO (iFDO), AutoFDO offers a user-friendly and straightforward application process. While iFDO generally yields superior profile quality and performance, our findings reveal that AutoFDO achieves remarkable effectiveness, bringing performance close to iFDO for benchmark applications. Propeller is a profile-guided, post-link optimizer that improves the performance of large-scale applications compiled with LLVM. It operates by relinking the binary based on an additional round of runtime profiles, enabling precise optimizations that are not possible at compile time. Similar to AutoFDO, Propeller too utilizes hardware sampling to collect profiles and apply post-link optimizations to improve the benchmark’s performance over and above AutoFDO. Our empirical data demonstrates significant performance improvements with AutoFDO and Propeller, up to 10% on microbenchmarks and up to 5% on large warehouse-scale benchmarks. This makes a strong case for their inclusion as supported features in the upstream kernel. Background A significant fraction of fleet processing cycles (excluding idle time) from data center workloads are attributable to the kernel. Ware-house scale workloads maximize performance by optimizing the production kernel using iFDO (a.k.a instrumented PGO, Profile Guided Optimization). iFDO can significantly enhance application performance but its use within the kernel has raised concerns. AutoFDO is a variant of FDO that uses the hardware’s Performance Monitoring Unit (PMU) to collect profiling data. While AutoFDO typically yields smaller performance gains than iFDO, it presents unique benefits for optimizing kernels. AutoFDO eliminates the need for instrumented kernels, allowing a single optimized kernel to serve both execution and profile collection. It also minimizes slowdown during profile collection, potentially yielding higher-fidelity profiling, especially for time-sensitive code, compared to iFDO. Additionally, AutoFDO profiles can be obtained from production environments via the hardware’s PMU whereas iFDO profiles require carefully curated load tests that are representative of real-world traffic. AutoFDO facilitates profile collection across diverse targets. Preliminary studies indicate significant variation in kernel hot spots within Google’s infrastructure, suggesting potential performance gains through target-specific kernel customization. Furthermore, other advanced compiler optimization techniques, including ThinLTO and Propeller can be stacked on top of AutoFDO, similar to iFDO. ThinLTO achieves better runtime performance through whole-program analysis and cross module optimizations. The main difference between traditional LTO and ThinLTO is that the latter is scalable in time and memory. This patch series adds AutoFDO and Propeller support to the kernel. The actual solution comes in six parts: [P 1] Add the build support for using AutoFDO in Clang Add the basic support for AutoFDO build and provide the instructions for using AutoFDO. [P 2] Fix objtool for bogus warnings when -ffunction-sections is enabled [P 3] Adjust symbol ordering in text output sections [P 4] Add markers for text_unlikely and text_hot sections [P 5] Enable –ffunction-sections for the AutoFDO build [P 6] Enable Machine Function Split (MFS) optimization for AutoFDO [P 7] Add Propeller configuration to the kernel build Patch 1 provides basic AutoFDO build support. Patches 2 to 6 further enhance the performance of AutoFDO builds and are functionally dependent on Patch 1. Patch 7 enables support for Propeller and is dependent on patch 2 to patch 4. Caveats AutoFDO is compatible with both GCC and Clang, but the patches in this series are exclusively applicable to LLVM 17 or newer for AutoFDO and LLVM 19 or newer for Propeller. For profile conversion, two different tools could be used, llvm_profgen or create_llvm_prof. llvm_profgen needs to be the LLVM 19 or newer, or just the LLVM trunk. Alternatively, create_llvm_prof v0.30.1 or newer can be used instead of llvm-profgen. Additionally, the build is only supported on x86 platforms equipped with PMU capabilities, such as LBR on Intel machines. More specifically: * Intel platforms: works on every platform that supports LBR; we have tested on Skylake. * AMD platforms: tested on AMD Zen3 with the BRS feature. The kernel needs to be configured with “CONFIG_PERF_EVENTS_AMD_BRS=y", To check, use $ cat /proc/cpuinfo | grep “ brs” For the AMD Zen4, AMD LBRV2 is supported, but we suspect a bug with AMD LBRv2 implementation in Genoa which blocks the usage. For ARM, we plan to send patches for SPE-based Propeller when AutoFDO for Arm is ready. Experiments and Results Experiments were conducted to compare the performance of AutoFDO-optimized kernel images (version 6.9.x) against default builds.. The evaluation encompassed both open source microbenchmarks and real-world production services from Google and Meta. The selected microbenchmarks included Neper, a network subsystem benchmark, and UnixBench which is a comprehensive suite for assessing various kernel operations. For Neper, AutoFDO optimization resulted in a 6.1% increase in throughput and a 10.6% reduction in latency. UnixBench saw a 2.2% improvement in its index score under low system load and a 2.6% improvement under high system load. For further details on the improvements observed in Google and Meta's production services, please refer to the LLVM discourse post: https://discourse.llvm.org/t/optimizing-the-linux-kernel-with-autofdo-including-thinlto-and-propeller/79108 Thanks, Rong Xu and Han Shen --- Change-Logs in V2: Rebased to commit e32cde8d2bd7 ("Merge tag 'sched_ext-for-6.12-rc1-fixes-1' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext") 1. [P 0]: moved the Propeller description to the top (Peter Zijlstra) 2. [P 1]: (1) Makefile: fixed file order (Masahiro Yamada) (2) scripts/Makefile.lib: used is-kernel-object to exclude files (Masahiro Yamada) (3) scripts/Makefile.autofdo: improved the code (Masahiro Yamada) (4) scripts/Makefile.autofdo: handled when DEBUG_INFO disabled (Nick Desaulniers) 3. [P 2]: tools/objtool/elf.c: updated the comments (Peter Zijlstra) 4. [P 3]: include/asm-generic/vmlinux.lds.h: (1) explicit set cold text function aligned (Peter Zijlstra and Peter Anvin) (2) set hot-text page aligned 5. [P 6]: (1) include/asm-generic/vmlinux.lds.h: made Propeller not depending on AutoFDO (2) Makefile: fixed file order (Masahiro Yamada) (3) scripts/Makefile.lib: used is-kernel-object to exclude files (Masahiro Yamada). This removed the change in arch/x86/platform/efi/Makefile, drivers/firmware/efi/libstub/Makefile, and arch/x86/boot/compressed/Makefile. And this also addressed the comment from Arnd Bergmann regarding arch/x86/purgatory/Makefile (4) scripts/Makefile.propeller: improved the code (Masahiro Yamada) Change-Logs in V3: Rebased to commit eb952c47d154 ("Merge tag 'for-6.12-rc2-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux") Integrated the following changes suggested by Mike Rapoport. 1. [P 1]: autofdo.rst: removed code-block directives and used "::" 2. [P 6]: propeller.rst: removed code-block directives and use "::" Change-Logs in V4: 1. [P 1]: autofdo.rst: fixed a typo for create_llvm_prof command. Change-Logs in V5: Added "Tested-by: Yonghong Song " to all patches. Integrated the following changes suggested by Masahiro Yamada. 1. [P 0]: (1) moved ARM related remark from patch 6 to here 2. [P 1]: (1) autofdo.rst: improved the documentation (2) scripts/Makefile.autofdo: improved comments and used ifdef instead of ifeq 3. [P 3]: Make the layout change unconditionally 4. [P 4]: Split the patch into two: this patch only added the markers, and the AutoFDO change went to new P_5 5. [P 7]: (1) propeller.rst: improved the documentation (2) scripts/Makefile.propeller: improved comments and used ifdef instead of ifeq (3) arch/Kconfig: made Propeller build independent of AutoFDO build (4) moved ARM related remarks to the cover letter Change-Logs in V6: Added "Tested-by: Yabin Cui " to AutoFDO patches. 1. [P 3]: (1) changed patch title (2) fixed the build error in sparc64 Change-Logs in V7: Rebased to commit 11066801dd4b7 (Merge tag 'linux_kselftest-fixes-6.12-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest) Added "Tested-by: Nathan Chancellor " to [P 1] to [P 7] Added "Reviewed-by: Kees Cook " to [P 1] to [P 7] Added "Acked-by: Josh Poimboeuf " to [P 2] Integrated the following changes suggested by Masahiro Yamada. 1. [P 1]: autofdo.rst: fixed format 2. [P 3]: commit message: described the rationale behind the new layout Rong Xu (7): Add AutoFDO support for Clang build objtool: Fix unreachable instruction warnings for weak functions Adjust symbol ordering in text output section Add markers for text_unlikely and text_hot sections AutoFDO: Enable -ffunction-sections for the AutoFDO build AutoFDO: Enable machine function split optimization for AutoFDO Add Propeller configuration for kernel build Documentation/dev-tools/autofdo.rst | 168 ++++++++++++++++++++++++++ Documentation/dev-tools/index.rst | 2 + Documentation/dev-tools/propeller.rst | 162 +++++++++++++++++++++++++ MAINTAINERS | 14 +++ Makefile | 2 + arch/Kconfig | 39 ++++++ arch/sparc/kernel/vmlinux.lds.S | 5 + arch/x86/Kconfig | 2 + arch/x86/kernel/vmlinux.lds.S | 4 + include/asm-generic/vmlinux.lds.h | 49 ++++++-- scripts/Makefile.autofdo | 24 ++++ scripts/Makefile.lib | 20 +++ scripts/Makefile.propeller | 28 +++++ tools/objtool/check.c | 2 + tools/objtool/elf.c | 15 ++- 15 files changed, 520 insertions(+), 16 deletions(-) create mode 100644 Documentation/dev-tools/autofdo.rst create mode 100644 Documentation/dev-tools/propeller.rst create mode 100644 scripts/Makefile.autofdo create mode 100644 scripts/Makefile.propeller base-commit: 11066801dd4b7c4d75fce65c812723a80c1481ae