| Message ID | 1246039476-903-1-git-send-email-max@stro.at (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Friday 26 June 2009, maximilian attems wrote: > In the series for 2.6.31 it was noticed to ship the copyright, > but the generated changelog got lost somehow. > > As bonus the generated linux-image deb packages are Lenny lintian > clean. Acked-by: Frans Pop <elendil@planet.nl> > diff --git a/scripts/package/builddeb b/scripts/package/builddeb > index 01c2d13..b19f1f4 100644 > --- a/scripts/package/builddeb > +++ b/scripts/package/builddeb > @@ -16,6 +16,8 @@ create_package() { > Â Â Â Â Â Â Â Â local pname="$1" pdir="$2" > Â > Â Â Â Â Â Â Â Â cp debian/copyright "$pdir/usr/share/doc/$pname/" > +Â Â Â Â Â Â Â cp debian/changelog "$pdir/usr/share/doc/$pname/changelog.Debian" > +Â Â Â Â Â Â Â gzip -9 "$pdir/usr/share/doc/$pname/changelog.Debian" Wonder if it's really necessary to compress the changelog. It's always going to be small. AFAIK most files in doc (READMEs at least) are only compressed if they exceed a certain size. The default changelog is compressed even larger than the uncompressed original :-) Not a major issue though. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 26 June 2009, maximilian attems wrote: > In the series for 2.6.31 it was noticed to ship the copyright, > but the generated changelog got lost somehow. I don't think it got lost actually. Probably what happened is that the same assumption was made as for the copyright file: that dpkg-buildpackage copies it in place by default. Only it doesn't. I fixed that for the copyright file, but never thought that it also needed to be done for the changelog. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 26, 2009 at 08:47:01PM +0200, Frans Pop wrote: > > As bonus the generated linux-image deb packages are Lenny lintian > > clean. > > Acked-by: Frans Pop <elendil@planet.nl> thanks for quick reaction. > > Wonder if it's really necessary to compress the changelog. It's always > going to be small. AFAIK most files in doc (READMEs at least) are only > compressed if they exceed a certain size. > > The default changelog is compressed even larger than the uncompressed > original :-) > > Not a major issue though. lintian was moaning on uncomressed changelog. it also moaned if one didn't compress with max settings (maybe a stupid habit to strive for lintian clean packages) not that i mind a lot about the compression.. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 26, 2009 at 09:42:16PM +0200, Frans Pop wrote: > On Friday 26 June 2009, maximilian attems wrote: > > In the series for 2.6.31 it was noticed to ship the copyright, > > but the generated changelog got lost somehow. > > I don't think it got lost actually. Probably what happened is that the > same assumption was made as for the copyright file: that > dpkg-buildpackage copies it in place by default. Only it doesn't. > > I fixed that for the copyright file, but never thought that it also needed > to be done for the changelog. checked on 2.6.30 it wasn't shipped there too. so it is no regression, but would be still cool to have in 2.6.31. so that both generated copyright and changelog file are shipped. kind regards
On Saturday 27 June 2009, maximilian attems wrote: > lintian was moaning on uncomressed changelog. > it also moaned if one didn't compress with max settings > (maybe a stupid habit to strive for lintian clean packages) OK, let's leave it compressed then. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/scripts/package/builddeb b/scripts/package/builddeb index 01c2d13..b19f1f4 100644 --- a/scripts/package/builddeb +++ b/scripts/package/builddeb @@ -16,6 +16,8 @@ create_package() { local pname="$1" pdir="$2" cp debian/copyright "$pdir/usr/share/doc/$pname/" + cp debian/changelog "$pdir/usr/share/doc/$pname/changelog.Debian" + gzip -9 "$pdir/usr/share/doc/$pname/changelog.Debian" # Fix ownership and permissions chown -R root:root "$pdir"
In the series for 2.6.31 it was noticed to ship the copyright, but the generated changelog got lost somehow. As bonus the generated linux-image deb packages are Lenny lintian clean. Cc: Frans Pop <elendil@planet.nl> Cc: Andres Salomon <dilinger@debian.org> Signed-off-by: maximilian attems <max@stro.at> --- scripts/package/builddeb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)