diff mbox

[27/34] gfs2: Drop __TIME__ usage

Message ID 1302015561-21047-28-git-send-email-mmarek@suse.cz (mailing list archive)
State New, archived
Headers show

Commit Message

Michal Marek April 5, 2011, 2:59 p.m. UTC
The kernel already prints its build timestamp during boot, no need to
repeat it in random drivers and produce different object files each
time.

Cc: Steven Whitehouse <swhiteho@redhat.com>
Cc: cluster-devel@redhat.com
Signed-off-by: Michal Marek <mmarek@suse.cz>
---
 fs/gfs2/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Michal Marek May 25, 2011, 8:48 p.m. UTC | #1
Dne 5.4.2011 16:59, Michal Marek napsal(a):
> The kernel already prints its build timestamp during boot, no need to
> repeat it in random drivers and produce different object files each
> time.
> 
> Cc: Steven Whitehouse <swhiteho@redhat.com>
> Cc: cluster-devel@redhat.com
> Signed-off-by: Michal Marek <mmarek@suse.cz>
> ---
>  fs/gfs2/main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Hi,

I don't see this patch in today's linux-next. Any objection against me
applying it to the kbuild-2.6.git repository?

Thanks,
Michal


> diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
> index 72c31a3..07d057b 100644
> --- a/fs/gfs2/main.c
> +++ b/fs/gfs2/main.c
> @@ -143,7 +143,7 @@ static int __init init_gfs2_fs(void)
>  
>  	gfs2_register_debugfs();
>  
> -	printk("GFS2 (built %s %s) installed\n", __DATE__, __TIME__);
> +	printk("GFS2 installed\n");
>  
>  	return 0;
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Steven Whitehouse May 26, 2011, 8:43 a.m. UTC | #2
Hi,

On Wed, 2011-05-25 at 22:48 +0200, Michal Marek wrote:
> Dne 5.4.2011 16:59, Michal Marek napsal(a):
> > The kernel already prints its build timestamp during boot, no need to
> > repeat it in random drivers and produce different object files each
> > time.
> > 
> > Cc: Steven Whitehouse <swhiteho@redhat.com>
> > Cc: cluster-devel@redhat.com
> > Signed-off-by: Michal Marek <mmarek@suse.cz>
> > ---
> >  fs/gfs2/main.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Hi,
> 
> I don't see this patch in today's linux-next. Any objection against me
> applying it to the kbuild-2.6.git repository?
> 
> Thanks,
> Michal
> 
No, I think that should be ok. It was added as a method to spot when
someone had compiled their own module against a distro kernel, but tbh
this isn't a problem in practice, so I don't think it will be a problem,

Steve.


--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michal Marek May 26, 2011, 9:08 a.m. UTC | #3
On 26.5.2011 10:43, Steven Whitehouse wrote:
>> I don't see this patch in today's linux-next. Any objection against me
>> applying it to the kbuild-2.6.git repository?
>>
> No, I think that should be ok. It was added as a method to spot when
> someone had compiled their own module against a distro kernel, but tbh
> this isn't a problem in practice, so I don't think it will be a problem,

OK, thanks. Applied to kbuild-2.6.git#trivial.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
index 72c31a3..07d057b 100644
--- a/fs/gfs2/main.c
+++ b/fs/gfs2/main.c
@@ -143,7 +143,7 @@  static int __init init_gfs2_fs(void)
 
 	gfs2_register_debugfs();
 
-	printk("GFS2 (built %s %s) installed\n", __DATE__, __TIME__);
+	printk("GFS2 installed\n");
 
 	return 0;