| Message ID | 1313384834-24433-11-git-send-email-lacombar@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Michal, On Mon, Aug 15, 2011 at 1:07 AM, Arnaud Lacombe <lacombar@gmail.com> wrote: > Usage of these flags has been deprecated for nearly 4 years by: > > commit f77bf01425b11947eeb3b5b54685212c302741b8 > Author: Sam Ravnborg <sam@neptun.(none)> > Date: Mon Oct 15 22:25:06 2007 +0200 > > kbuild: introduce ccflags-y, asflags-y and ldflags-y > > Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command > line use. By default, gmake(1) do not override command line setting, so this is > likely to result in build failure or unexpected behavior. > > Do not advertise for its usage. > > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: linux-kbuild@vger.kernel.org > ping ? - Arnaud > --- > scripts/Makefile.build | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index a0fd502..d2b366c 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -46,7 +46,7 @@ include $(kbuild-file) > # If the save-* variables changed error out > ifeq ($(KBUILD_NOPEDANTIC),) > ifneq ("$(save-cflags)","$(CFLAGS)") > - $(error CFLAGS was changed in "$(kbuild-file)". Fix it to use EXTRA_CFLAGS) > + $(error CFLAGS was changed in "$(kbuild-file)". Fix it to use ccflags-y) > endif > endif > > -- > 1.7.6.153.g78432 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 15, 2011 at 01:07:13AM -0400, Arnaud Lacombe wrote: > Usage of these flags has been deprecated for nearly 4 years by: > > commit f77bf01425b11947eeb3b5b54685212c302741b8 > Author: Sam Ravnborg <sam@neptun.(none)> > Date: Mon Oct 15 22:25:06 2007 +0200 > > kbuild: introduce ccflags-y, asflags-y and ldflags-y > > Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command > line use. By default, gmake(1) do not override command line setting, so this is > likely to result in build failure or unexpected behavior. > > Do not advertise for its usage. > > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: linux-kbuild@vger.kernel.org Thanks, I applied this to kbuild-2.6.git#kbuild with your signoff assumed. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/scripts/Makefile.build b/scripts/Makefile.build index a0fd502..d2b366c 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -46,7 +46,7 @@ include $(kbuild-file) # If the save-* variables changed error out ifeq ($(KBUILD_NOPEDANTIC),) ifneq ("$(save-cflags)","$(CFLAGS)") - $(error CFLAGS was changed in "$(kbuild-file)". Fix it to use EXTRA_CFLAGS) + $(error CFLAGS was changed in "$(kbuild-file)". Fix it to use ccflags-y) endif endif
Usage of these flags has been deprecated for nearly 4 years by: commit f77bf01425b11947eeb3b5b54685212c302741b8 Author: Sam Ravnborg <sam@neptun.(none)> Date: Mon Oct 15 22:25:06 2007 +0200 kbuild: introduce ccflags-y, asflags-y and ldflags-y Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command line use. By default, gmake(1) do not override command line setting, so this is likely to result in build failure or unexpected behavior. Do not advertise for its usage. Cc: Sam Ravnborg <sam@ravnborg.org> Cc: linux-kbuild@vger.kernel.org --- scripts/Makefile.build | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)