From patchwork Mon Apr 29 18:00:19 2013
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Steven Rostedt <rostedt@goodmis.org>
X-Patchwork-Id: 2500751
Return-Path: <linux-kbuild-owner@vger.kernel.org>
X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org
Delivered-To: patchwork-process-083081@patchwork2.kernel.org
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by patchwork2.kernel.org (Postfix) with ESMTP id 1C12AE00DD
	for <patchwork-linux-kbuild@patchwork.kernel.org>;
	Mon, 29 Apr 2013 18:00:31 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756715Ab3D2SAZ (ORCPT
	<rfc822;patchwork-linux-kbuild@patchwork.kernel.org>);
	Mon, 29 Apr 2013 14:00:25 -0400
Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:11448 "EHLO
	hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by
	vger.kernel.org with ESMTP id S1758114Ab3D2SAV (ORCPT
	<rfc822;linux-kbuild@vger.kernel.org>);
	Mon, 29 Apr 2013 14:00:21 -0400
X-Authority-Analysis: v=2.0 cv=DKcNElxb c=1 sm=0
	a=rXTBtCOcEpjy1lPqhTCpEQ==:17 a=mNMOxpOpBa8A:10
	a=tjVB2_0LW7QA:10 a=5SG0PmZfjMsA:10 a=IkcTkHD0fZMA:10
	a=meVymXHHAAAA:8 a=RjNv2aZ5rOIA:10 a=RayWKXQuETgw7g_COO0A:9
	a=QEXdDO2ut3YA:10 a=rXTBtCOcEpjy1lPqhTCpEQ==:117
X-Cloudmark-Score: 0
X-Authenticated-User: 
X-Originating-IP: 74.67.115.198
Received: from [74.67.115.198] ([74.67.115.198:54054] helo=[192.168.23.10])
	by hrndva-oedge03.mail.rr.com (envelope-from <rostedt@goodmis.org>)
	(ecelerity 2.2.3.46 r()) with ESMTP
	id 9F/93-12729-335BE715; Mon, 29 Apr 2013 18:00:19 +0000
Message-ID: <1367258419.30667.20.camel@gandalf.local.home>
Subject: Re: strange behaviour from "make localmodconfig" throws out ath9k
	stuff
From: Steven Rostedt <rostedt@goodmis.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Date: Mon, 29 Apr 2013 14:00:19 -0400
In-Reply-To: <alpine.DEB.2.02.1304291121180.26536@oneiric>
References: <alpine.DEB.2.02.1304261459030.17575@oneiric>
	<20130427153833.GC3355@free.fr>
	<alpine.DEB.2.02.1304271325240.12586@oneiric>
	<20130427174226.GA25088@free.fr>
	<alpine.DEB.2.02.1304271412250.27554@oneiric>
	<20130428202854.GC4571@free.fr>
	<alpine.DEB.2.02.1304290645150.16211@oneiric>
	<1367244700.28120.6.camel@fedora>
	<alpine.DEB.2.02.1304291022320.9234@oneiric>
	<1367246499.30667.9.camel@gandalf.local.home>
	<alpine.DEB.2.02.1304291056410.13584@oneiric>
	<1367248388.30667.13.camel@gandalf.local.home>
	<alpine.DEB.2.02.1304291121180.26536@oneiric>
X-Mailer: Evolution 3.4.4-2 
Mime-Version: 1.0
Sender: linux-kbuild-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kbuild.vger.kernel.org>
X-Mailing-List: linux-kbuild@vger.kernel.org

Can you add this patch and see if it fixes your issue. If so, can I add
your "tested-by" to this patch?

Thanks,

-- Steve
---
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
index 3368939..4606cdf 100644
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -156,7 +156,6 @@ sub read_kconfig {
 
     my $state = "NONE";
     my $config;
-    my @kconfigs;
 
     my $cont = 0;
     my $line;
@@ -190,7 +189,13 @@ sub read_kconfig {
 
 	# collect any Kconfig sources
 	if (/^source\s*"(.*)"/) {
-	    $kconfigs[$#kconfigs+1] = $1;
+	    my $kconfig = $1;
+	    # prevent reading twice.
+	    if (!defined($read_kconfigs{$kconfig})) {
+		$read_kconfigs{$kconfig} = 1;
+		read_kconfig($kconfig);
+	    }
+	    next;
 	}
 
 	# configs found
@@ -250,14 +255,6 @@ sub read_kconfig {
 	}
     }
     close($kinfile);
-
-    # read in any configs that were found.
-    foreach my $kconfig (@kconfigs) {
-	if (!defined($read_kconfigs{$kconfig})) {
-	    $read_kconfigs{$kconfig} = 1;
-	    read_kconfig($kconfig);
-	}
-    }
 }
 
 if ($kconfig) {