From patchwork Mon Sep 16 18:31:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 2899261 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 786359F1C0 for ; Mon, 16 Sep 2013 18:31:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8E700201C7 for ; Mon, 16 Sep 2013 18:31:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 385C42015A for ; Mon, 16 Sep 2013 18:31:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775Ab3IPSbg (ORCPT ); Mon, 16 Sep 2013 14:31:36 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:47526 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752080Ab3IPSbg (ORCPT ); Mon, 16 Sep 2013 14:31:36 -0400 Received: by mail-pa0-f52.google.com with SMTP id kq13so5697690pab.11 for ; Mon, 16 Sep 2013 11:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=doQQq7K9gudnNB635xWOjzbFviXUGQauI3BoLZwojr8=; b=MBWiGD1a+UayhEpdqTO+xJZjJ68P3DBaO+5aDht38NvRfrxn2Qd73YeVsRIXtpb+wj rt3zN0pyE/u1BCXS49YFWfxKRrwsnf5gUqjhHY/dI1Higr0rAh2GWB23ygpk2pcjCt/V rU13JAWyZttwoWpNTZu0K6O6Rr8O6wJjq20Vg3u9arpVi3cgdSnwCQ6Pl96Qiyx9zSBD IQWYtnKDkDEcKJe+nwGxwXTtlAy/EaYg8IW2wxSI+yel9XAepBe0YCZNSyvIw0o0o7C2 mix7dE45PGbqfxPgV1v0MLWnrsAQQBg+arY95l3oWqPcwpJZKMDv14wmRbncwOLXNzvw VxMg== X-Received: by 10.68.194.104 with SMTP id hv8mr3369084pbc.168.1379356295538; Mon, 16 Sep 2013 11:31:35 -0700 (PDT) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by mx.google.com with ESMTPSA id yo2sm40298276pab.8.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 16 Sep 2013 11:31:34 -0700 (PDT) From: Guenter Roeck To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Michal Marek , Rusty Russell , Geert Uytterhoeven , Guenter Roeck Subject: [PATCH v2] modpost: Fix secondary errors seen if a single module build fails Date: Mon, 16 Sep 2013 11:31:24 -0700 Message-Id: <1379356284-15804-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 1.7.9.7 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit ea4054a23 (modpost: handle huge numbers of modules) added support for building a large number of modules. Unfortunately, the commit changed the semantics of the makefile: Instead of passing only existing object files to modpost, make now passes all expected object files. If make was started with option -i, this results in a modpost error if a single file failed to build. Example with the current btrfs build falure on m68k: fs/btrfs/btrfs.o: No such file or directory make[1]: [__modpost] Error 1 (ignored) This error is followed by lots of errors such as: m68k-linux-gcc: error: arch/m68k/emu/nfcon.mod.c: No such file or directory m68k-linux-gcc: fatal error: no input files compilation terminated. make[1]: [arch/m68k/emu/nfcon.mod.o] Error 1 (ignored) This doesn't matter much for normal builds, but it is annoying for builds started with "make -i" due to the large number of secondary errors. Those errors unnececessarily clog any error log and make it difficult to find the real errors in the build. Fix the problem by only passing existing object files to modpost. Cc: Rusty Russell Signed-off-by: Guenter Roeck Acked-by: Rusty Russell --- v2: Use "xargs -r ls 2>/dev/null" instead of a shell while loop to filter for existing files. Not sure if this is much better, but it is an alternative. If anyone has a better solution, please let me know. [Another option would be to use 'find' (no parameters) instead of 'ls', but that would still require the error redirect.] scripts/Makefile.modpost | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost index 8dcdca2..edc4394 100644 --- a/scripts/Makefile.modpost +++ b/scripts/Makefile.modpost @@ -81,7 +81,8 @@ modpost = scripts/mod/modpost \ # We can go over command line length here, so be careful. quiet_cmd_modpost = MODPOST $(words $(filter-out vmlinux FORCE, $^)) modules - cmd_modpost = $(MODLISTCMD) | sed 's/\.ko$$/.o/' | $(modpost) -s -T - + cmd_modpost = $(MODLISTCMD) | sed 's/\.ko$$/.o/' | \ + xargs -r ls 2>/dev/null | $(modpost) -s -T - PHONY += __modpost __modpost: $(modules:.ko=.o) FORCE